From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6450015460633083904 X-Received: by 10.129.92.195 with SMTP id q186mr1106408ywb.158.1502134912857; Mon, 07 Aug 2017 12:41:52 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.107.173.71 with SMTP id w68ls1559741ioe.23.gmail; Mon, 07 Aug 2017 12:41:52 -0700 (PDT) X-Received: by 10.31.169.72 with SMTP id s69mr960313vke.43.1502134912610; Mon, 07 Aug 2017 12:41:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502134912; cv=none; d=google.com; s=arc-20160816; b=qse4fg0Q+SfAsXttkHSJnlDRFnGQ8FFZp1Hx/eO9Get6IKARrZBQy2aaRinyC3D+/4 dHXMcHmDojJDwQzzkJNh7p0IUEHBRGavnFNy/KOGImxNLB1/oJrn3jUvrmiWDnlonoL9 o9CIQ6KMLEmfXhbFTJ/0ubwV2agLGuBKWhY6HJ109jE3mWOnWBhDN+9U+h9FrUzgy24C lsGOq0a+/X2Al5F7F/IyU9hjYhpY5NiUl5uaD1mBcYG7xZhbNPCa5blAJz7z/+Pbm5A3 W+WICM14H20kO0B89fopH3+hrRxtJZIy5h/r/QVs6nqGtlGtksXbQC1zEqKjv22P3Hco Rdjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:arc-authentication-results; bh=By1khOV02LasnNQKO+BV2sgNzBPK7EMbukTtm4s05KM=; b=iFduaaxaJSfiPJmjUuHefpTur0o8z8wktSTqChnYRdWDzveuH0qgt9z9IJIglymybD jpklthjyCGRpDjt/6iJaPKSZ34Tu3JdE1BfQzE8h6jYchSjZv2fdz9i0UKW69PhWFbrT WkzE4dFp1IyRIalPD6EtWBkGNI/HIHhaYCDBbsuB7mp1tn/bbKW9dwlV/OgOhDcFiuHI WdqU4gu3f+rNWep9Bt8MtcrntEVyL1UIin9vAH32byDw/4Q7NOrPYVAW2VL2CNEBqmni OAeN+cAYhliR3OTwzy3MB+VDzTcDOrhIUONK3huAyNTqrH1/hVOLOkBiiFDc2WPvzsyF g9GQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.b=sSfLNAcu; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c09::244 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qk0-x244.google.com (mail-qk0-x244.google.com. [2607:f8b0:400d:c09::244]) by gmr-mx.google.com with ESMTPS id x8si523844ywg.12.2017.08.07.12.41.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Aug 2017 12:41:52 -0700 (PDT) Received-SPF: pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c09::244 as permitted sender) client-ip=2607:f8b0:400d:c09::244; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.b=sSfLNAcu; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c09::244 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: by mail-qk0-x244.google.com with SMTP id d145so1433063qkc.0 for ; Mon, 07 Aug 2017 12:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=By1khOV02LasnNQKO+BV2sgNzBPK7EMbukTtm4s05KM=; b=sSfLNAcuTnj6Or20jpWsrBnKrtaz/VAFvv1qWNp0TugJhz56UYjFFjkca3KbMpxNUA riHECe2YuKYb5p29QvsoFK/5gSBM4PLAowW3DN32bOpCnBxQUzbtD9IEdvBXsegor2wI 9ZDYkD4diUPfqUuz3yQtIGZbUNZ9K01J/2FkW4ZhMXs/XAxOhc2qu+5aPMtF/N0n+XVq 4cyQzgix6T7P7tYCp/GDPmAcRv2Hv4n43UrnWs89aDd32E2REYHjfCLU4dYecfttiNzf OqD47mchwKIs/bBMFqDCoR/BYWos8drjW2LF1voExGVHnnpjZ6Y6oQ9x4DRGOTJ4xU2i ZDdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=By1khOV02LasnNQKO+BV2sgNzBPK7EMbukTtm4s05KM=; b=VZ9V7VKg29ieBIt8qYsyHQmoXWmtov6phc5kU/srQRcDaisY+9onRRrPRxA+iwy/R9 OwyjWZ26bMjSqV3wCbHLkoyr7OJJLdtDvHx8kYPKfTeEeQ8VatVtwEuNAZg/BKkMrNGQ yr5PtHBBOodtPnviRCA1cogORLbgRrfEJqXpVOEVPXCD87cfNcnTOwUjO9La2WDKUYc2 0MtYOzw1xnNmkqMcWgK3yMew/WZtx9TpWpFXYBHLL38eErJ8VLYrW8/uRVeieEGefW9U klnBo9/t35DjUS1C+LEMTdo+XELmbCaaoQy/QDlXHBUW3E+cA15ann9EJDbIdtTs9+TY voxQ== X-Gm-Message-State: AHYfb5ji+IKOyErqVb4cMsokE2FOuJp3uEENlRtG3r7MYj53g/b75BOL yv6um24QuVIu3a2qQZfehvgT/3T59Q== X-Received: by 10.55.34.67 with SMTP id i64mr2426798qki.128.1502134912427; Mon, 07 Aug 2017 12:41:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.148.188 with HTTP; Mon, 7 Aug 2017 12:41:52 -0700 (PDT) In-Reply-To: <74592c466b9e38b431fa17b3d98f32a6df7858dd.1501760818.git.henning.schild@siemens.com> References: <74592c466b9e38b431fa17b3d98f32a6df7858dd.1501760818.git.henning.schild@siemens.com> From: Alexander Smirnov Date: Mon, 7 Aug 2017 22:41:52 +0300 Message-ID: Subject: Re: [PATCH 0-10 of 16 v2 8/8] meta: dpkg: reorder and rename do_install to install in addtask To: Henning Schild Cc: isar-users@googlegroups.com Content-Type: multipart/alternative; boundary="001a1145b076dc2a0205562f09c4" X-TUID: 3sbRUF5qG8rw --001a1145b076dc2a0205562f09c4 Content-Type: text/plain; charset="UTF-8" 2017-08-03 14:55 GMT+03:00 Henning Schild : > the reordering should improve readability > when adding a task you skip the do_ prefix > > Signed-off-by: Henning Schild > --- > meta/classes/dpkg.bbclass | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index 36e047a..ca0c5ab 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -23,12 +23,12 @@ do_build() { > sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR} > } > > -do_install[stamp-extra-info] = "${MACHINE}" > > # Install package to dedicated deploy directory > do_install() { > install -m 755 ${BUILDROOT}/*.deb ${DEPLOY_DIR_DEB}/ > } > > -addtask do_install after do_build > +addtask install after do_build > do_install[dirs] = "${DEPLOY_DIR_DEB}" > +do_install[stamp-extra-info] = "${MACHINE}" > -- > 2.13.0 > > Applied to asmirnov/next --001a1145b076dc2a0205562f09c4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@sie= mens.com>:
the reordering s= hould improve readability
when adding a task you skip the do_ prefix

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
=C2=A0meta/classes/dpkg.bbclass | 4 ++--
=C2=A01 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index 36e047a..ca0c5ab 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -23,12 +23,12 @@ do_build() {
=C2=A0 =C2=A0 =C2=A0sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DI= R}
=C2=A0}

-do_install[stamp-extra-info] =3D "${MACHINE}"

=C2=A0# Install package to dedicated deploy directory
=C2=A0do_install() {
=C2=A0 =C2=A0 =C2=A0install -m 755 ${BUILDROOT}/*.deb ${DEPLOY_DIR_DEB}/ =C2=A0}

-addtask do_install after do_build
+addtask install after do_build
=C2=A0do_install[dirs] =3D "${DEPLOY_DIR_DEB}"
+do_install[stamp-extra-info] =3D "${MACHINE}"
--
2.13.0


Appli= ed to asmirnov/next
--001a1145b076dc2a0205562f09c4--