Re: [PATCH 0-10 of 16 v2 0/8] splitting the previous q

[Alexander Smirnov <alex.bluesman.smirnov@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2438 bytes --]

Hi,

2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> Since the first q was pretty long with 16 patches and some of the later
> ones
> still need to be dicsussed in more detail, i decided to split the q and
> send
> the less controversial stuff first.
>
> Changes to V1:
>
> - dropped 01/16 from v1
>   - ext4 is not on the wic path, it can keep its obvious bugs
> - 02/16 is 1v2, added copyright header
> - 03/16 is 2v2, keep it seperate after all (logical vs. structural)
> - 04/16 is 3v2, do not touch bitbake anymore
> - 05/16 is 4v2, do not introduce CROSSBUILDCHROOT_DIR, add license header
> - 06/16 is 5v2, keep it seperate after all (logical vs. structural)
> - 07/16 dropped
> - 08/16 is 6v2, no image-class anymore, update comment
> - 09/16 is 7v2, nothing changed
> - 10/16 is 8v2, updated comment
>
>
I have new comments regarding v2 series. But to somehow move the work
forward, I've partially applied your patches to asmirnov/next branch. Huge
series are very hard to review and apply at once, so I'd propose to send
them in small parts.


>
> Henning Schild (8):
>   meta: classes: use base.bbclass from bitbake
>   meta: isar-base: remove unused function
>   remove redundant variable THISDIR
>   meta: conf: use bitbake.conf from bitbake and apply local changes
>   meta: conf: clean up local bitbake config
>   classes: move fetch and unpack into isar-base
>   meta: dpdk use [dirs] directive instead of mkdir
>   meta: dpkg: reorder and rename do_install to install in addtask
>
>  meta-isar/recipes-core/images/isar-image-base.bb |  8 +--
>  meta/classes/base.bbclass                        | 81
> +-----------------------
>  meta/classes/dpkg.bbclass                        | 46 ++------------
>  meta/classes/ext4-img.bbclass                    |  2 +
>  meta/classes/isar-base.bbclass                   | 55 ++++++++++++++++
>  meta/conf/bitbake.conf.sample                    | 68 --------------------
>  meta/conf/isar-bitbake.conf                      | 31 +++++++++
>  meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +--
>  scripts/isar-setup-builddir                      | 33 ++++++++--
>  9 files changed, 134 insertions(+), 200 deletions(-)
>  mode change 100644 => 120000 meta/classes/base.bbclass
>  create mode 100644 meta/classes/isar-base.bbclass
>  delete mode 100644 meta/conf/bitbake.conf.sample
>  create mode 100644 meta/conf/isar-bitbake.conf
>
> --
> 2.13.0
>
>

[-- Attachment #2: Type: text/html, Size: 3349 bytes --]