From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6450015460633083904 X-Received: by 10.36.79.88 with SMTP id c85mr1254560itb.34.1502135056876; Mon, 07 Aug 2017 12:44:16 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.107.55.7 with SMTP id e7ls7971724ioa.35.gmail; Mon, 07 Aug 2017 12:44:16 -0700 (PDT) X-Received: by 10.31.94.85 with SMTP id s82mr973743vkb.37.1502135056602; Mon, 07 Aug 2017 12:44:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502135056; cv=none; d=google.com; s=arc-20160816; b=nl6+iW0aXGMZJOwL44PQeWy8hC1FoeaJkis0HVVR6/8L6C8qonLLkhDvw6U8YOP8+A LYR3rcGAYSp6/RWHCjNnCgDfQFRa6mcxMy9yH251jTd/WqVvd0IBa/BQFi4XCk9QeiYF 28xPoV9I5FGYfz8O1UWUQesSDSIjycmKYY+1bgSr8jICR3AsshcdovQtaOZGif07eY3y ChkK3bPp/9GQAG3grVu3NDG6ynP1oO/HllmgosDlMt7vX23qDCb50B3uWeigae36M+fs 6F+ZwR1kZm9G50/O4NCY9s1JN9gR+m6oUh4IWCqxhgkt5C/QMbSCCDLOvY+358UaaK0C 4hDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:arc-authentication-results; bh=m/wktBdu09mWOLxSTcozUv9h5BD3jhMug13an/XPm9I=; b=lOvqxI/ZEqbkgv02emxfzE5siq/JdyeY5J13JGRYvZXQ6ycVvL8c5xgNOn8sEtxxRZ eaNELhGSDnctNxIRNEDo0zMHpcyckYtq/I149ndwqkMnTFUC1G1KirLlBjUvYsd+jFzK xe3tQLUVf6IOyu2SpI/+dUuRnd0MibJ8FpUX/GwGKLrhXq8KrcPsRX/tvkXQwnrQ7ZOs tyVatCF1H/0EtceKPQlqsa9dVWlZ9Qk+fln8kw3n+lJMxvZxiis2jn8YV3GTEXgnKMo6 jSiG3pLJ/XjBd53nSZP0adD+MSd/hOD22bY92067wbC3ugRxrWznUTKPuUotKlbi1wZS qh8g== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.b=kylu/dVo; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::22e as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qt0-x22e.google.com (mail-qt0-x22e.google.com. [2607:f8b0:400d:c0d::22e]) by gmr-mx.google.com with ESMTPS id r67si532674ywg.9.2017.08.07.12.44.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Aug 2017 12:44:16 -0700 (PDT) Received-SPF: pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::22e as permitted sender) client-ip=2607:f8b0:400d:c0d::22e; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.b=kylu/dVo; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::22e as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: by mail-qt0-x22e.google.com with SMTP id p3so8737809qtg.2 for ; Mon, 07 Aug 2017 12:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=m/wktBdu09mWOLxSTcozUv9h5BD3jhMug13an/XPm9I=; b=kylu/dVozs1ORlh8nZFHPZWIjUfr3ldxJBXe9bidLB5yS5jThGBbfE94Z+9F4vaQCd +WK8tQLSVKbWaa5rBgGvUlLdu7WuHEgVsKgBr2JzCXw2BnwXpTmMB1/VoegQCjVSxZ2k lo7f5Xc+43RYBA2611fVbdv3BCEsjtTNUweUbPQfEuOkOOULYCOgLcVeFdPFKIWRKsSZ 7nTmf9ZGDBwNCVGuHT5W5RAtSvjXVwwQDtO6toEkj4tdv7mUo7N8tsPMiK+Y+TnyPm6Z mCCurAnxsgJN5cJQZ7TpM0RLYkWC+Rv5/hdFaLxZpq1iHEShr8TKPF4wMoIIbggk3qqW gjBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=m/wktBdu09mWOLxSTcozUv9h5BD3jhMug13an/XPm9I=; b=Ubc+aUU4VEsHsAw8Zn9AeJTisg6pBC3cR3feZJ19GWx8WuhABn4lql2TU91B90Rb5N L9Lrs2IdzHY9BoMfLdXQn3H2USe0T4RRkH2oP1t/Mleb1i2ddNeoF9mwlKBQU8HTZSWj GDknoBs1DTDCh6niUN3MfKxtUiIDOANicPqR7BEyf7jeA+xCrrpEO+1iKbiK5o45bsLv p9N1i2Gbrgww8OXEYvyHolbtGITnn4PTfHyrnV67CnpFPeP2CKVi80p4v6JmgMiT3+ng YP7fEsaqLxcAWOe60s+VTei0hF+ywM5/HUUq3PzwWmzLLqa3Mc31pPG0+zY8oKSVOssA /0Jg== X-Gm-Message-State: AHYfb5hmHlHcRjPozdNFg0zJU2YFvLtJiSHg2n04hnb5cTWkFgH9x+BP yKdmjtFTYoUzHCjiaocBWOFSDStntQ== X-Received: by 10.200.45.240 with SMTP id q45mr2518819qta.332.1502135056335; Mon, 07 Aug 2017 12:44:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.148.188 with HTTP; Mon, 7 Aug 2017 12:44:15 -0700 (PDT) In-Reply-To: References: From: Alexander Smirnov Date: Mon, 7 Aug 2017 22:44:15 +0300 Message-ID: Subject: Re: [PATCH 0-10 of 16 v2 0/8] splitting the previous q To: Henning Schild Cc: isar-users@googlegroups.com Content-Type: multipart/alternative; boundary="001a113a81f070072705562f1293" X-TUID: bRdrPo1kNIes --001a113a81f070072705562f1293 Content-Type: text/plain; charset="UTF-8" Hi, 2017-08-03 14:55 GMT+03:00 Henning Schild : > Since the first q was pretty long with 16 patches and some of the later > ones > still need to be dicsussed in more detail, i decided to split the q and > send > the less controversial stuff first. > > Changes to V1: > > - dropped 01/16 from v1 > - ext4 is not on the wic path, it can keep its obvious bugs > - 02/16 is 1v2, added copyright header > - 03/16 is 2v2, keep it seperate after all (logical vs. structural) > - 04/16 is 3v2, do not touch bitbake anymore > - 05/16 is 4v2, do not introduce CROSSBUILDCHROOT_DIR, add license header > - 06/16 is 5v2, keep it seperate after all (logical vs. structural) > - 07/16 dropped > - 08/16 is 6v2, no image-class anymore, update comment > - 09/16 is 7v2, nothing changed > - 10/16 is 8v2, updated comment > > I have new comments regarding v2 series. But to somehow move the work forward, I've partially applied your patches to asmirnov/next branch. Huge series are very hard to review and apply at once, so I'd propose to send them in small parts. > > Henning Schild (8): > meta: classes: use base.bbclass from bitbake > meta: isar-base: remove unused function > remove redundant variable THISDIR > meta: conf: use bitbake.conf from bitbake and apply local changes > meta: conf: clean up local bitbake config > classes: move fetch and unpack into isar-base > meta: dpdk use [dirs] directive instead of mkdir > meta: dpkg: reorder and rename do_install to install in addtask > > meta-isar/recipes-core/images/isar-image-base.bb | 8 +-- > meta/classes/base.bbclass | 81 > +----------------------- > meta/classes/dpkg.bbclass | 46 ++------------ > meta/classes/ext4-img.bbclass | 2 + > meta/classes/isar-base.bbclass | 55 ++++++++++++++++ > meta/conf/bitbake.conf.sample | 68 -------------------- > meta/conf/isar-bitbake.conf | 31 +++++++++ > meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +-- > scripts/isar-setup-builddir | 33 ++++++++-- > 9 files changed, 134 insertions(+), 200 deletions(-) > mode change 100644 => 120000 meta/classes/base.bbclass > create mode 100644 meta/classes/isar-base.bbclass > delete mode 100644 meta/conf/bitbake.conf.sample > create mode 100644 meta/conf/isar-bitbake.conf > > -- > 2.13.0 > > --001a113a81f070072705562f1293 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@sie= mens.com>:
Since the first = q was pretty long with 16 patches and some of the later ones
still need to be dicsussed in more detail, i decided to split the q and sen= d
the less controversial stuff first.

Changes to V1:

- dropped 01/16 from v1
=C2=A0 - ext4 is not on the wic path, it can keep its obvious bugs
- 02/16 is 1v2, added copyright header
- 03/16 is 2v2, keep it seperate after all (logical vs. structural)
- 04/16 is 3v2, do not touch bitbake anymore
- 05/16 is 4v2, do not introduce CROSSBUILDCHROOT_DIR, add license header - 06/16 is 5v2, keep it seperate after all (logical vs. structural)
- 07/16 dropped
- 08/16 is 6v2, no image-class anymore, update comment
- 09/16 is 7v2, nothing changed
- 10/16 is 8v2, updated comment


I have new comments regarding v2 serie= s. But to somehow move the work forward, I've partially applied your pa= tches to asmirnov/next branch. Huge series are very hard to review and appl= y at once, so I'd propose to send them in small parts.
=C2=A0=

Henning Schild (8):
=C2=A0 meta: classes: use base.bbclass from bitbake
=C2=A0 meta: isar-base: remove unused function
=C2=A0 remove redundant variable THISDIR
=C2=A0 meta: conf: use bitbake.conf from bitbake and apply local changes =C2=A0 meta: conf: clean up local bitbake config
=C2=A0 classes: move fetch and unpack into isar-base
=C2=A0 meta: dpdk use [dirs] directive instead of mkdir
=C2=A0 meta: dpkg: reorder and rename do_install to install in addtask

=C2=A0meta-isar/recipes-core/images/isar-image-base.bb |=C2=A0 8 += --
=C2=A0meta/classes/base.bbclass=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 81 +-----------------------
=C2=A0meta/classes/dpkg.bbclass=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 46 ++------------
=C2=A0meta/classes/ext4-img.bbclass=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 2 +
=C2=A0meta/classes/isar-base.bbclass=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 55 ++++++++++++++++
=C2=A0meta/conf/bitbake.conf.sample=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 68 --------------------
=C2=A0meta/conf/isar-bitbake.conf=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 31 +++++++++
=C2=A0meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +--
=C2=A0scripts/isar-setup-builddir=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 33 ++++++++--
=C2=A09 files changed, 134 insertions(+), 200 deletions(-)
=C2=A0mode change 100644 =3D> 120000 meta/classes/base.bbclass
=C2=A0create mode 100644 meta/classes/isar-base.bbclass
=C2=A0delete mode 100644 meta/conf/bitbake.conf.sample
=C2=A0create mode 100644 meta/conf/isar-bitbake.conf

--
2.13.0


--001a113a81f070072705562f1293--