From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247988281769984 X-Received: by 10.129.164.79 with SMTP id b76mr14211052ywh.40.1501668709577; Wed, 02 Aug 2017 03:11:49 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.107.57.195 with SMTP id g186ls2832745ioa.25.gmail; Wed, 02 Aug 2017 03:11:49 -0700 (PDT) X-Received: by 10.99.43.83 with SMTP id r80mr15675776pgr.95.1501668709245; Wed, 02 Aug 2017 03:11:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501668709; cv=none; d=google.com; s=arc-20160816; b=eoo9qo/UN+zpfqj6eSJpPSFplHxP/6m6xrVYsmFwtKuYjTBo8SyD0CgICALcAtLsAz bCdieod9GUgufvItSv0918ILYL7CXm74HSRtKwEvYGGwgISx3Fot46TR7/VzZMSsUkK5 ugpP+MIg1pNaIN/ghhOHnZrbKSr46zVV/UvsQb02bNpxWxllqbK+AAVCQYaajpSpZTWc ovdyvPJEeCGnORp/aIVJ6IkHLTeRtL8g+lkRS4pfSOUahMPLq21csKj0ti64gkjMOA6R jr/HntDyN5s9DnROExsx59637HFDi5xRMVh4l3tTEc1rvVxj6dJCNZYPQOFTBhl/aL1P nYNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:arc-authentication-results; bh=QUluv6o6u1SsNDbLQcHhvB9rzqfedbm2m5++y35xqlQ=; b=N5s4yuMTTwiHH8Qj4/rINDcywldIvefPS/H/ta2m60mjR+9UcdnksnA4bMHk/o5BU5 NBhf6KbOUjzj5w2uTNV0mHVuqgL7b7T8z66Lgajhlxj7Pc6+Bv0eq6rxhovdomxMkSzf qF4YCu5J4FfbPpEB93AAHNk9NbOIdhEMHUsvLn5qqlH4ob0gA8/cdIWBPiBt9dy50ZrB NHGwLitW5snZdQcB+EYna6/H9ZaLraiZZv8UcgRBDXr1HC1DlNkggPq1DK8jCmHyy0dt p5TM+CNHkoEy/i0GGKjLaDt8f2UZhzUXizZ5rCvcKlxMMjfdbFJvY4jbV6L4YdEpGqBb w/pA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.b=T1WWTw12; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::22c as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qt0-x22c.google.com (mail-qt0-x22c.google.com. [2607:f8b0:400d:c0d::22c]) by gmr-mx.google.com with ESMTPS id i81si414701ywe.18.2017.08.02.03.11.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Aug 2017 03:11:49 -0700 (PDT) Received-SPF: pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::22c as permitted sender) client-ip=2607:f8b0:400d:c0d::22c; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.b=T1WWTw12; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::22c as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: by mail-qt0-x22c.google.com with SMTP id t37so23972216qtg.5 for ; Wed, 02 Aug 2017 03:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QUluv6o6u1SsNDbLQcHhvB9rzqfedbm2m5++y35xqlQ=; b=T1WWTw12sUDsW/lbxhr45+qoKBz0AX3tb4QPrRKuBnyHcvWPy565SkwVzdaTgVYuK3 NPYwnVvtFPZJ5Tvqsk3ZpEAgoBgraOXvpCTc0rD9mgO4Kwdj5FSKt1eotrnlQrbH70Vi 8FgeiG9gf8SGcMG4nn3ZsZ/m8DDA7H3akCgcY2JrhKPLCmIlLf0KEpkfclTtmj+UmVig sL5ix2Sep2ulN6gQjKWia/Q4y2wwEUEbb3a/MKo7JA+ef/2lYgxSpc7UlnkDS3nIZgyz NQqzbt5iPqvjNOv6eudLE0RqtsozQ/8gg4xv7UrDrQ4RZ4Ol6a3QyYDGDx5f6wbhuQfD ddUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QUluv6o6u1SsNDbLQcHhvB9rzqfedbm2m5++y35xqlQ=; b=ZO6g6fLl7CuTyurByNw8MxvHM9HsD6b/IUup8OVA0/w+eKU46dLvKhN9YUFG/8fEto g3HOa2HPhUYxgomFy5Yhn//rgkGmSccyvbQg3hYieutFb4CimOxfpforNCcuaJdbnlsa qiiBub9lHVVjw2TdF6KCyEvN6rlUYDgSVEfPMsq3PFz60EjAqlj6lgp3EVWqLrWy6OBe WiW9f/8Pnw5CM1/9hzqJkhH3soDO78G0lRxuK55fsTtek0e5a+LcPgQOzlrxq6l02L+W ssSLW7S25EeJgxZoRznQQn9QTi4uPqaaBVaMqZr/v731s5USYIeq9SqTWmhRzcNnut0z O7UA== X-Gm-Message-State: AIVw111r1wpMVXk3LvYNBjO8aXZN/I3npkttlbYzrhOV6qjvmyqrrE/G JpdrPNU0Ph6L7rYpFxm0/ho1l35ARw== X-Received: by 10.237.41.230 with SMTP id o93mr32771174qtd.27.1501668708322; Wed, 02 Aug 2017 03:11:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.148.188 with HTTP; Wed, 2 Aug 2017 03:11:47 -0700 (PDT) In-Reply-To: <1411c20e-fff4-cef4-9e15-460eebc14dab@siemens.com> References: <45a900737baed2ceb30b5eef22eb5a53f64ae020.1501582237.git.henning.schild@siemens.com> <85893014-c2cf-9bde-abf4-ddecf5c2682b@siemens.com> <1411c20e-fff4-cef4-9e15-460eebc14dab@siemens.com> From: Alexander Smirnov Date: Wed, 2 Aug 2017 13:11:47 +0300 Message-ID: Subject: Re: [PATCH 15/16] meta: add dpkg-bin class To: Claudius Heine Cc: "[ext] Henning Schild" , isar-users@googlegroups.com, "Dr . Johann Pfefferl" Content-Type: multipart/alternative; boundary="94eb2c124b8aee14c40555c27da3" X-TUID: 0b5+tokIH++8 --94eb2c124b8aee14c40555c27da3 Content-Type: text/plain; charset="UTF-8" Hi colleagues, from the patch description it's not clear what this patch stays for, seems that I'm out of you communcation loop. Could you please annotate the patches with more detailed description, at least with the following information: - Change proposal - Why this change is needed. It's not about arguments to push your change, it's more about your ideas and motivation. That's the most imporant information which is missed. - Change impact to Isar, who will be affected 2017-08-01 18:10 GMT+03:00 Claudius Heine : > > > On 08/01/2017 04:25 PM, [ext] Claudius Heine wrote: > >> >> >> On 08/01/2017 12:17 PM, [ext] Henning Schild wrote: >> >>> Signed-off-by: Henning Schild >>> --- >>> meta/classes/dpkg-bin.bbclass | 47 ++++++++++++++++++++++++++++++ >>> +++++++++++++ >>> 1 file changed, 47 insertions(+) >>> create mode 100644 meta/classes/dpkg-bin.bbclass >>> >>> diff --git a/meta/classes/dpkg-bin.bbclass >>> b/meta/classes/dpkg-bin.bbclass >>> new file mode 100644 >>> index 0000000..1e96bd1 >>> --- /dev/null >>> +++ b/meta/classes/dpkg-bin.bbclass >>> @@ -0,0 +1,47 @@ >>> +inherit isar-base >>> + >>> +DEBIAN_DEPENDS ?= "" >>> +DEBIAN_MAINTAINER ?= "FIXME Unknown maintainer" >>> + >>> +D = "${WORKDIR}/image/" >>> + >>> +# Populate folder that will be picked up as package >>> +do_install() { >>> + bbnote "Put your files for this package in ${D}" >>> +} >>> + >>> +addtask install after do_unpack before do_deb_package_prepare >>> +# so we can put hooks in there already >>> +do_install[dirs] = "${D}/DEBIAN" >>> + >>> +do_deb_package_prepare() { >>> + cat<<-__EOF__ > ${D}/DEBIAN/control >>> + Package: ${PN} >>> + Architecture: `dpkg --print-architecture` >>> + Section: misc >>> + Priority: optional >>> + Maintainer: ${DEBIAN_MAINTAINER} >>> + Depends: `echo ${DEBIAN_DEPENDS} | tr '[:blank:]' ','` >>> + Version: ${PV}+isar >>> + Description: ${DESCRIPTION} >>> + __EOF__ >>> + CONFFILES=${D}/DEBIAN/conffiles >>> + find ${D} -path '*/etc/*' | sed -e 's|^${D}||' > $CONFFILES >>> >> >> I package a container root file system and now the files in the etc >> directory of this rfs is mentioned in the conffiles file. >> > > It also adds directories into the conffiles file. dpkg does not like this. > > >> Maybe add an option to disable this here? >> >> + test -s $CONFFILES || rm $CONFFILES >>> + for t in pre post >>> + do >>> + for a in inst rm >>> + do >>> + chmod -f +x ${D}/DEBIAN/${t}${a} || true >>> + done >>> + done >>> +} >>> + >>> +addtask deb_package_prepare after do_install before do_install_package >>> + >>> +do_deb_package() { >>> + sudo chown -R root:root ${D}/DEBIAN/ >>> + sudo dpkg-deb --build ${D} ${WORKDIR} >>> +} >>> + >>> +addtask deb_package after do_deb_package_prepare before >>> do_install_package >>> >>> >> > -- > You received this message because you are subscribed to the Google Groups > "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to isar-users+unsubscribe@googlegroups.com. > To post to this group, send email to isar-users@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/ms > gid/isar-users/1411c20e-fff4-cef4-9e15-460eebc14dab%40siemens.com. > > For more options, visit https://groups.google.com/d/optout. > --94eb2c124b8aee14c40555c27da3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi colleagues,

from the patch descripti= on it's not clear what this patch stays for, seems that I'm out of = you communcation loop. Could you please annotate the patches with more deta= iled description, at least with the following information:
=C2=A0= - Change proposal
=C2=A0- Why this change is needed. It's not= about arguments to push your change, it's more about your ideas and mo= tivation. That's the most imporant information which is missed.
=C2=A0- Change impact to Isar, who will be affected

2017-08-01 18:10 GMT+03:00= Claudius Heine <claudius.heine.ext@siemens.com>:


On 08/01/2017 04:25 PM, [ext] Claudius Heine wrote:


On 08/01/2017 12:17 PM, [ext] Henning Schild wrote:
Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
=C2=A0 meta/classes/dpkg-bin.bbclass | 47 +++++++++++++++++++++++++++++++++++++++++++
=C2=A0 1 file changed, 47 insertions(+)
=C2=A0 create mode 100644 meta/classes/dpkg-bin.bbclass

diff --git a/meta/classes/dpkg-bin.bbclass b/meta/classes/dpkg-bin.bbc= lass
new file mode 100644
index 0000000..1e96bd1
--- /dev/null
+++ b/meta/classes/dpkg-bin.bbclass
@@ -0,0 +1,47 @@
+inherit isar-base
+
+DEBIAN_DEPENDS ?=3D ""
+DEBIAN_MAINTAINER ?=3D "FIXME Unknown maintainer"
+
+D =3D "${WORKDIR}/image/"
+
+# Populate folder that will be picked up as package
+do_install() {
+=C2=A0 =C2=A0 bbnote "Put your files for this package in ${D}" +}
+
+addtask install after do_unpack before do_deb_package_prepare
+# so we can put hooks in there already
+do_install[dirs] =3D "${D}/DEBIAN"
+
+do_deb_package_prepare() {
+=C2=A0 =C2=A0 cat<<-__EOF__ > ${D}/DEBIAN/control
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Package: ${PN}
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Architecture: `dpkg --print-architecture`
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Section: misc
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Priority: optional
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Maintainer: ${DEBIAN_MAINTAINER}
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Depends: `echo ${DEBIAN_DEPENDS} | tr '[:b= lank:]' ','`
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Version: ${PV}+isar
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Description: ${DESCRIPTION}
+=C2=A0 =C2=A0 __EOF__
+=C2=A0 =C2=A0 CONFFILES=3D${D}/DEBIAN/conffiles
+=C2=A0 =C2=A0 find ${D} -path '*/etc/*' | sed -e 's|^${D}||= 9; > $CONFFILES

I package a container root file system and now the files in the etc directo= ry of this rfs is mentioned in the conffiles file.

It also adds directories into the conffiles file. dpkg does not like this.<= span class=3D"">


Maybe add an option to disable this here?

+=C2=A0 =C2=A0 test -s $CONFFILES || rm $CONFFILES
+=C2=A0 =C2=A0 for t in pre post
+=C2=A0 =C2=A0 do
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 for a in inst rm
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 do
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 chmod -f +x ${D}/DEBIAN/${t}${a}= || true
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 done
+=C2=A0 =C2=A0 done
+}
+
+addtask deb_package_prepare after do_install before do_install_package
+
+do_deb_package() {
+=C2=A0 =C2=A0 sudo chown -R root:root ${D}/DEBIAN/
+=C2=A0 =C2=A0 sudo dpkg-deb --build ${D} ${WORKDIR}
+}
+
+addtask deb_package after do_deb_package_prepare before do_install_package=



--
You received this message because you are subscribed to the Google Groups &= quot;isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com.
To post to this group, send email to isar-users@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/= isar-users/1411c20e-fff4-cef4-9e15-460eebc14dab%40siemens.com= .

For more options, visit https://groups.google.com/d/optout.

--94eb2c124b8aee14c40555c27da3--