Re: [PATCH 11/16] meta: classes: make do_build always the end of the task-chain

[Alexander Smirnov <alex.bluesman.smirnov@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2474 bytes --]

2017-08-01 13:17 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> build is bitbakes default target and queing tasks behind it is asking
> for trouble
>

Could you please specify more details about this.


> Introduce do_compile where we "build" the debian packages.
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/classes/dpkg.bbclass  | 8 ++++----
>  meta/classes/image.bbclass | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index 4228b0d..71c7122 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -13,19 +13,19 @@ PP = "/home/builder/${PN}"
>  WORKDIR = "${BUILDCHROOT_DIR}/${PP}"
>  S ?= "${WORKDIR}"
>
> -do_build[stamp-extra-info] = "${DISTRO}"
> -
>  # Build package from sources using build script
> -do_build() {
> +do_compile() {
>      sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR}
>  }
>
>
Probably it makes sense to use more evident task name like
do_dpkg-buildpackage or short version - do_buildpackage.
'dpkg-buildpackage' is exactly what is executed in this task, it's not only
about compiling.


> +addtask compile after do_unpack before do_install
> +do_compile[stamp-extra-info] = "${DISTRO}"
>
>  # Install package to dedicated deploy directory
>  do_install() {
>      install -m 755 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/
>  }
>
> -addtask install after do_build
> +addtask install after do_compile before do_build
>  do_install[dirs] = "${DEPLOY_DIR_DEB}"
>  do_install[stamp-extra-info] = "${MACHINE}"
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 3e4877c..8db3352 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -27,4 +27,4 @@ do_populate() {
>  }
>
>  addtask populate before do_build
> -do_populate[deptask] = "do_install"
> +do_populate[deptask] = "do_build"
> --
> 2.13.0
>
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to isar-users+unsubscribe@googlegroups.com.
> To post to this group, send email to isar-users@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/isar-users/32e4ef6d06af30a76fdb645a4108f817301d3007.1501582237.git.
> henning.schild%40siemens.com.
> For more options, visit https://groups.google.com/d/optout.
>

[-- Attachment #2: Type: text/html, Size: 3900 bytes --]