From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247988281769984 X-Received: by 10.101.85.195 with SMTP id k3mr16818069pgs.202.1501667687381; Wed, 02 Aug 2017 02:54:47 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.36.23.207 with SMTP id 198ls2887502ith.18.gmail; Wed, 02 Aug 2017 02:54:47 -0700 (PDT) X-Received: by 10.107.178.196 with SMTP id b187mr16518266iof.65.1501667687075; Wed, 02 Aug 2017 02:54:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501667687; cv=none; d=google.com; s=arc-20160816; b=L8IYWf0FE5HBdqyPYTlMhEchaO/0nq2bkDVcZA2DXw3f875ScwZ/hBI6KIBr5U3a0L PablFhUiHdquA8kn0DDw11e6VjoMU5PnDcM8Btrpbo2gHVTfBH3o/Me4lma101MF6zWp JbvTwgEi975334F7QqGuwYqIagG7zccyPJhEMyw72FpQIBqOTXraCmhBDHAqHhzcOOgx glcR5Plahbi16cyIlFSSebHljDuC9zQDRNLxjR0OwrR+AlrFm9dS0A5L6+Z/gymKXpWQ dXumqHwIixASKQRtSPoHQaJHemabf76PZNAC/GYvaQZMETUQtKvM+2wA8ENWqAkTiHGT Zfww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:arc-authentication-results; bh=Wxpj0ZixmHgeSEKWwjsdc8v3gpRIzDjGf0lYDiR5KiU=; b=BEhrzqRdTlQx6f9pjKG0cqCabhGoEJ2de37BSGu5+L9/bnyWGT3TNzrImoInZXmhmu xHYHsPTf5datadxT/Z7TuYo45z4d0p0jZsxmrqlsEp9Re6PdZ8gxc9zp0iRnba3wy3M9 vuE0teP/aGk+s0zTCHxUCXNq1IVcM+xoxJQP3eP0MheHOCbI2b8Q3N1yQHXbOAdZr71d t+2dcvFOOt/rHXm0vv2pkzH+bHprdUK62E34U6DOhSiDLgnklsoeOU1zlaHi2t9Ziisv 2M8ki2Y3FE1w4v1c6Pyv3EOpOetznvhH9I9Yo/za9VKC2PsUvQp92zjiLOc8n/GpIAnV qxtg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.b=XgfK3yXc; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::243 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qt0-x243.google.com (mail-qt0-x243.google.com. [2607:f8b0:400d:c0d::243]) by gmr-mx.google.com with ESMTPS id o189si1516849ywc.15.2017.08.02.02.54.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Aug 2017 02:54:47 -0700 (PDT) Received-SPF: pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::243 as permitted sender) client-ip=2607:f8b0:400d:c0d::243; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.b=XgfK3yXc; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::243 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: by mail-qt0-x243.google.com with SMTP id t37so4059777qtg.2 for ; Wed, 02 Aug 2017 02:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Wxpj0ZixmHgeSEKWwjsdc8v3gpRIzDjGf0lYDiR5KiU=; b=XgfK3yXcfqlMNatrkeZCoueyQ9THOYJPyFf4WtwHfW9Lb8yQluARG2WZeur/9Q23Nh hNypwZ1ki7YhTSVPfxdvudSMqchTFmaqiVwR6rSSpVoWZtNVCDOWXFAeRkgLokLyPos6 tIr7e6I5Kc2861xdCr4I/teY0OWsRpbk3Ep4S5+aT549/cAAlTm4C+vp2S1Nl5IcO9yR /pJuTx0CYUKja3P8ZpYI/Oy2m6kOkyGuHkVuB1n1FXgFUR9JTz3OFaHXrEEtawdZfjiT 2vPcHdlDRETdNw8BytWBuzgQrjP4OnFGA5RaGYKRLxksnXS7HjT3bZFMthSyl3J/+UVs nfFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Wxpj0ZixmHgeSEKWwjsdc8v3gpRIzDjGf0lYDiR5KiU=; b=pEtKMwst9g/oBkmWrq3M9PD+7du+p+hPwDm8NzX26l3LpeYJudJ0dQHu4XObF0jSiE Ro20DaHrDWyZZrNdKb7Rn4ijW7H8mBB2MNUhR72gCbrhXv75SwT42WRmDuHxZZ5NFR9b E7BqTeRt+aI9G2LG2uSFWUSzjRjtRtLNXCAWQ4mG84bxzVCOStxCL0Io940yy5eBKnI8 kJI1k7NMaPWOv7eCVfLzqCeAqT8ryxyK7FlWhJ4HzdduB3qJVARRmGTw9vzCXHlS+4W+ ygbpUoHj0zT4OqZHx1t0IzOVMN8yPzTTH2PHwdbTBemT7XRXn6g6L0fNDOf1wJbd0Y1s M+Rg== X-Gm-Message-State: AIVw111lqoVuZyljH7XnsVEJ1X57VHocmsZIfym9l0n+pqdxxUo+6qWs 2IGRWhUjlN57riO0w0xIILPDaAm/dQ== X-Received: by 10.200.45.240 with SMTP id q45mr32629867qta.332.1501667686806; Wed, 02 Aug 2017 02:54:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.148.188 with HTTP; Wed, 2 Aug 2017 02:54:46 -0700 (PDT) In-Reply-To: <32e4ef6d06af30a76fdb645a4108f817301d3007.1501582237.git.henning.schild@siemens.com> References: <32e4ef6d06af30a76fdb645a4108f817301d3007.1501582237.git.henning.schild@siemens.com> From: Alexander Smirnov Date: Wed, 2 Aug 2017 12:54:46 +0300 Message-ID: Subject: Re: [PATCH 11/16] meta: classes: make do_build always the end of the task-chain To: Henning Schild Cc: isar-users@googlegroups.com Content-Type: multipart/alternative; boundary="001a113a81f00afa0b0555c2412f" X-TUID: vSaOBuE0JjaS --001a113a81f00afa0b0555c2412f Content-Type: text/plain; charset="UTF-8" 2017-08-01 13:17 GMT+03:00 Henning Schild : > build is bitbakes default target and queing tasks behind it is asking > for trouble > Could you please specify more details about this. > Introduce do_compile where we "build" the debian packages. > > Signed-off-by: Henning Schild > --- > meta/classes/dpkg.bbclass | 8 ++++---- > meta/classes/image.bbclass | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index 4228b0d..71c7122 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -13,19 +13,19 @@ PP = "/home/builder/${PN}" > WORKDIR = "${BUILDCHROOT_DIR}/${PP}" > S ?= "${WORKDIR}" > > -do_build[stamp-extra-info] = "${DISTRO}" > - > # Build package from sources using build script > -do_build() { > +do_compile() { > sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR} > } > > Probably it makes sense to use more evident task name like do_dpkg-buildpackage or short version - do_buildpackage. 'dpkg-buildpackage' is exactly what is executed in this task, it's not only about compiling. > +addtask compile after do_unpack before do_install > +do_compile[stamp-extra-info] = "${DISTRO}" > > # Install package to dedicated deploy directory > do_install() { > install -m 755 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/ > } > > -addtask install after do_build > +addtask install after do_compile before do_build > do_install[dirs] = "${DEPLOY_DIR_DEB}" > do_install[stamp-extra-info] = "${MACHINE}" > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 3e4877c..8db3352 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -27,4 +27,4 @@ do_populate() { > } > > addtask populate before do_build > -do_populate[deptask] = "do_install" > +do_populate[deptask] = "do_build" > -- > 2.13.0 > > -- > You received this message because you are subscribed to the Google Groups > "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to isar-users+unsubscribe@googlegroups.com. > To post to this group, send email to isar-users@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/isar-users/32e4ef6d06af30a76fdb645a4108f817301d3007.1501582237.git. > henning.schild%40siemens.com. > For more options, visit https://groups.google.com/d/optout. > --001a113a81f00afa0b0555c2412f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


2017-08-01 13:17 GMT+03:00 Henning Schild <henning.schild@sie= mens.com>:
build is bitbake= s default target and queing tasks behind it is asking
for trouble

Could you please specify mo= re details about this.
=C2=A0
Introduce do_compile where we "build" the debian packages.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
=C2=A0meta/classes/dpkg.bbclass=C2=A0 | 8 ++++----
=C2=A0meta/classes/image.bbclass | 2 +-
=C2=A02 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index 4228b0d..71c7122 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -13,19 +13,19 @@ PP =3D "/home/builder/${PN}"
=C2=A0WORKDIR =3D "${BUILDCHROOT_DIR}/${PP}"
=C2=A0S ?=3D "${WORKDIR}"

-do_build[stamp-extra-info] =3D "${DISTRO}"
-
=C2=A0# Build package from sources using build script
-do_build() {
+do_compile() {
=C2=A0 =C2=A0 =C2=A0sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DI= R}
=C2=A0}


Probably it makes sense to use more ev= ident task name like do_dpkg-buildpackage or short version - do_buildpackag= e. 'dpkg-buildpackage' is exactly what is executed in this task, it= 's not only about compiling.
=C2=A0
+addtask compile after do_unpack before do_install
+do_compile[stamp-extra-info] =3D "${DISTRO}"

=C2=A0# Install package to dedicated deploy directory
=C2=A0do_install() {
=C2=A0 =C2=A0 =C2=A0install -m 755 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/
=C2=A0}

-addtask install after do_build
+addtask install after do_compile before do_build
=C2=A0do_install[dirs] =3D "${DEPLOY_DIR_DEB}"
=C2=A0do_install[stamp-extra-info] =3D "${MACHINE}"
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 3e4877c..8db3352 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -27,4 +27,4 @@ do_populate() {
=C2=A0}

=C2=A0addtask populate before do_build
-do_populate[deptask] =3D "do_install"
+do_populate[deptask] =3D "do_build"
--
2.13.0

--
You received this message because you are subscribed to the Google Groups &= quot;isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-u= sers+unsubscribe@googlegroups.com.
To post to this group, send email to isar-users@googlegroups.com.
To view this discussion on the web visit https= ://groups.google.com/d/msgid/isar-users/32e4ef6d06af30a76fdb645a4= 108f817301d3007.1501582237.git.henning.schild%40siemens.com.<= br> For more options, visit https://groups.google.com/d/optout.

--001a113a81f00afa0b0555c2412f--