2017-08-08 11:45 GMT+03:00 Henning Schild : > Am Mon, 7 Aug 2017 22:44:15 +0300 > schrieb Alexander Smirnov : > > > Hi, > > > > 2017-08-03 14:55 GMT+03:00 Henning Schild > > : > > > > > Since the first q was pretty long with 16 patches and some of the > > > later ones > > > still need to be dicsussed in more detail, i decided to split the q > > > and send > > > the less controversial stuff first. > > > > > > Changes to V1: > > > > > > - dropped 01/16 from v1 > > > - ext4 is not on the wic path, it can keep its obvious bugs > > > - 02/16 is 1v2, added copyright header > > > - 03/16 is 2v2, keep it seperate after all (logical vs. structural) > > > - 04/16 is 3v2, do not touch bitbake anymore > > > - 05/16 is 4v2, do not introduce CROSSBUILDCHROOT_DIR, add license > > > header > > > - 06/16 is 5v2, keep it seperate after all (logical vs. structural) > > > - 07/16 dropped > > > - 08/16 is 6v2, no image-class anymore, update comment > > > - 09/16 is 7v2, nothing changed > > > - 10/16 is 8v2, updated comment > > > > > > > > I have new comments regarding v2 series. But to somehow move the work > > forward, I've partially applied your patches to asmirnov/next branch. > > Huge series are very hard to review and apply at once, so I'd propose > > to send them in small parts. > > I know, that is why i split it. Thanks for taking some of the commits > in. Will you send your patches for review as well? > You are welcome! Regarding my patches - sure, I'll send it for review. The main technical payload of my patches - to have possibility to start parallel builds in one command: $ bitbake multiconfig:qemuarm-wheezy:isar-image-base multiconfig:qemuarm-jessie:isar-image-base multiconfig:qemuarm-stretch:isar-image-base multiconfig:qemui386-jessie:isar-image-base multiconfig:qemui386-stretch:isar-image-base multiconfig:qemuamd64-jessie:isar-image-base multiconfig:qemuamd64-stretch:isar-image-base multiconfig:rpi-jessie:isar-image-base So this command builds all the possible Isar configurations. I use it in our jenkins to ensure that upcomming patches do not break the build. Alex > > > > > > > > Henning Schild (8): > > > meta: classes: use base.bbclass from bitbake > > > meta: isar-base: remove unused function > > > remove redundant variable THISDIR > > > meta: conf: use bitbake.conf from bitbake and apply local changes > > > meta: conf: clean up local bitbake config > > > classes: move fetch and unpack into isar-base > > > meta: dpdk use [dirs] directive instead of mkdir > > > meta: dpkg: reorder and rename do_install to install in addtask > > > > > > meta-isar/recipes-core/images/isar-image-base.bb | 8 +-- > > > meta/classes/base.bbclass | 81 > > > +----------------------- > > > meta/classes/dpkg.bbclass | 46 > > > ++------------ meta/classes/ext4-img.bbclass | > > > 2 + meta/classes/isar-base.bbclass | 55 > > > ++++++++++++++++ meta/conf/bitbake.conf.sample | > > > 68 -------------------- > > > meta/conf/isar-bitbake.conf | 31 +++++++++ > > > meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +-- > > > scripts/isar-setup-builddir | 33 ++++++++-- 9 > > > files changed, 134 insertions(+), 200 deletions(-) mode change > > > 100644 => 120000 meta/classes/base.bbclass create mode 100644 > > > meta/classes/isar-base.bbclass delete mode 100644 > > > meta/conf/bitbake.conf.sample create mode 100644 > > > meta/conf/isar-bitbake.conf > > > > > > -- > > > 2.13.0 > > > > > > > >