From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6450015460633083904 X-Received: by 10.176.82.49 with SMTP id i46mr2186784uaa.16.1502185394021; Tue, 08 Aug 2017 02:43:14 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.107.56.87 with SMTP id f84ls2653082ioa.45.gmail; Tue, 08 Aug 2017 02:43:13 -0700 (PDT) X-Received: by 10.36.80.74 with SMTP id m71mr294997itb.24.1502185393792; Tue, 08 Aug 2017 02:43:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502185393; cv=none; d=google.com; s=arc-20160816; b=akHvBpFPaK63N5eLcsurfE1AXwp5rsGMYvPZjKXE9Af84n2QjVPVbBQ3bMOMlxkDM2 qw7NeYLMOzfkB+lvQIMNhgvPBTNhx1RCahUbdSIGFtcRtj0YtQip6ppL1oLWhD7QOBx3 YCkCi13TGxQE0BLtFLJcE3IiSVSOxnHcPBlIslOCtdwN1NU0rl0N9KCKZpMRdjiGuI/5 /kpeD6R/1ShSTolgEbbEkrH+PYTdesA438x49VxE9UhOg/4kOhRpZO8/hsm4zNcPx5Tt varjSbZ0joI7ZjwhT5qRDrA2Lyeo5XZg5pENnIJ6PD+nChTwOTZJjgyFtotlLtusIgvD r1zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:arc-authentication-results; bh=t830WOZM5H8oCexF31qqDIeVDaJ5YBAlMe4jTrTNx2M=; b=Y/kKGhw41P686U5vsuf3wo35KFXbUHGH7m8xKPTerfETjl6ag1HbCZqokmeZIiiULw xdiGt5c1lFcWJEbI5LsCLkVqDX2/454Om+xb8Q/vQjI+BVIV32Q+oux+OH0lnf3Y4VLG 9V4QAGl2dA/lvsBkNKm8OUjBJ20W66dQaDcdwRkITPD4d9YAdYPuofmHwu9F9jMiDG8r t91YnWSiZc94+30M8DlHw++qPYNANRMa4ZMNjENIFEIBwEP+RnQZRyyjwNp6iCDcA5+r xcR1KR6YBp7Xo32aMhIoxr9Y9aAiiTMzyfpZeM6/8Q/zV5ZKYrrsUoskOR0kQKKymEZd G0wg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fHgEfnXd; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::233 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qt0-x233.google.com (mail-qt0-x233.google.com. [2607:f8b0:400d:c0d::233]) by gmr-mx.google.com with ESMTPS id x136si48064ywx.6.2017.08.08.02.43.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 02:43:13 -0700 (PDT) Received-SPF: pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::233 as permitted sender) client-ip=2607:f8b0:400d:c0d::233; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fHgEfnXd; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::233 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: by mail-qt0-x233.google.com with SMTP id a18so16873705qta.0 for ; Tue, 08 Aug 2017 02:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=t830WOZM5H8oCexF31qqDIeVDaJ5YBAlMe4jTrTNx2M=; b=fHgEfnXd3JyEvukkIhM6MxuqN8GKsQeuTyueMSDMsavd5MXaJ+1USOVqjQ5HiPU4ky x2W5GXGPahUKP0Bd4SAsDzSilSLcEzbeTQ6ZENNuung2KjkqPWgFO8AOk0aXFi+ID8ZZ V2fKzuUdGjZbn7FEPoMFdtwhuVp1sP5X71+SKE+93jCeor40mal8grOomJ49x491dHsM u0pupS/pvHszkuDkcgIWKZWKFOIXZ/2K2imQ7jx5gHw6SFGIOp0bRTlHT9+eCv5+wsVZ TZxMgWbaWDFVcoamWtgiSEgqqvm9jKAm/TOEgm5/asrE8XaB2sOpqMxwCOY7ZhVUnJ7e q8GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=t830WOZM5H8oCexF31qqDIeVDaJ5YBAlMe4jTrTNx2M=; b=dXI2RetX9h3+m1t3xvmOCMWTeabKPzNYXBqaUM7A+ovL1GjkzHLQKFOGs3SQeTFnYT 8JZbJFqi8/8RC2+KnctrlVCo1cZzR1yC1i3VrBEJcMQcHfNZNtKyuaetpniHmp7beSdi +1BibQIpSJ9EkbsnG+2SYxulzY4RJqElXxAGNv860SDGgzQCeDk1CSkKTJUav/COfK0C ePhwgek730ZlTrO/W1bJYG2+6EtHDqOSUJazy3aJE4Tt6a/9aytsrmIwAaeIQ2NwK7Fs Z6HIEHpJiyCGxXsUro5EEJVYKY+TjNRq8L5A4g4vI0L+BJ73uW9+he2dZBrN8wTlwUBz SfbQ== X-Gm-Message-State: AHYfb5hxHXHkxXFEebzRLoyUiV+ND3oUYn819kp7dAt2tPMKNEu4QAzB Bx+/PXTWjMR2BknlV88e4VgS5ahA2sfG X-Received: by 10.237.58.170 with SMTP id o39mr4679552qte.301.1502185393482; Tue, 08 Aug 2017 02:43:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.148.188 with HTTP; Tue, 8 Aug 2017 02:43:13 -0700 (PDT) In-Reply-To: <20170808104503.43ba6a3f@md1em3qc> References: <20170808104503.43ba6a3f@md1em3qc> From: Alexander Smirnov Date: Tue, 8 Aug 2017 12:43:13 +0300 Message-ID: Subject: Re: [PATCH 0-10 of 16 v2 0/8] splitting the previous q To: Henning Schild Cc: isar-users@googlegroups.com Content-Type: multipart/alternative; boundary="001a11404ac0c3f06e05563acaee" X-TUID: abS3WWrDxyFW --001a11404ac0c3f06e05563acaee Content-Type: text/plain; charset="UTF-8" 2017-08-08 11:45 GMT+03:00 Henning Schild : > Am Mon, 7 Aug 2017 22:44:15 +0300 > schrieb Alexander Smirnov : > > > Hi, > > > > 2017-08-03 14:55 GMT+03:00 Henning Schild > > : > > > > > Since the first q was pretty long with 16 patches and some of the > > > later ones > > > still need to be dicsussed in more detail, i decided to split the q > > > and send > > > the less controversial stuff first. > > > > > > Changes to V1: > > > > > > - dropped 01/16 from v1 > > > - ext4 is not on the wic path, it can keep its obvious bugs > > > - 02/16 is 1v2, added copyright header > > > - 03/16 is 2v2, keep it seperate after all (logical vs. structural) > > > - 04/16 is 3v2, do not touch bitbake anymore > > > - 05/16 is 4v2, do not introduce CROSSBUILDCHROOT_DIR, add license > > > header > > > - 06/16 is 5v2, keep it seperate after all (logical vs. structural) > > > - 07/16 dropped > > > - 08/16 is 6v2, no image-class anymore, update comment > > > - 09/16 is 7v2, nothing changed > > > - 10/16 is 8v2, updated comment > > > > > > > > I have new comments regarding v2 series. But to somehow move the work > > forward, I've partially applied your patches to asmirnov/next branch. > > Huge series are very hard to review and apply at once, so I'd propose > > to send them in small parts. > > I know, that is why i split it. Thanks for taking some of the commits > in. Will you send your patches for review as well? > You are welcome! Regarding my patches - sure, I'll send it for review. The main technical payload of my patches - to have possibility to start parallel builds in one command: $ bitbake multiconfig:qemuarm-wheezy:isar-image-base multiconfig:qemuarm-jessie:isar-image-base multiconfig:qemuarm-stretch:isar-image-base multiconfig:qemui386-jessie:isar-image-base multiconfig:qemui386-stretch:isar-image-base multiconfig:qemuamd64-jessie:isar-image-base multiconfig:qemuamd64-stretch:isar-image-base multiconfig:rpi-jessie:isar-image-base So this command builds all the possible Isar configurations. I use it in our jenkins to ensure that upcomming patches do not break the build. Alex > > > > > > > > Henning Schild (8): > > > meta: classes: use base.bbclass from bitbake > > > meta: isar-base: remove unused function > > > remove redundant variable THISDIR > > > meta: conf: use bitbake.conf from bitbake and apply local changes > > > meta: conf: clean up local bitbake config > > > classes: move fetch and unpack into isar-base > > > meta: dpdk use [dirs] directive instead of mkdir > > > meta: dpkg: reorder and rename do_install to install in addtask > > > > > > meta-isar/recipes-core/images/isar-image-base.bb | 8 +-- > > > meta/classes/base.bbclass | 81 > > > +----------------------- > > > meta/classes/dpkg.bbclass | 46 > > > ++------------ meta/classes/ext4-img.bbclass | > > > 2 + meta/classes/isar-base.bbclass | 55 > > > ++++++++++++++++ meta/conf/bitbake.conf.sample | > > > 68 -------------------- > > > meta/conf/isar-bitbake.conf | 31 +++++++++ > > > meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +-- > > > scripts/isar-setup-builddir | 33 ++++++++-- 9 > > > files changed, 134 insertions(+), 200 deletions(-) mode change > > > 100644 => 120000 meta/classes/base.bbclass create mode 100644 > > > meta/classes/isar-base.bbclass delete mode 100644 > > > meta/conf/bitbake.conf.sample create mode 100644 > > > meta/conf/isar-bitbake.conf > > > > > > -- > > > 2.13.0 > > > > > > > > --001a11404ac0c3f06e05563acaee Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


2017-08-08 11:45 GMT+03:00 Henning Schild <henning.schild@sie= mens.com>:
Am Mon, 7 Aug 2017 22:44:15 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> Hi,
>
> 2017-08-03 14:55 GMT+03:00 Henning Schild
> <henning.schild@sieme= ns.com>:
>
> > Since the first q was pretty long with 16 patches and some of the=
> > later ones
> > still need to be dicsussed in more detail, i decided to split the= q
> > and send
> > the less controversial stuff first.
> >
> > Changes to V1:
> >
> > - dropped 01/16 from v1
> >=C2=A0 =C2=A0- ext4 is not on the wic path, it can keep its obviou= s bugs
> > - 02/16 is 1v2, added copyright header
> > - 03/16 is 2v2, keep it seperate after all (logical vs. structura= l)
> > - 04/16 is 3v2, do not touch bitbake anymore
> > - 05/16 is 4v2, do not introduce CROSSBUILDCHROOT_DIR, add licens= e
> > header
> > - 06/16 is 5v2, keep it seperate after all (logical vs. structura= l)
> > - 07/16 dropped
> > - 08/16 is 6v2, no image-class anymore, update comment
> > - 09/16 is 7v2, nothing changed
> > - 10/16 is 8v2, updated comment
> >
> >
> I have new comments regarding v2 series. But to somehow move the work<= br> > forward, I've partially applied your patches to asmirnov/next bran= ch.
> Huge series are very hard to review and apply at once, so I'd prop= ose
> to send them in small parts.

I know, that is why i split it. Thanks for taking some of the c= ommits
in. Will you send your patches for review as well?
You are welcome!

Regarding my patches = - sure, I'll send it for review. The main technical payload of my patch= es - to have possibility to start parallel builds in one command:

$=C2=A0bitbake multiconfig:qemuarm-wheezy:isar-image-base m= ulticonfig:qemuarm-jessie:isar-image-base multiconfig:qemuarm-stretch:isar-= image-base multiconfig:qemui386-jessie:isar-image-base multiconfig:qemui386= -stretch:isar-image-base multiconfig:qemuamd64-jessie:isar-image-base multi= config:qemuamd64-stretch:isar-image-base multiconfig:rpi-jessie:isar-image-= base

So this command builds all the possible Isar = configurations. I use it in our jenkins to ensure that upcomming patches do= not break the build.

Alex
=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
>
> >
> > Henning Schild (8):
> >=C2=A0 =C2=A0meta: classes: use base.bbclass from bitbake
> >=C2=A0 =C2=A0meta: isar-base: remove unused function
> >=C2=A0 =C2=A0remove redundant variable THISDIR
> >=C2=A0 =C2=A0meta: conf: use bitbake.conf from bitbake and apply l= ocal changes
> >=C2=A0 =C2=A0meta: conf: clean up local bitbake config
> >=C2=A0 =C2=A0classes: move fetch and unpack into isar-base
> >=C2=A0 =C2=A0meta: dpdk use [dirs] directive instead of mkdir
> >=C2=A0 =C2=A0meta: dpkg: reorder and rename do_install to install = in addtask
> >
> >=C2=A0 meta-isar/recipes-core/images/isar-image-base.bb |= =C2=A0 8 +--
> >=C2=A0 meta/classes/base.bbclass=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 81
> > +-----------------------
> >=C2=A0 meta/classes/dpkg.bbclass=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 46
> > ++------------ meta/classes/ext4-img.bbclass=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |
> > 2 + meta/classes/isar-base.bbclass=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 55
> > ++++++++++++++++ meta/conf/bitbake.conf.sample=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |
> > 68 --------------------
> > meta/conf/isar-bitbake.conf=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 31 +++++++++
> > meta/recipes-devtools/buildchroot/buildchroot.bb | 10 +-- > > scripts/isar-setup-builddir=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 33 ++++++++-- 9
> > files changed, 134 insertions(+), 200 deletions(-) mode change > > 100644 =3D> 120000 meta/classes/base.bbclass create mode 10064= 4
> > meta/classes/isar-base.bbclass delete mode 100644
> > meta/conf/bitbake.conf.sample create mode 100644
> > meta/conf/isar-bitbake.conf
> >
> > --
> > 2.13.0
> >
> >


--001a11404ac0c3f06e05563acaee--