From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247988281769984 X-Received: by 10.107.134.87 with SMTP id i84mr16081845iod.138.1501667962282; Wed, 02 Aug 2017 02:59:22 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.107.28.12 with SMTP id c12ls12535836ioc.52.gmail; Wed, 02 Aug 2017 02:59:22 -0700 (PDT) X-Received: by 10.176.23.46 with SMTP id j46mr15221550uaf.58.1501667962025; Wed, 02 Aug 2017 02:59:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501667961; cv=none; d=google.com; s=arc-20160816; b=GiG/klpBVNQOrCBaM9DH8Y0rQ/QgqS8zN47r1zMUefKqCHh5nz+MNP78P3lXls5ss+ CJB3+bui1ZItMZJBVq5E2b7Tm2GaFXNlWqomJHTsbqLeSvMOySYrl9dp76nzlXDWoOqT FRXkMRiJZ0UZhUyyzYLicKDdal4cjxrzMq0pYe01e1iCRsjyTGe53bHNFKKFz1h4nJzg jBJK97TkmSP62hnFsuq2GQ0Mj8g/2r8prgBzxVJQgamsZJHdC40MvOmW5jUJ7bTRwiAF uLDp1eSU0ssaoTblhkC4/BJe+PG8K8ItIyhMfdyDGM19l9jd5ncgRfvR+CCCVXIcd8+r AqNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:arc-authentication-results; bh=mowcW/52hc43SO6ItlFl4DITxnA/zKj2gyxWziirWwo=; b=fbkfFS/BS1T+EGOd+Ph8sdyBg9CnaiKONMr32WwNA86vS+lrJsl/qNE5za/B1Qrwb/ vALO4Ewiqa2D+VAZJgw1jcDnbB1xEz/5FQJNArK+mSiN31hTwgUgudEeuhCV3oLAQy82 n7JeyChW2fH3UMO4X2ywp4P2w97YrwWjcVL45TTS7OoAVt3vDMfjxQB12pQURlNhGm61 xNSQZVLv52eOWXs7/gOc4llRnAc0oR98nKS/AT/EK4MLVNROlEFMF0NbkxdtVddOr1M/ dDGX+1kw+h3YZZyzTZeprnbLOOIf8t45ji/wVFKQZkuN+ZAXy1KLNUFLqvD1T+IrSxr6 nj7A== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.b=bm12KLjx; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::244 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qt0-x244.google.com (mail-qt0-x244.google.com. [2607:f8b0:400d:c0d::244]) by gmr-mx.google.com with ESMTPS id e186si1692826ywh.4.2017.08.02.02.59.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Aug 2017 02:59:21 -0700 (PDT) Received-SPF: pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::244 as permitted sender) client-ip=2607:f8b0:400d:c0d::244; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.b=bm12KLjx; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::244 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: by mail-qt0-x244.google.com with SMTP id p3so4047568qtg.5 for ; Wed, 02 Aug 2017 02:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mowcW/52hc43SO6ItlFl4DITxnA/zKj2gyxWziirWwo=; b=bm12KLjxxE4L1n30nhTj16+ghlJKGkdx1YQ39Au+K0csgrLk6TA89LeZKuLAQZxa9o 6O/UZ8ycEsO/g9rw/7welRv9wW+EHz8ivDMuSA9aFnK2wVOBVJ2W/yIHlyr7+rG9/xtf AZn4jjdEKHNoR79ps2rYbHKkIgBtyB6sk2w1cq7OKmG5PXbEY7bIrwntWeOqaVe75rmD g9G28A+tqjGKhnb47baTbFp4XO2MER2zQOrFjJ93G+tam21CzlwSHZqmG2kM7vmIsGCl 92U5pOxxAa1INNE/mvmy4hCOFKW1HSgRvK9+QGV8S8oe++2bYKH25KTt1UtSYiVFO/l3 0BsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mowcW/52hc43SO6ItlFl4DITxnA/zKj2gyxWziirWwo=; b=fM5i2Lrnrw2gUE862kP7k0MCzAyXEz1LQtVv9vyH1IY/kgRJPsgrjlIIEdwfx1i4t4 +KuZ12+eh6Bx0wHrpMfGDGs2L+zXJZcl0e3F2oaP22uQV9ghzkKJyDiDuQAGV2iOARpE zPJtCbHAehEnwQLTZe2XoOAjwwuTfRW3DpfcxCuobwu+Fyh8yhEj7UJO5zR8cyWX8G3i uV7PMxBiHeHUWJrF8nNz197rQR8q1EaExx8YJq1nrYNPd/BF15Ztqm0xrXHdnUGelJs1 Bp5YuUmAuvJuf1dpR8ztUrCGUIxJyMu8bil2qBbGa6ZLXlZF1I8tZZ9swaWJvS3rF9kG oKTw== X-Gm-Message-State: AIVw110+6wT0UjyTLjBz0LgA2f6t7kq+9qP1oc5cyfn7y2v2Q5DR7pzc HQ8uDo33RvLImwjmHioOzjx/gFU+lg== X-Received: by 10.200.45.240 with SMTP id q45mr32641069qta.332.1501667961753; Wed, 02 Aug 2017 02:59:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.148.188 with HTTP; Wed, 2 Aug 2017 02:59:21 -0700 (PDT) In-Reply-To: <448d9587745e4ce887e8f0768ddb3bbce5526751.1501582237.git.henning.schild@siemens.com> References: <448d9587745e4ce887e8f0768ddb3bbce5526751.1501582237.git.henning.schild@siemens.com> From: Alexander Smirnov Date: Wed, 2 Aug 2017 12:59:21 +0300 Message-ID: Subject: Re: [PATCH 12/16] meta: dpkg rename install to install_package To: Henning Schild Cc: isar-users@googlegroups.com Content-Type: multipart/alternative; boundary="001a113a81f06e53c90555c251f3" X-TUID: Lcxlc71O0v8B --001a113a81f06e53c90555c251f3 Content-Type: text/plain; charset="UTF-8" 2017-08-01 13:17 GMT+03:00 Henning Schild : > install will be used by later patches to actually populate debian > packages > > Signed-off-by: Henning Schild > --- > meta/classes/dpkg.bbclass | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index 71c7122..2a1b85c 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -18,14 +18,14 @@ do_compile() { > sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR} > } > > -addtask compile after do_unpack before do_install > +addtask compile after do_unpack before do_install_package > do_compile[stamp-extra-info] = "${DISTRO}" > > # Install package to dedicated deploy directory > -do_install() { > +do_install_package() { > install -m 755 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/ > } > Keeping in mind possible integartion to OE/Yocto, probably rename task to do_install_deb_package? Just to avoid possible user confusion with OE internals. In general I like the idea to rename tasks in deb building chain to some unique names, to avoid mess with "classical" OE tasks. > > -addtask install after do_compile before do_build > -do_install[dirs] = "${DEPLOY_DIR_DEB}" > -do_install[stamp-extra-info] = "${MACHINE}" > +addtask install_package after do_compile before do_build > +do_install_package[dirs] = "${DEPLOY_DIR_DEB}" > +do_install_package[stamp-extra-info] = "${MACHINE}" > -- > 2.13.0 > > -- > You received this message because you are subscribed to the Google Groups > "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to isar-users+unsubscribe@googlegroups.com. > To post to this group, send email to isar-users@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/isar-users/448d9587745e4ce887e8f0768ddb3bbce5526751.1501582237.git. > henning.schild%40siemens.com. > For more options, visit https://groups.google.com/d/optout. > --001a113a81f06e53c90555c251f3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


2017-08-01 13:17 GMT+03:00 Henning Schild <henning.schild@sie= mens.com>:
install will be = used by later patches to actually populate debian
packages

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
=C2=A0meta/classes/dpkg.bbclass | 10 +++++-----
=C2=A01 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index 71c7122..2a1b85c 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -18,14 +18,14 @@ do_compile() {
=C2=A0 =C2=A0 =C2=A0sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DI= R}
=C2=A0}

-addtask compile after do_unpack before do_install
+addtask compile after do_unpack before do_install_package
=C2=A0do_compile[stamp-extra-info] =3D "${DISTRO}"

=C2=A0# Install package to dedicated deploy directory
-do_install() {
+do_install_package() {
=C2=A0 =C2=A0 =C2=A0install -m 755 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/
=C2=A0}

Keeping in mind possible intega= rtion to OE/Yocto, probably rename task to do_install_deb_package? Just to = avoid possible user confusion with OE internals.

I= n general I like the idea to rename tasks in deb building chain to some uni= que names, to avoid mess with "classical" OE tasks.
=C2= =A0

-addtask install after do_compile before do_build
-do_install[dirs] =3D "${DEPLOY_DIR_DEB}"
-do_install[stamp-extra-info] =3D "${MACHINE}"
+addtask install_package after do_compile before do_build
+do_install_package[dirs] =3D "${DEPLOY_DIR_DEB}"
+do_install_package[stamp-extra-info] =3D "${MACHINE}"
--
2.13.0

--
You received this message because you are subscribed to the Google Groups &= quot;isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-u= sers+unsubscribe@googlegroups.com.
To post to this group, send email to isar-users@googlegroups.com.
To view this discussion on the web visit https= ://groups.google.com/d/msgid/isar-users/448d9587745e4ce887e8f0768= ddb3bbce5526751.1501582237.git.henning.schild%40siemens.com.<= br> For more options, visit https://groups.google.com/d/optout.

--001a113a81f06e53c90555c251f3--