From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247987705053184 X-Received: by 10.99.124.85 with SMTP id l21mr2244463pgn.159.1502184839290; Tue, 08 Aug 2017 02:33:59 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.107.58.197 with SMTP id h188ls2399658ioa.44.gmail; Tue, 08 Aug 2017 02:33:59 -0700 (PDT) X-Received: by 10.176.82.49 with SMTP id i46mr2175998uaa.16.1502184839052; Tue, 08 Aug 2017 02:33:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502184839; cv=none; d=google.com; s=arc-20160816; b=vSvcBj+VourIe9rLgmIge+AkQ7ih+9ppi6XUP+zm/2VkkM7D1hFvIPDPMHCYrQgse1 NSt2cpd3MpPGFTWgx7hIDgQVKEOwVDo25f45l1PLLDdv5AedShgyhwpnEaE75ogUoDUl TZL0cxGr1mdkjclGGGBoSbEQNXy1IjN3G4FjILJOHY8XGLiQqNkYcV/+Vg06YFfIXZu5 KjtLvL9oG/OKk4puAhJe6kmc2oQJ93l/46A/SY6MxpeNPkiPBPq9xqZB5j4WQJYJjiKS 1c5VgSZPy/zf6xEMqGzhpvbrmaXqPFbyWlTFN6o4NGsJinM8ZxSvpC9uZnSOO9a/DCTg 3MhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:arc-authentication-results; bh=sb8iKFpXBEO7Ta8Qscu+ryFhhucWeGC2ZDCqDeJhp5A=; b=kUgm4dxPcHeq0D+c6LhFXcBC7TvFPqXOwQ9k5jVxkdsC00h2BHg/3ygsDkW4g+MBMr kRQHwGFIhUnZzhnAknm+SKWXzNywgK4/NKtYDTxLWnLYxBBQGrmtex3TkndyDZ7XnOqe CPVVxj6f6hu+VgGIpRTLy/o/DsKNoDPQpxCLja1G9AvjxJjXgp0bsqsW49VIKcUY0cEk PpqgLvjjilL760IDO3ymiNn/P2MwW0rImbOT67P4xxfDct+fQ8q5gYyjixuX+rvuyC2q wlQriRsNCDMI5J+lp8Goj34H1VuYpl2hyAxt0fz6TLNG9DOhKionkxkiphQmxrLABk3d /Y6w== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=T9WFq6lv; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c09::232 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qk0-x232.google.com (mail-qk0-x232.google.com. [2607:f8b0:400d:c09::232]) by gmr-mx.google.com with ESMTPS id r67si46879ywg.9.2017.08.08.02.33.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 02:33:58 -0700 (PDT) Received-SPF: pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c09::232 as permitted sender) client-ip=2607:f8b0:400d:c09::232; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=T9WFq6lv; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c09::232 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: by mail-qk0-x232.google.com with SMTP id d136so16596206qkg.3 for ; Tue, 08 Aug 2017 02:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sb8iKFpXBEO7Ta8Qscu+ryFhhucWeGC2ZDCqDeJhp5A=; b=T9WFq6lvMOR3FAzItmhWwv0AnO1bJW/ddqAqi73h5SViBxQUL0dRz691dRsptONN1l tGDN0x/VXrx5ySjEMpoURhkoNOeYgpphp2P5rzCj+jeAuUvO7DtnvIm2DU6IJF1CWoWS cLNlBof3PgF7ltzBUq6EjlN5olHtu/RV+4aiqtDKDD96R4hMH4YeOfjoYJMY/y4VA14x 3gXO+VkSjc+Q/hlfyK0uTPOJBspV8GtnDDVnQPC6TbGzE+Y9DGsncbFHQ6wwM3wF4QA3 fOEErfZJvcSzeGPfG/AcaDrlqVii2BjP59Zykz7+BqSNdEsGoDT2zL3NVsQRRvbWR+Hw f0rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sb8iKFpXBEO7Ta8Qscu+ryFhhucWeGC2ZDCqDeJhp5A=; b=mQ1m1ZzOoiqvOwtH5tg6S+iQ0ohAW8LyLHWjnH0N5kunb8O+Df1+cKSxfWwxCblW2F rxoNsnyO5FQHKyh9JpkMEG5qRJgZahBmrI1BXQCLOhreIZFuFEKf9iE6S3osl0wuMUsT gkCuIULbWUlfP2zgx3yi+NmsK7JNxJ2vilIFX4wXntMaVRo85BW1o75yiGSIhV7BmiGb hwidx/08/nX4x5HIjFgszY/menwVaekuRlRjCXD9b+nrFCgArGKm6mCXCSU0F8EG0731 Od34EEGzCDvTWxlXbg4Ygkh2gyydEGjS3MxnJvk7IL6aLYxOIXqOsRrr1nMbdH0TqSPS vOyA== X-Gm-Message-State: AHYfb5jCMtk/4reVA+d7K4R15tA60jOPnlqJyBNC5nbQUhUe7FamH/3m 6xYQC7xahmmagiczojjJSDwgXgCCTA== X-Received: by 10.55.110.196 with SMTP id j187mr2370171qkc.128.1502184838822; Tue, 08 Aug 2017 02:33:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.148.188 with HTTP; Tue, 8 Aug 2017 02:33:58 -0700 (PDT) In-Reply-To: <20170808100527.097c4ab1@md1em3qc> References: <369a52a90daaf90bbf7ebcc8831589b7085fcfa3.1501760818.git.henning.schild@siemens.com> <20170808100527.097c4ab1@md1em3qc> From: Alexander Smirnov Date: Tue, 8 Aug 2017 12:33:58 +0300 Message-ID: Subject: Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function To: Henning Schild Cc: isar-users@googlegroups.com Content-Type: multipart/alternative; boundary="94eb2c05b69ab480e205563aa931" X-TUID: TY7qZ8jflzoR --94eb2c05b69ab480e205563aa931 Content-Type: text/plain; charset="UTF-8" 2017-08-08 11:05 GMT+03:00 Henning Schild : > Am Mon, 7 Aug 2017 22:36:18 +0300 > schrieb Alexander Smirnov : > > > I'm not sure that this function is unused. It's usually used for debug > > purposes to route traces to console. > > It is unused in Isar and not part of the default base class of bitbake. > > > http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html > > chapter: 2.3.8.2 > > OE implements it in meta/classes/logging.bbclass > > That's a good hint! So probably we can move this function to similar class instead of removing it. > > I think it makes sense to keep it to debug complicated classes and > > recipes in future. > > Ok. > > Henning > > > 2017-08-03 14:55 GMT+03:00 Henning Schild > > : > > > > > Signed-off-by: Henning Schild > > > --- > > > meta/classes/isar-base.bbclass | 12 ------------ > > > 1 file changed, 12 deletions(-) > > > > > > diff --git a/meta/classes/isar-base.bbclass > > > b/meta/classes/isar-base. bbclass > > > index 67d38a1..efd4223 100644 > > > --- a/meta/classes/isar-base.bbclass > > > +++ b/meta/classes/isar-base.bbclass > > > @@ -21,16 +21,4 @@ > > > > > > THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}" > > > > > > -bbdebug() { > > > - test $# -ge 2 || { > > > - echo "Usage: bbdebug level \"message\"" > > > - exit 1 > > > - } > > > - > > > - test ${@bb.msg.debug_level['default']} -ge $1 && { > > > - shift > > > - echo "DEBUG:" $* > > > - } > > > -} > > > - > > > do_build[nostamp] = "0" > > > -- > > > 2.13.0 > > > > > > > > --94eb2c05b69ab480e205563aa931 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


2017-08-08 11:05 GMT+03:00 Henning Schild <henning.schild@sie= mens.com>:
Am Mon, 7 Aug 20= 17 22:36:18 +0300
schrieb Alexander Smirnov <alex.bluesman.smirnov@gmail.com>:

> I'm not sure that this function is unused. It's usually used f= or debug
> purposes to route traces to console.

It is unused in Isar and not part of the default base class of bitba= ke.

> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
> chapter: 2.3.8.2

OE implements it in meta/classes/logging.bbclass


That's a g= ood hint! So probably we can move this function to similar class instead of= removing it.
=C2=A0
> I think it makes sense to keep it to debug complicated classes and
> recipes in future.

Ok.

Henning

> 2017-08-03 14:55 GMT+03:00 Henning Schild
> <henning.schild@sieme= ns.com>:
>
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >=C2=A0 meta/classes/isar-base.bbclass | 12 ------------
> >=C2=A0 1 file changed, 12 deletions(-)
> >
> > diff --git a/meta/classes/isar-base.bbclass
> > b/meta/classes/isar-base. bbclass
> > index 67d38a1..efd4223 100644
> > --- a/meta/classes/isar-base.bbclass
> > +++ b/meta/classes/isar-base.bbclass
> > @@ -21,16 +21,4 @@
> >
> >=C2=A0 THISDIR =3D "${@os.path.dirname(d.getVar('FIL= E', True))}"
> >
> > -bbdebug() {
> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0test $# -ge 2 || {
> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0echo &quo= t;Usage: bbdebug level \"message\""
> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0exit 1 > > -=C2=A0 =C2=A0 =C2=A0 =C2=A0}
> > -
> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0test ${@bb.msg.debug_level['= default']} -ge $1 && {
> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0shift
> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0echo &quo= t;DEBUG:" $*
> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0}
> > -}
> > -
> >=C2=A0 do_build[nostamp] =3D "0"
> > --
> > 2.13.0
> >
> >


--94eb2c05b69ab480e205563aa931--