From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6450128683656019968 X-Received: by 10.200.33.213 with SMTP id 21mr2676692qtz.12.1502197573040; Tue, 08 Aug 2017 06:06:13 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.36.125.79 with SMTP id b76ls2518958itc.15.canary-gmail; Tue, 08 Aug 2017 06:06:12 -0700 (PDT) X-Received: by 10.98.13.20 with SMTP id v20mr2511106pfi.46.1502197572766; Tue, 08 Aug 2017 06:06:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502197572; cv=none; d=google.com; s=arc-20160816; b=RVOjIAim135/Hnad8qm1/mTCSLAEFmSOo835lYrf6zrYtOQjiQ8qBR03I+1ZAl0pwD KyjkCpPds2Q/8GnYnEEuaJWTXOcfvNC4GeZxWusDVfkYJujwX+4U8c06x0G6Rv34o+vg f1lfUzVpbXTMnG8TIRKAqFJ880CjO1aw8O4ZZsUzrF6a9YESAINw7ABsYhUlzlmI3QQk BXX1/ExHMTL/kDCeSrhHn1VgOLUyzu+5h5w+UHbi5G5TYDFDRTTfSstKyVvmIP6EXOFA GcxKpQ6S/8XNQfibUcGL25i69xWlbkfHWgMqB2GT1EVRa+Zhp8swTCcZJgdokBrKWrEs U7PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:arc-authentication-results; bh=THjuUdIp0z8+jGq2Jv+SL05kQkgSEq85l/lVcF6/8ec=; b=cmR2F3/8ic6isGnh6okZ0e3y+O6EKNLYaP2x5hpbwL7mHt/MSE24ky04gMz76nFjVw CgebPTUjyxo5+LesxS/cL7/E43Ff1pK2dSp9OCbcr9/d34lGLKQEn2TJZEjDReSl5zDM 9djQer3Rs+a4JD6y6eMd/Jm3wvv13iW3OfZQMoCOEaaz7/W1Bo+bmeFM0lH6cx6U4pYF 6J6nweWqSvPw+kWlX66XeY5uKWDfw6pHvNDRQP6pFQfmve6TiMG5CeYW2mVIBx3SuEBv hOSny7eUwA3UsFqZbF1NyIc1/3RSeXnKNxEjyt3k4+TG7tECVxOTkX9ebF5HtcOmc2Wu ngUA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pE6pbn5D; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400e:c00::243 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com. [2607:f8b0:400e:c00::243]) by gmr-mx.google.com with ESMTPS id b9si202170pfm.20.2017.08.08.06.06.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 06:06:12 -0700 (PDT) Received-SPF: pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400e:c00::243 as permitted sender) client-ip=2607:f8b0:400e:c00::243; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pE6pbn5D; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400e:c00::243 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: by mail-pf0-x243.google.com with SMTP id t83so3002091pfj.3 for ; Tue, 08 Aug 2017 06:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=THjuUdIp0z8+jGq2Jv+SL05kQkgSEq85l/lVcF6/8ec=; b=pE6pbn5Dk4ppsyPBkzymktUjS2JjSQ/yUwK8L2WWy9FQIhc52bz0kJGXRDK+zqrWh1 LTSlyn97pwsfpAmfq3JrP6pJiYvvf4PoP1oDUEzREoVBNe/6GVjYzV73GCbucNxZ9E5L h4pR8hclD0gUr/5KigtIPLBZu1YQd/O5QTv0P401ZHwJiW1Iud9zSoEYCO8qMYZ3Dztv MW0i+Ow03cWCDqRUTzEbHpcOswmRkvAQI66jMxx+0RxXbj1uuvM/GfHmVyX1aZy3CIp4 hHRJq8xPxIA37fknwEOxvaHAER1w5m3G+W/+o9YMrLxL8VGFuR3nyNjDSPbMztYh0EUC gIEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=THjuUdIp0z8+jGq2Jv+SL05kQkgSEq85l/lVcF6/8ec=; b=iC4pdEBxmKKUHc6Qf6+v2fARfChq+zGRmxLpoZclW2az+gK/jaTWJlIYFlXqQ+ocve pm/Dzdi6weNS0bpnWlXx9XkH5SD10DiuNH62TuI6v/5rwtlXoPgaecz0JbWaUOXxAEAW rIGu+0k8CXm+LjSvAvXjNM8pgmQQQni5oNOhFH+2phEkUB2+8/tLwrcOWJdLMQ0GZR+y C1mHi1vxypljLMhnCLzznFjrLtiBSUichKTiWGBwC5vXr0j9wxCyfS2rr0OeRVY2BB1G hNhJbVCjH7j750QLCAQCvz0RnEzKFzYbH69OxtJVZojdW+98GidG2W5OHNDJ6RjbGbbW Ow0A== X-Gm-Message-State: AHYfb5i39iops6//M0aGMiph5rcRBIalWUhpb4hoVqh5TQMSM63bc01w nSON9T4gBTE7+ZbYcPdvgvNNoFZp4tgf X-Received: by 10.237.37.140 with SMTP id x12mr5345109qtc.133.1502197572218; Tue, 08 Aug 2017 06:06:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.148.188 with HTTP; Tue, 8 Aug 2017 06:06:11 -0700 (PDT) In-Reply-To: References: From: Alexander Smirnov Date: Tue, 8 Aug 2017 16:06:11 +0300 Message-ID: Subject: Re: [PATCH 11-16 of 16 v2 1/6] meta: dpkg rename install to package_write_deb To: Henning Schild Cc: isar-users@googlegroups.com Content-Type: multipart/alternative; boundary="001a114211e2acb3ea05563da004" X-TUID: OTRlosKOeYtv --001a114211e2acb3ea05563da004 Content-Type: text/plain; charset="UTF-8" 2017-08-03 22:15 GMT+03:00 Henning Schild : > This way we stay with OE names. The name "install" will be used to > populate ${D} in a later patch, also in line with OE. > > Signed-off-by: Henning Schild > --- > meta/classes/dpkg.bbclass | 9 ++++----- > meta/classes/image.bbclass | 2 +- > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index ca0c5ab..97238b5 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -23,12 +23,11 @@ do_build() { > sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR} > } > > - > # Install package to dedicated deploy directory > -do_install() { > +do_package_write_deb() { > Why it's 'package_write_deb'? If we speak about 'like-OE' style, in OE this function does (NOTE: I provide links to GitHub because they have line numbering): 1. package_write_deb: https://github.com/MentorEmbedded/poky/blob/master/meta/classes/package_deb.bbclass#L342 2. It calls package_deb: https://github.com/MentorEmbedded/poky/blob/master/meta/classes/package_deb.bbclass#L51 So this function performs creating of deb package from built binaries. In general it's quite difficult to map Isar package building process to OE (some tasks like 'patch' are missed due to no meaning in this context): 1. Isar: fetch -> unpack -> (!) build (using dpkg) 2. OE: fetch -> unpack -> (!) configure -> compile -> install -> package_write_deb So all the tasks after (!) in OE are done in single task in Isar. That's one of the Isar main difference from OE, that package building is performed by native Debian tools and this process can't be break-down and one-to-one mapped to OE tasks. Regarding the function in patch, this is defenitely install and not package write, but we can specify what kind of install, for example: install_to_deploy, or populate_apt or etc... Alex > install -m 755 ${BUILDROOT}/*.deb ${DEPLOY_DIR_DEB}/ > } > > -addtask install after do_build > -do_install[dirs] = "${DEPLOY_DIR_DEB}" > -do_install[stamp-extra-info] = "${MACHINE}" > +addtask package_write_deb after do_build > +do_package_write_deb[dirs] = "${DEPLOY_DIR_DEB}" > +do_package_write_deb[stamp-extra-info] = "${MACHINE}" > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 3e4877c..f60ec11 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -27,4 +27,4 @@ do_populate() { > } > > addtask populate before do_build > -do_populate[deptask] = "do_install" > +do_populate[deptask] = "do_package_write_deb" > -- > 2.13.0 > > --001a114211e2acb3ea05563da004 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


2017-08-03 22:15 GMT+03:00 Henning Schild <henning.schild@sie= mens.com>:
This way we stay with OE names. The name "install" will be use= d to
populate ${D} in a later patch, also in line with OE.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
=C2=A0meta/classes/dpkg.bbclass=C2=A0 | 9 ++++-----
=C2=A0meta/classes/image.bbclass | 2 +-
=C2=A02 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index ca0c5ab..97238b5 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -23,12 +23,11 @@ do_build() {
=C2=A0 =C2=A0 =C2=A0sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DI= R}
=C2=A0}

-
=C2=A0# Install package to dedicated deploy directory
-do_install() {
+do_package_write_deb() {

Why it's = 'package_write_deb'? If we speak about 'like-OE' style, in = OE this function does (NOTE: I provide links to GitHub because they have li= ne numbering):

1. package_write_deb:
https://github.com/MentorEmbedded/poky/blob/mast= er/meta/classes/package_deb.bbclass#L342

2= . It calls package_deb:

So this function performs creating of deb pac= kage from built binaries.


In genera= l it's quite difficult to map Isar package building process to OE (some= tasks like 'patch' are missed due to no meaning in this context):<= /div>

1. Isar: fetch -> unpack -> (!) build (using= dpkg)=C2=A0
2. OE: fetch -> unpack -> (!) configure -> = compile -> install -> package_write_deb

So a= ll the tasks after (!) in OE are done in single task in Isar. That's on= e of the Isar main difference from OE, that package building is performed b= y native Debian tools and this process can't be break-down and one-to-o= ne mapped to OE tasks.

Regarding the function in p= atch, this is defenitely install and not package write, but we can specify = what kind of install, for example: install_to_deploy, or populate_apt or et= c...

Alex
=C2=A0
=C2=A0 =C2=A0 =C2=A0install -m 755 ${BUILDROOT}/*.deb ${DEPLOY_DIR_DEB}/ =C2=A0}

-addtask install after do_build
-do_install[dirs] =3D "${DEPLOY_DIR_DEB}"
-do_install[stamp-extra-info] =3D "${MACHINE}"
+addtask package_write_deb after do_build
+do_package_write_deb[dirs] =3D "${DEPLOY_DIR_DEB}"
+do_package_write_deb[stamp-extra-info] =3D "${MACHINE}"
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 3e4877c..f60ec11 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -27,4 +27,4 @@ do_populate() {
=C2=A0}

=C2=A0addtask populate before do_build
-do_populate[deptask] =3D "do_install"
+do_populate[deptask] =3D "do_package_write_deb"
--
2.13.0


--001a114211e2acb3ea05563da004--