From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247987705053184 X-Received: by 10.237.50.69 with SMTP id y63mr1032374qtd.125.1502134579145; Mon, 07 Aug 2017 12:36:19 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.107.17.132 with SMTP id 4ls1572818ior.1.gmail; Mon, 07 Aug 2017 12:36:18 -0700 (PDT) X-Received: by 10.107.62.69 with SMTP id l66mr1029310ioa.49.1502134578809; Mon, 07 Aug 2017 12:36:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502134578; cv=none; d=google.com; s=arc-20160816; b=PHHnVGfi/mRGie49CqYWDjIZlmesnvfP3JKItxyngo19YU7zi9ercrQ6TgIu5Kzg37 qMSY1IpI8LuJfpXfww9AW1r/7w8eQwnYAV5ivqmM2Mrzvc/RKgKuZ1L9XQW5qHqP4gLN UrnEmdb4PUTpNpW8rYhcJX2jP+qKLPuGSaGgZjDaXmxZj3lB7N8UqkZBixfV+OIv/BPZ 68TJyALKp2v0ooo5Gl4GrL2tomnvtiHnyuAbNFMTQRa59rN4Dm1aoKbvCXDR6xOeYIYg jDvL0WP8ECunI/SouPiph0mLYESF37OnsYLNhfO7XMREp9ogC7j/qBy5uQEHJ6ZnnOVg GN1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:arc-authentication-results; bh=QZesGPjTnDErsgNNfFXLEXaHR0BcA01F31FgNamB2sM=; b=ujd0M82eOj9Fz4jZL8bv0MyXVB+NaovGvulpiZUjpTzqvD8bbtbw6ykji6BjkD7xUg JW2p0hQEtapZHxW3ZvcV0YKBpb9PJZhbo1qfTLdPlxTKlxaYdVNRkQiv28pPMoy1s1iL 6Q4XmICBfMNfcRhnvVN8hSE7/u2H0T7Gi7uYAT0H/mMqMGP9hFjKA0IbqGRR74Yw8R/X n7MJO9mKS+6nmlYk/+F16+KIYgPp8zdo32JWH1q8ihWZqWmlOmPkVG5i3USC2ZbMSWYJ 31csuV7SLHui59q/gCXWAenaR4pN0MWYz/NWz//y8jTQ8CSxsoo/M1Z7YbbbmNyWO2YV AsVg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.b=ifyPeNZT; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::242 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qt0-x242.google.com (mail-qt0-x242.google.com. [2607:f8b0:400d:c0d::242]) by gmr-mx.google.com with ESMTPS id g6si252213ywf.15.2017.08.07.12.36.18 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Aug 2017 12:36:18 -0700 (PDT) Received-SPF: pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::242 as permitted sender) client-ip=2607:f8b0:400d:c0d::242; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.b=ifyPeNZT; spf=pass (google.com: domain of alex.bluesman.smirnov@gmail.com designates 2607:f8b0:400d:c0d::242 as permitted sender) smtp.mailfrom=alex.bluesman.smirnov@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: by mail-qt0-x242.google.com with SMTP id i19so1463636qte.1 for ; Mon, 07 Aug 2017 12:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QZesGPjTnDErsgNNfFXLEXaHR0BcA01F31FgNamB2sM=; b=ifyPeNZTQgncIy2Yl6DJpB242Ry0qF3KLrvOQpSlLgMnUeFf+ZFgGOTkyX0b+gSqeQ tS9y1bVXL7c5Ov/aSRDGso03gXhKJO9brcGlWorv/CPq/tyMoQAAVm1wQju0xJyWOyL6 w8yowrhWHxu3OBnd/fE+THDVW51w5Uv0VQtI3T6ELZ49dPyAZ6JkFkynCitnalV1PoA0 NiyQcQ1R3s92SS8ER0Nonv7gmA0EmXWtGxzKW18Vi2mjQ6oRzPVagUQUXo0Y3VOQZg9o 4Y72a0l0zWzZ7zjg0PzFd3nOdIvw7DdIkMqZ502cI4rKAFjeoB0c9lon3YQH+QJ+eJkC F64A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QZesGPjTnDErsgNNfFXLEXaHR0BcA01F31FgNamB2sM=; b=A7l/ML933TWGtYjMsazI318DeLsBzCNKduPPs5LFxgoMJA4pRPe9DOBIyURLlB6P6X Xl/g8yQAHhtVk01SuiAwc4Jb9HLt+AN/1G1lEvq7Js77REtT+dGcUONIeA77JZhJmG1u pxFvaiywndD9RkPHWO3Pp4bBecOkoOPneQiTyj6dWpoq1I+6RKa222RaNteA834tthMR EReUzEFEHiXbeoCD8NNN72GeV/uEomXsw2RTUl+YeZQeCEwHq+rJmks9B67JJSeFsE+l tb0d6ZW8MMuk16MIBZgP5hPoiWN4pkOQa8lnvVhQYOtyMmpJIqnbOuYcGyW7QDVOZSq+ MbsA== X-Gm-Message-State: AHYfb5jG3zCAeOBsd1d65hv5oBhkBkwSdO3KJb246K38AWaFQ8MYZ5KQ jeHdAroTHpUU78GDw4IN51iDlSnt47gk X-Received: by 10.237.41.230 with SMTP id o93mr2475067qtd.27.1502134578425; Mon, 07 Aug 2017 12:36:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.148.188 with HTTP; Mon, 7 Aug 2017 12:36:18 -0700 (PDT) In-Reply-To: <369a52a90daaf90bbf7ebcc8831589b7085fcfa3.1501760818.git.henning.schild@siemens.com> References: <369a52a90daaf90bbf7ebcc8831589b7085fcfa3.1501760818.git.henning.schild@siemens.com> From: Alexander Smirnov Date: Mon, 7 Aug 2017 22:36:18 +0300 Message-ID: Subject: Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function To: Henning Schild Cc: isar-users@googlegroups.com Content-Type: multipart/alternative; boundary="94eb2c124b8af3b62005562ef527" X-TUID: HCVk+EmETleB --94eb2c124b8af3b62005562ef527 Content-Type: text/plain; charset="UTF-8" I'm not sure that this function is unused. It's usually used for debug purposes to route traces to console. http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html chapter: 2.3.8.2 I think it makes sense to keep it to debug complicated classes and recipes in future. 2017-08-03 14:55 GMT+03:00 Henning Schild : > Signed-off-by: Henning Schild > --- > meta/classes/isar-base.bbclass | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/meta/classes/isar-base.bbclass b/meta/classes/isar-base. > bbclass > index 67d38a1..efd4223 100644 > --- a/meta/classes/isar-base.bbclass > +++ b/meta/classes/isar-base.bbclass > @@ -21,16 +21,4 @@ > > THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}" > > -bbdebug() { > - test $# -ge 2 || { > - echo "Usage: bbdebug level \"message\"" > - exit 1 > - } > - > - test ${@bb.msg.debug_level['default']} -ge $1 && { > - shift > - echo "DEBUG:" $* > - } > -} > - > do_build[nostamp] = "0" > -- > 2.13.0 > > --94eb2c124b8af3b62005562ef527 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'm not sure that this function is unused. It's us= ually used for debug purposes to route traces to console.

http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html
chapter: 2.3.8.2

I think it makes sense to k= eep it to debug complicated classes and recipes in future.

2017-08-03 14:55 GMT+03:0= 0 Henning Schild <henning.schild@siemens.com>:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Henning Sch= ild <henning.schild@siemen= s.com>
---
=C2=A0meta/classes/isar-base.bbclass | 12 ------------
=C2=A01 file changed, 12 deletions(-)

diff --git a/meta/classes/isar-base.bbclass b/meta/classes/isar-base.<= wbr>bbclass
index 67d38a1..efd4223 100644
--- a/meta/classes/isar-base.bbclass
+++ b/meta/classes/isar-base.bbclass
@@ -21,16 +21,4 @@

=C2=A0THISDIR =3D "${@os.path.dirname(d.getVar('FILE', Tr= ue))}"

-bbdebug() {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0test $# -ge 2 || {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0echo "Usage: b= bdebug level \"message\""
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0exit 1
-=C2=A0 =C2=A0 =C2=A0 =C2=A0}
-
-=C2=A0 =C2=A0 =C2=A0 =C2=A0test ${@bb.msg.debug_level['default= 9;]} -ge $1 && {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0shift
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0echo "DEBUG:&q= uot; $*
-=C2=A0 =C2=A0 =C2=A0 =C2=A0}
-}
-
=C2=A0do_build[nostamp] =3D "0"
--
2.13.0


--94eb2c124b8af3b62005562ef527--