From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7033292862949163008 X-Received: by 2002:a17:907:a414:: with SMTP id sg20mr36841270ejc.183.1637906883043; Thu, 25 Nov 2021 22:08:03 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:c517:: with SMTP id o23ls1396701edq.2.gmail; Thu, 25 Nov 2021 22:08:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJwrpBxBcOUeAuFBhtLdtWg5ynUoaPoUK83wKJworhMpgXCIPktuImBQAa1MjxxZdky8oRIC X-Received: by 2002:a05:6402:2692:: with SMTP id w18mr44822396edd.220.1637906882077; Thu, 25 Nov 2021 22:08:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637906882; cv=none; d=google.com; s=arc-20160816; b=ZyvTXe+kfOpYXPH1Vk4F70mhUHQqKhLA0Yk8XhT0LLCT90s/X2E69S3GUSda4AoA/3 4RaPDkZMe/5PGxP3Xba1juB+OCyLFf/d4a36/a/wxWVygHmxwILx4ADj3OEo1qNScZIf 5YrLN9lBJkgv5BiC2Z3w3HwFVCgDpHGtkhMtVnKOrs8pzl4eWbuU7WMsc7McpKq1Knmu AbTRKaptoRIrZn9HlE+VJ5LQGKsmHMzP9n7meqCnQ+rr4ETlICtnv9Np2ZmKjSHl1CVq 5qIVF4aiSATEHlShTeyW1zKmbIGoddy0aAfu6qmsqlR1AatqECryQM6/0kVyWF6Wjack 98nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=HPXmF4nxK3WpOryFFHgfmjjAJpXZI5U7cF+zDWkeEoY=; b=J42nnkxxb1hnbECUFNF9oUNcv+s6Chgw3jb/PEiVqLj/eRy5osf/x7c1JoCgfKrkqO 0J7l9XHVrp7cBUczr6ZscnEy1Y9Lpy9ec/JD/m16B2/8H4X/Wfl4GeWJQbjn26kEMzG+ IMzc2/eKm7oz5jGK1JTVsjDv2ThKxhb4e1MyIFBm1/3SGRnxa6HnCmBndBq360mZYy8a DZjjWTNTx7ANLgIyAVGeTX/wa+2OoJpdqI3OJeZtWUoMuI7dWnRHEMxlua6dF0MoOxCG dBuFzesRLk9f9XkhmW3vCfJDGhirkM9ppbtzX9KpjpnQP1DHaF+ZW+Hf/i5YTuvgoCzT AaaA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=APcdZ2tV; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32b as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com. [2a00:1450:4864:20::32b]) by gmr-mx.google.com with ESMTPS id d5si385087ede.2.2021.11.25.22.08.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Nov 2021 22:08:02 -0800 (PST) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32b as permitted sender) client-ip=2a00:1450:4864:20::32b; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=APcdZ2tV; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32b as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wm1-x32b.google.com with SMTP id c6-20020a05600c0ac600b0033c3aedd30aso6054342wmr.5 for ; Thu, 25 Nov 2021 22:08:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HPXmF4nxK3WpOryFFHgfmjjAJpXZI5U7cF+zDWkeEoY=; b=APcdZ2tVBEkpc1hHoIuI7Vz+eBSCXQBYk1z7c72oTt0p2AKhaNrS2AblWWtmaE//wn zgG6t6xpIi08Qvg2lYeJiuPCs2zbNiHB8/eGbUiglSNn3kQdndjUhousn1I8m6yoA+/l S01YvIvc0ewmLY+f6QuULcFcw3Ga0PGS4tX6A2NGv7vZvOlg9F6KNVhYePhmZaPhWvEI J73p9157OB4ua/kXsDSN//r1tSO9CZrPOe17eLrD+yYFemBvYxEOCQ7U8mP84oFno9ac OYBV/1kiYRz+W0Is/OlYCJms4sjHT6ZUeVfC7JzmCwFwWSH1uDNTBo0zW7ArAFjhI5G6 eSzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HPXmF4nxK3WpOryFFHgfmjjAJpXZI5U7cF+zDWkeEoY=; b=l+SRaUV7b/exWCGsnwYJ84G4n4RohC4K8AzTEY5q5dZtQ+gxMnWfDQnxPVaieygXFx ovjQGRvpEw4yCnLUdohPuwsngI7ahw+OjI4OTO0wDoZRP2SftZYtK453vUFCb6vYf2rm Ltb+ws8owT8/wusBMYas33SPPRNmEmGYcmsbkf866OuMf2tbUrLPKKLCN/+JxvXA/U5L mGkef/qUm/RlqXC+6lE4Kx2C24oCxaemPi42fh2veVp7VXkdwlgMMcFuPHvm1aKM1E6y FpWK0zznH2ywqiCqG4gCpBm3k/wNbM7JSt3o/1z0YbfhOY/6UCeqPlVE8B4ucDmeGZVM cngw== X-Gm-Message-State: AOAM532/7tfXRoPXqsC7dJNFPGFHPVwxtue+CPV3BdMV2W9+pvSn/RNT MGUrZYJHKUYQ9h/9UnFCpJ54ZFjoB8VXLXtKQ6g= X-Received: by 2002:a05:600c:21cd:: with SMTP id x13mr13508933wmj.52.1637906881691; Thu, 25 Nov 2021 22:08:01 -0800 (PST) MIME-Version: 1.0 References: <20211122152607.2125422-1-Vijaikumar_Kanagarajan@mentor.com> <20211122152607.2125422-4-Vijaikumar_Kanagarajan@mentor.com> <8319aef1-420a-034e-9152-b0c3c8c3536a@siemens.com> In-Reply-To: From: vijai kumar Date: Fri, 26 Nov 2021 11:37:50 +0530 Message-ID: Subject: Re: [PATCH v2 3/4] meta: u-boot: Prepare for newer versions To: Jan Kiszka Cc: Gylstorff Quirin , Vijai Kumar K , isar-users Content-Type: text/plain; charset="UTF-8" X-TUID: BhDmjOwSzchl On Thu, Nov 25, 2021 at 10:04 PM Jan Kiszka wrote: > > On 25.11.21 17:27, vijai kumar wrote: > > On Thu, Nov 25, 2021 at 12:12 PM vijai kumar > > wrote: > >> > >> On Tue, Nov 23, 2021 at 3:24 PM Gylstorff Quirin > >> wrote: > >>> > >>> Hi, > >>> > >>> On 11/22/21 4:26 PM, Vijai Kumar K wrote: > >>>> Newer versions of u-boot require libssl-dev:native for compilation. > >>>> It also needs libssl-dev of the host architecture for cross compilation > >>>> of tools. > >>>> > >>>> Signed-off-by: Vijai Kumar K > >>>> --- > >>>> meta/recipes-bsp/u-boot/u-boot-custom.inc | 4 +++- > >>>> 1 file changed, 3 insertions(+), 1 deletion(-) > >>>> > >>>> diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc > >>>> index 5198809..cfae0e2 100644 > >>>> --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc > >>>> +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc > >>>> @@ -41,7 +41,9 @@ python() { > >>>> d.setVar('U_BOOT_BUILD_PROFILES_remove', "config") > >>>> } > >>>> > >>>> -DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git" > >>>> +DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, libssl-dev:native" > >>>> +DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' \ > >>>> + if bb.utils.contains('U_BOOT_BUILD_PROFILES', 'tools', 1, 0, d) else ''}" > >>> > >>> Is there are reason why you didn't use `Build-Depends syntax extension` > >>> from[1]? > >>> > >> Hi Quirin, > >> > >> Yes. There was. The previous version of patch depends on > >> ISAR_CROSS_COMPILE as well. > >> > >> Guess there is nothing stopping us now. But, wondering if we can start > >> introducing it via some > >> example app with some documentation so that basic users are not > >> puzzled on seeing that line in > >> a recipe. > >> > >> Also, we could define a whole new variable to help recipe writers to > >> define profiles and seamlessly > >> use them without the need to explicitly export DEB_BUILD_PROFILES in > >> the recipe's dpkg_runbuild > >> > >> Now that we are serious enough, we should probably take care of your > >> earlier comment > >> as well on following the standard. So that we don't conflict with > >> Debian's predefined variables in case > >> we decided to build a package fetched from apt:// and wanted to make > >> use of its profile settings. > >> > >> Still need to look further but these are my initial thoughts. I could > >> probably send some patches for review in > >> coming days. > >> > >> For now, maybe we should call it and use pkg.uboot.tools instead of > >> tools here so that we don't > >> find something in that implementation that requires us to change this > >> in future, possibly breaking > >> u-boot / or the need to provide compatibility. > >> > >> Thoughts? > > > > OTOH, This could still go in. Since the design I am thinking of is not > > finalized and might take some discussions in the list, there is no > > point in holding this back. > > > > I think Quirin was just asking for > > DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, \ > libssl-dev:native, libssl-dev " > > rather than using bitbake logic. If that also works, would be more elegant. Yes, that also works. But just a bit difficult to read for normal users. A framework for DEB_BUILD_PROFILES for isar would be helpful I guess, like I mentioned above. Will see if I can convert my thoughts to some patches sometime soon. Thanks, VIjai Kumar K > > Jan > > -- > Siemens AG, T RDA IOT > Corporate Competence Center Embedded Linux