From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7033292862949163008 X-Received: by 2002:a2e:9bc9:: with SMTP id w9mr28770708ljj.27.1637908407125; Thu, 25 Nov 2021 22:33:27 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:8611:: with SMTP id a17ls791573lji.1.gmail; Thu, 25 Nov 2021 22:33:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJzN1uBGsAbd9m9sJ2OFAjyPyZNoFLDaypULHru5CKHugeSppwc8bPdrVBBRFGzd+tXOTPHG X-Received: by 2002:a05:651c:4d3:: with SMTP id e19mr29498145lji.164.1637908405962; Thu, 25 Nov 2021 22:33:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637908405; cv=none; d=google.com; s=arc-20160816; b=uxh/sRjuNzf3W3coMNGc3L5Td7GINNKUpX7vgkfaAmp8FHSa9zXk8FzSiKKFJv68hy Z4WWHKKO53oEwfogRQvJLb+fBRnrJ1ZCWBRsoiiI/OfsTV0bzVkBY9oRHAmfACeY6RBX TsKCRtlyUJOHCD8yFZ6IDrl/Ed7rYG1hQeClEZ/80PRdXbY1p+ssoMXCXnS7rWYw1mzb YF/4td76KlIJsz6FrcqNKBbUIrNOwZr1yPRT4F+iN+E5QduA1xKLQ5cQ71dKK+Z4CEKF T0WUxbzaa9WdEbqH+cd+NiK7QOa1mX+R0F/AEI/YSCEj/pGp2L+ZKlyzHeceA7ubyl9D 7n3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=PkwSkaJOHzHzXu8FBL/hxthRpyNwrfH0KNlWnLJt++Q=; b=Q8jak+mIBiuD1WQSoaPRfkZ6+rHmCBQ5mPmGNNMS6avX0owHeluI0Q6bpGbaBQJlyr IYAXgQfxDqiTa6Wapc24jawDbWtqoU+SdFh62Th5V/uX0xYk4JWU1xiCRSIJaMca5NBL wXVfRf7dH8Jx+EaFSAa0pL9EYRU5/MkSaRecG23jkS4U7qxtjyPpoPiNnPPDvnm2siyt dmzfXA+Uxjx/dNXgLS3uHog6k2eV7ags9aJBpYCVkzwHFluR115U2xl1CDIDEN76Uvf/ Uao7wZ1vjzO1pgowfYOBZ/5YTeR63CVi9Yu0eAK9qC9vn4Ybmhotv+fFWCxTalm+Ic2H U5EA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PRwuStfZ; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32c as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com. [2a00:1450:4864:20::32c]) by gmr-mx.google.com with ESMTPS id h12si460884lfv.4.2021.11.25.22.33.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Nov 2021 22:33:25 -0800 (PST) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32c as permitted sender) client-ip=2a00:1450:4864:20::32c; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PRwuStfZ; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32c as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wm1-x32c.google.com with SMTP id c6-20020a05600c0ac600b0033c3aedd30aso6084840wmr.5 for ; Thu, 25 Nov 2021 22:33:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PkwSkaJOHzHzXu8FBL/hxthRpyNwrfH0KNlWnLJt++Q=; b=PRwuStfZtP/JuM7sERrMqHEVZt0MDNarIJEUWJMJbTOHyTOL+baHcva2W9hHGh/3bf G4OoXWNPn1DRnamph7wRrTMTS9Gp0IFrIkkLfEBN/Z+00j1i4/1my0o5A+54BWd9zBrB 8OCtcIkitXdbGVbAARLoUHYsW0fDQWrF3PUBj/ve07XP3vinJzeHebSoIrmdWhhPYGJs Ow0YhP/y6pSftordKCOvUMU50EhSrguOB7QjLJamnjQUqBvSfjWYA/Rq8R0J2Eq2dA9r btpR2xjC7b67ci+54ZnjvwRBqSjtA85A2z5qUl2CyEn/sj0YpRIb0mnLu1M//THVyLgS kqhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PkwSkaJOHzHzXu8FBL/hxthRpyNwrfH0KNlWnLJt++Q=; b=46ZhsBsrKtpsyJaIS0ArWDxeAnTN6wMBzctYKVW4aFj0aarlZdOcLKy0bx8TUz02EU WafVGNM4OfJCaJ1e5AuAo49cIgoFqdXAVIgI8LRW/L7ddkHKrAjeSu4mmAAzMtdvD8xY 6UFp5dYu9ETabZOIKpIbWUYKldeX/CbTey4VdUDK6f1PIcC+j29Z9e1ZXvWyhalbeTCF AE0iah2R89SNM9MUDy6DG0JBqogZGv+jEU7WhFDIW2hsGS8iW3nGWL8rk0qxktmgd/ob UzgazK5wkODGs7QjeDg+d7LZ1gC4MjADOwNB3KyzJoXReWCtJNyrUZ+MycqpleAzv4iL JwsA== X-Gm-Message-State: AOAM5333SvpN8vSBdWKWv1mKq4+NWatxvOQPOnaucs9HdhvfufhnOe9f +8mGxqa8mUhE+QEegYz71FZlud/piyjyUUVPR8c= X-Received: by 2002:a7b:ce16:: with SMTP id m22mr13207011wmc.137.1637908405373; Thu, 25 Nov 2021 22:33:25 -0800 (PST) MIME-Version: 1.0 References: <20211122152607.2125422-1-Vijaikumar_Kanagarajan@mentor.com> <20211122152607.2125422-4-Vijaikumar_Kanagarajan@mentor.com> <8319aef1-420a-034e-9152-b0c3c8c3536a@siemens.com> In-Reply-To: From: vijai kumar Date: Fri, 26 Nov 2021 12:03:14 +0530 Message-ID: Subject: Re: [PATCH v2 3/4] meta: u-boot: Prepare for newer versions To: Jan Kiszka Cc: Gylstorff Quirin , Vijai Kumar K , isar-users Content-Type: text/plain; charset="UTF-8" X-TUID: 33xDIxurJE/T On Fri, Nov 26, 2021 at 11:59 AM Jan Kiszka wrote: > > On 26.11.21 07:07, vijai kumar wrote: > > On Thu, Nov 25, 2021 at 10:04 PM Jan Kiszka wrote: > >> > >> On 25.11.21 17:27, vijai kumar wrote: > >>> On Thu, Nov 25, 2021 at 12:12 PM vijai kumar > >>> wrote: > >>>> > >>>> On Tue, Nov 23, 2021 at 3:24 PM Gylstorff Quirin > >>>> wrote: > >>>>> > >>>>> Hi, > >>>>> > >>>>> On 11/22/21 4:26 PM, Vijai Kumar K wrote: > >>>>>> Newer versions of u-boot require libssl-dev:native for compilation. > >>>>>> It also needs libssl-dev of the host architecture for cross compilation > >>>>>> of tools. > >>>>>> > >>>>>> Signed-off-by: Vijai Kumar K > >>>>>> --- > >>>>>> meta/recipes-bsp/u-boot/u-boot-custom.inc | 4 +++- > >>>>>> 1 file changed, 3 insertions(+), 1 deletion(-) > >>>>>> > >>>>>> diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc > >>>>>> index 5198809..cfae0e2 100644 > >>>>>> --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc > >>>>>> +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc > >>>>>> @@ -41,7 +41,9 @@ python() { > >>>>>> d.setVar('U_BOOT_BUILD_PROFILES_remove', "config") > >>>>>> } > >>>>>> > >>>>>> -DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git" > >>>>>> +DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, libssl-dev:native" > >>>>>> +DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' \ > >>>>>> + if bb.utils.contains('U_BOOT_BUILD_PROFILES', 'tools', 1, 0, d) else ''}" > >>>>> > >>>>> Is there are reason why you didn't use `Build-Depends syntax extension` > >>>>> from[1]? > >>>>> > >>>> Hi Quirin, > >>>> > >>>> Yes. There was. The previous version of patch depends on > >>>> ISAR_CROSS_COMPILE as well. > >>>> > >>>> Guess there is nothing stopping us now. But, wondering if we can start > >>>> introducing it via some > >>>> example app with some documentation so that basic users are not > >>>> puzzled on seeing that line in > >>>> a recipe. > >>>> > >>>> Also, we could define a whole new variable to help recipe writers to > >>>> define profiles and seamlessly > >>>> use them without the need to explicitly export DEB_BUILD_PROFILES in > >>>> the recipe's dpkg_runbuild > >>>> > >>>> Now that we are serious enough, we should probably take care of your > >>>> earlier comment > >>>> as well on following the standard. So that we don't conflict with > >>>> Debian's predefined variables in case > >>>> we decided to build a package fetched from apt:// and wanted to make > >>>> use of its profile settings. > >>>> > >>>> Still need to look further but these are my initial thoughts. I could > >>>> probably send some patches for review in > >>>> coming days. > >>>> > >>>> For now, maybe we should call it and use pkg.uboot.tools instead of > >>>> tools here so that we don't > >>>> find something in that implementation that requires us to change this > >>>> in future, possibly breaking > >>>> u-boot / or the need to provide compatibility. > >>>> > >>>> Thoughts? > >>> > >>> OTOH, This could still go in. Since the design I am thinking of is not > >>> finalized and might take some discussions in the list, there is no > >>> point in holding this back. > >>> > >> > >> I think Quirin was just asking for > >> > >> DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, \ > >> libssl-dev:native, libssl-dev " > >> > >> rather than using bitbake logic. If that also works, would be more elegant. > > > > Yes, that also works. But just a bit difficult to read for normal users. > > It's more Debian-style, thus to be preferred according to Isar principles. Ok. v3 coming up. It should be on the mailing list anytime now. Thanks, Vijai Kumar K > > Jan > > -- > Siemens AG, T RDA IOT > Corporate Competence Center Embedded Linux