From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7026294254479605760 X-Received: by 2002:a05:600c:4793:: with SMTP id k19mr1402731wmo.72.1637340863120; Fri, 19 Nov 2021 08:54:23 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:23c8:: with SMTP id j191ls208840wmj.1.gmail; Fri, 19 Nov 2021 08:54:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwZjycyoXyNQTPCZ7X0eTIeRp8tlfCu1qiHDvU/akjk68g830jM1PKGriv4FZnZPhgwPdPi X-Received: by 2002:a7b:c7cb:: with SMTP id z11mr1342351wmk.152.1637340862149; Fri, 19 Nov 2021 08:54:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637340862; cv=none; d=google.com; s=arc-20160816; b=wCNgH1H+z0R4jekzhTKAjiEJLJaEm9WdaiBSLpCQx5OOzsUK2QXU/hU7n2FHCr7uFB AYuCSl0wJ4Vyvv8suBmKGAboiOI4DpSI84MVzA7y0dyLO//b4+diY2KLQ+C0zZNBR+Dc 7r1P0PRyU8hgPds19vEojXuHcZWoUUKPRSWSxvATkE94leX8dEcWcEwwJQizVd2SDly1 lpCp1EHE3KqwW4pm5JWvqaF/RGJh3oohW7flaLfZkLbY6XXODTo1BnjzwGSGd968/tkm znJYdcq890JapIfVjcZr/w8JuRahM7lnQaTK36x8rqilRlCgfO5m13Hw4HzNnjrXqOgL cUxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=5XZwx2i9f9FQIaBbcUjhZ1SpxnGuCgVR0Umc83bu6kk=; b=RNCdPDOvX073fmZVe9/CkPz6X5eXH7cd6TFjSiPSuudPES0Kqyz/SVPCkWLEkqC00K s4k/Fieenm4Ii5e+7jKXzdJ1KTMa4ineHMlUktU9REQcv/d4e10Gp9531WWKOAyVDtmG 2a2MPn8fJ7nn+BORVZ3BDRyPNVr+vkVk6L4APxYGOuxi2trAcFj/DAvm1XFTm1qQDCjb WoLhmo9wwctTcVUrKIzb9kbi4jQMyT9RvXk4RCdzF7UtUfde+lDWqEmslm5+rOT+WZQO r95Amlwcb+s7n9c5hC8ljp6ZXxuzCwcPH52jUER+mHWK/izzXoMkUPAraIYVDTBAWLXh JENg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ehOO8AxN; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32b as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com. [2a00:1450:4864:20::32b]) by gmr-mx.google.com with ESMTPS id 201si16301wma.1.2021.11.19.08.54.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Nov 2021 08:54:22 -0800 (PST) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32b as permitted sender) client-ip=2a00:1450:4864:20::32b; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ehOO8AxN; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32b as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wm1-x32b.google.com with SMTP id p18so9083487wmq.5 for ; Fri, 19 Nov 2021 08:54:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5XZwx2i9f9FQIaBbcUjhZ1SpxnGuCgVR0Umc83bu6kk=; b=ehOO8AxNUKpShhzzH8rkIX9XAsmp0ypyTBOyFvVTZIg5DdYmfpY1SUHVzu1CaUC5A0 IdYFw1txA7u6DCINT1Nj5juGDWUX+GmYDTcrnplf7jQAhBmSC4Knv3x4BJshZZejWa2W ToVcm0SiokQFgEufxO8cK+YmQBSbs/hx1yg5HBhlH7ISSLlKF4CEXkAkbYMhc5kSsbUC VNWq+VLrcgKwrtFxHZieHPm5dvZwZdaFK57TH6gvPgMRXiBcUURY3IuTsX4Z+DAdath4 fkrJVcADoDgCqGOI8ZZpCxX1ugYhYfoWxQL3oxPyd0SP9XcK5xqM4p72OrHjMP0Uxhkn YRHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5XZwx2i9f9FQIaBbcUjhZ1SpxnGuCgVR0Umc83bu6kk=; b=nH8KwqY2+xbF0Cjb0JwX6HU45CF4+7AWYIoYTpz1obWwxAu3aNgLYqo7uS0u211snb tzHIbJNoxG7tSINeGRJSATU1fkzEcAriDpyJ+25juQd6q29/PfAkliFsfMKmRtJ3j2Cf +8pLdTd7ouKI0YqcSUdUWRTI2MNO82o9WTbm1AMN4cFtp7Ad4MUyvrZEvLntyXI66tf9 dlbfUTBavych3bf1IOjGguLO2r143bYhpQiQ04HvG6BsTGYSn0CYVow4WAzrFE5IKr0k hyDJO3p20WdZQS1UG6oJm7c9jtMNfvBoUfj17nlKUNhQlVCPsStbZDLbcDtYG27WGSRx yxbA== X-Gm-Message-State: AOAM531JatucMa49FYKq2NAvLEZAU2jDO7eKWDuy3KWKB7St3XS/LE00 GqNI9JJT5DU+xD/mo84ZIf6FLmfvDyg579WL++c= X-Received: by 2002:a05:600c:290b:: with SMTP id i11mr1244173wmd.137.1637340861818; Fri, 19 Nov 2021 08:54:21 -0800 (PST) MIME-Version: 1.0 References: <20211105061521.2142204-2-Vijaikumar_Kanagarajan@mentor.com> <20211106121203.3210294-1-Vijaikumar_Kanagarajan@mentor.com> <20211106121203.3210294-2-Vijaikumar_Kanagarajan@mentor.com> <07718b5f-1186-d912-419e-9dac134f9367@siemens.com> In-Reply-To: <07718b5f-1186-d912-419e-9dac134f9367@siemens.com> From: vijai kumar Date: Fri, 19 Nov 2021 22:24:11 +0530 Message-ID: Subject: Re: [PATCH v3 2/2] u-boot: Move libssl-dev dependency to u-boot-custom To: Jan Kiszka Cc: Vijai Kumar K , isar-users Content-Type: text/plain; charset="UTF-8" X-TUID: nJrQEYB7Hgqf On Tue, Nov 9, 2021 at 11:31 AM Jan Kiszka wrote: > > On 06.11.21 13:12, Vijai Kumar K wrote: > > Move the libssl-dependency to u-boot-custom.inc. > > > > Signed-off-by: Vijai Kumar K > > --- > > meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc | 3 --- > > meta/recipes-bsp/u-boot/u-boot-custom.inc | 4 +++- > > 2 files changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc b/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc > > index 158c297..f3f822a 100644 > > --- a/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc > > +++ b/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc > > @@ -5,9 +5,6 @@ > > > > require recipes-bsp/u-boot/u-boot-custom.inc > > > > -DEBIAN_BUILD_DEPENDS += ", libssl-dev:native" > > -DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if d.getVar('ISAR_CROSS_COMPILE') == '1' else ''}" > > - > > SRC_URI += " \ > > https://ftp.denx.de/pub/u-boot/u-boot-${PV}.tar.bz2 \ > > " > > diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc > > index 9984d8c..57d4f36 100644 > > --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc > > +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc > > @@ -24,7 +24,9 @@ python() { > > d.setVar('DEBIAN_BUILD_DEPENDS', d.getVar('BUILD_DEPENDS')) > > } > > > > -DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git" > > +DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, libssl-dev:native" > > +DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if d.getVar('ISAR_CROSS_COMPILE') == '1' else ''}" > > + > > It would feel more logical to me to put the :native part under the > cross-compile condition. The outcome will be the same, but :native is a > redundant statement in the native build case. Hi Jan, Sorry I thought I had replied to this. But it looks like not. >>From my testing, 1. libssl-dev:native is needed to build the u-boot image(bin). 2. libssl-dev of host(Debian) is needed only when we cross compile u-boot-tools. Even though the :native looks redundant, from the perspective of u-boot, it makes sense. Also, we now make it depend on cross-compile because tools are always built. If you see my patches on u-boot refactor[1], the libssl-dev inclusion will only take place in case we cross compile tools. (ISAR_CROSS_COMPILE == 1 && U_BOOT_TOOLS_PACKAGE = 1) [1]: https://groups.google.com/g/isar-users/c/RvvuZ5BRI0U/m/-m8u_mZMAQAJ Thanks, Vijai Kumar K > > Jan > > > > > TEMPLATE_FILES = "debian/control.tmpl" > > TEMPLATE_VARS += "MACHINE DEBIAN_BUILD_DEPENDS" > > > > -- > Siemens AG, T RDA IOT > Corporate Competence Center Embedded Linux > > -- > You received this message because you are subscribed to the Google Groups "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/07718b5f-1186-d912-419e-9dac134f9367%40siemens.com.