From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7044234567900725248 X-Received: by 2002:a2e:bc21:: with SMTP id b33mr85355ljf.497.1640120103162; Tue, 21 Dec 2021 12:55:03 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:5304:: with SMTP id c4ls12443lfh.3.gmail; Tue, 21 Dec 2021 12:55:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJxiRe4A4G1/65fAHlMDACsoLPIZx7RHlFS6pvQgtkUXR6zeYVJLg8RRNgUJf4bpV4jEsD7T X-Received: by 2002:ac2:5f53:: with SMTP id 19mr129672lfz.178.1640120101834; Tue, 21 Dec 2021 12:55:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1640120101; cv=none; d=google.com; s=arc-20160816; b=zEXo6mRBI1Ta9oxPsKnOMQNDCo8ZXa2u9vb8tcZpFYK6AxjtA5nkrtUZJwp6e7KNXN ANwcP7saIX6EsdXu1awzz5l+7WGG8hyBIgh7MQYDO08r9BLrK/Xmrgo2kHLvFLyEgi+K DF2W5VkhCCcw09i6E6ka97fCZTIfCyuOtogLe8M/UevLC/F5YcCGQOgAzD+pHdy/ZAnk lW8OW/3iChG3JtZjnG1Ek2DHLGkJ0e1o6IxZFiy8t3GAVLhlEm2LqutNfDeCai6HHOhP 0sA6WYJOrBp8BderYtKevQoEvEIza5RErjZumJl2dcU4LkLUUGjbJWcqtzoXpwjweZFO hd7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=JM9ryMPmFFh2Q5hbfHXyq4TnDN1F0pfxC9zoWOdCYlU=; b=tzC75QaJhB4yW2PzrgLz5uAapoeOM60Kk8aGJ6Yc67C158MGIb8YPkDHnuIAww2yM0 l+spIehRvY2WZQoblqmKDXG2ZHy6ePTfscv4z2ADFLUNt06ax6uciZt1OZNnu9SkvyVi kT12FByNrpIba0XQTNuGRTUFlzvs/lp3jFXpqIMdMH9fFN9Jo0ld/Yd8mv3+4Rb9zYCT cD9UcZlYJNT5bPgiptUb9GvFEqdMJ+sMDB4z9MIQ/c/8TWdZ1Vt0OchgSNkMEHHcVP3i 5jPmOIgpVyEl5FH/qSdRda0ssvEu/0OQ6OMzFMNpKrSg9RCg5S/7YgiCRtTKcunlL2Py cspQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Z2Jp3Y64; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32e as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com. [2a00:1450:4864:20::32e]) by gmr-mx.google.com with ESMTPS id l13si2977lfg.1.2021.12.21.12.55.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Dec 2021 12:55:01 -0800 (PST) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32e as permitted sender) client-ip=2a00:1450:4864:20::32e; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Z2Jp3Y64; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32e as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wm1-x32e.google.com with SMTP id j140-20020a1c2392000000b003399ae48f58so2542462wmj.5 for ; Tue, 21 Dec 2021 12:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JM9ryMPmFFh2Q5hbfHXyq4TnDN1F0pfxC9zoWOdCYlU=; b=Z2Jp3Y64PxbG/U2FuWz2AMUWdf9uEqkrtGfqn/cWzWkRbh3p4aVzM42BpdVHuo5bXK /JbCeG7S/pXe0IzGC+zYlwRfGjS6XbYxCLMNY5HEEsW9E3/H8O4PpKtJy5f56E+URxcT GNfvYsghq0HLQqf3idcUBwsi2cxij51wIsSozNQokgTASE8bLteuQFGOkwbtetcms50r YudLO9kSA95tFXmPVPZ6odE/pb7rJz7oZFcj6vJmErvRsr8XHqt5o7xUAuL70K0qrINf WXmkiwtcyWH3uQHsCrUJSlXgNq1cbjE8QyseTOf/Qy57Juc9evx1d+I7RtlI5wPz6WPe GUOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JM9ryMPmFFh2Q5hbfHXyq4TnDN1F0pfxC9zoWOdCYlU=; b=TXvCnzabZ3rvVbCDICHvieD/qdhAPum20ko4qryDqdkVVJ5yqERNdJuLhtTh/NVnM7 MD5GlU39brrg+wvkx53Iu6WzztNQqRNx4bnlf5EqOFoXU4o32PEQ0WsN9iwjLoICkdcr +1dZqcv2o560U0mdUZucvHKmUv8RpA6oSkFRuDHiJlv2DSlApOn4zpc1ZwqdTEEmOtg0 07b2G4ktYiMxjweYEeS/Qz8rbKV3pBfFJ9D6zxNMUczJUYspgYBpwbI1chXZxGei4J1R ZO/88U5Znr3Fdp8mr0RhDCfcNHXQBdSAyE7ErWS5VaYQejr3rFLHYXumdHwphxaiMtcD SRUA== X-Gm-Message-State: AOAM533m2nQORNw9s+Nvhqaxic60tHIYypRm7l+6C5JSuivQ1KhvDb+N 6ehpOGBWFVViokrHWbRS3/B4aN6Oro4xbG3EJ7RPPwux6Ys= X-Received: by 2002:a1c:9a8d:: with SMTP id c135mr21495wme.66.1640120101064; Tue, 21 Dec 2021 12:55:01 -0800 (PST) MIME-Version: 1.0 References: <20211221190653.1142246-1-felix.moessbauer@siemens.com> In-Reply-To: <20211221190653.1142246-1-felix.moessbauer@siemens.com> From: vijai kumar Date: Wed, 22 Dec 2021 02:24:49 +0530 Message-ID: Subject: Re: [PATCH 1/1] add support for debian build profiles To: Felix Moessbauer Cc: isar-users , Jan Kiszka Content-Type: text/plain; charset="UTF-8" X-TUID: ZD9D8fg78BY+ On Wed, Dec 22, 2021 at 12:37 AM Felix Moessbauer wrote: > > This patch adds the bitbake variables DEB_BUILD_PROFILES and > DEB_BUILD_PROFILES_CROSS. > The values of these variables are used to define the DEB_BUILD_PROFILES > environment variable. > > When cross-compiling, the DEB_BUILD_PROFILES_CROSS variable is defaulted > to "cross", to be consistent with upstream debian. > > Signed-off-by: Felix Moessbauer > --- > RECIPE-API-CHANGELOG.md | 8 ++++++++ > meta/classes/dpkg-base.bbclass | 12 ++++++++++++ > meta/classes/dpkg.bbclass | 5 ++--- > 3 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > index 55836258..f95f7db5 100644 > --- a/RECIPE-API-CHANGELOG.md > +++ b/RECIPE-API-CHANGELOG.md > @@ -306,3 +306,11 @@ When using the plugins it is advised to name the partition "/boot" and to exclud > > The variable is renamed to get closer to OE/Poky variables naming. The old naming > will still also work, but with deprecation warning shown. > + > +### Introduce debian build profiles > + > +All recipes that inherit from dpkg and dpkg-base can utilize the variables DEB_BUILD_PROFILES and DEB_BUILD_PROFILES_CROSS. > +These variables define the DEB_BUILD_PROFILES environment variable which is available in do_install_builddeps and do_dpkg_build. > +The DEB_BUILD_PROFILES_CROSS bitbake variable is set to "cross" when cross compiling. Hi Felix, Thank you for the patch. We could modify the u-boot recipe to have it as an example. Also, It might be useful if we can say something about custom profile names. Debian has a standard[1] for those. pkg.$sourcepackage.$anything Better to recommend users to follow it, to make sure they don't accidentally reuse one of the registered profile names when creating custom profiles. [1] https://wiki.debian.org/BuildProfileSpec > + > + > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > index 6704385b..c1588528 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -13,6 +13,8 @@ inherit deb-dl-dir > DEPENDS ?= "" > > DEPENDS_append_riscv64 = "${@' crossbuild-essential-riscv64' if d.getVar('ISAR_CROSS_COMPILE', True) == '1' and d.getVar('PN') != 'crossbuild-essential-riscv64' else ''}" > +DEB_BUILD_PROFILES ?= "" > +DEB_BUILD_PROFILES_CROSS ?= "cross" Do we really need two variables? Is the DEB_BUILD_PROFILES not sufficient? > > python do_adjust_git() { > import subprocess > @@ -201,7 +203,16 @@ dpkg_runbuild() { > die "This should never be called, overwrite it in your derived class" > } > > +def isar_export_build_profiles(d): > + import os > + deb_build_profiles = os.environ['DEB_BUILD_PROFILES'] if 'DEB_BUILD_PROFILES' in os.environ else '' Ideally the user should set DEB_BUILD_PROFILES in the recipe and the below line would be sufficient. > + deb_build_profiles += ' ' + d.getVar('DEB_BUILD_PROFILES', True) > + if d.getVar("ISAR_CROSS_COMPILE") == "1": > + deb_build_profiles += ' ' + d.getVar('DEB_BUILD_PROFILES_CROSS', True) Probably we can directly add "cross" and drop DEB_BUILD_PROFILES_CROSS > + os.environ['DEB_BUILD_PROFILES'] = deb_build_profiles.strip() > + > python do_dpkg_build() { > + isar_export_build_profiles(d) > lock = bb.utils.lockfile(d.getVar("REPO_ISAR_DIR") + "/isar.lock", > shared=True) > bb.build.exec_func("dpkg_do_mounts", d) > @@ -278,6 +289,7 @@ python do_devshell() { > bb.build.exec_func('dpkg_do_mounts', d) > > isar_export_proxies(d) > + isar_export_build_profiles(d) > > buildchroot = d.getVar('BUILDCHROOT_DIR') > pp_pps = os.path.join(d.getVar('PP'), d.getVar('PPS')) > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index 7da73341..8e5626e8 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -9,10 +9,9 @@ PACKAGE_ARCH ?= "${DISTRO_ARCH}" > do_install_builddeps() { > dpkg_do_mounts > E="${@ isar_export_proxies(d)}" > + E="${@ isar_export_build_profiles(d)}" > distro="${DISTRO}" > - if [ ${ISAR_CROSS_COMPILE} -eq 1 ]; then > - distro="${HOST_DISTRO}" > - fi Probably a mistake dropping the above lines? Thanks, Vijai Kumar K > + > deb_dl_dir_import "${BUILDCHROOT_DIR}" "${distro}" > sudo -E chroot ${BUILDCHROOT_DIR} /isar/deps.sh \ > ${PP}/${PPS} ${PACKAGE_ARCH} --download-only > -- > 2.30.2 > > -- > You received this message because you are subscribed to the Google Groups "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20211221190653.1142246-1-felix.moessbauer%40siemens.com.