Re: [RFC PATCH 2/2] meta/u-boot: Include libssl-dev only when building tools

[vijai kumar <vijaikumar.kanagarajan@gmail.com>]

On Mon, Nov 15, 2021 at 10:16 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
> On 15.11.21 17:06, Vijai Kumar K wrote:
> > libssl-dev of the host architecture is needed only when you
> > cross compile u-boot-tools.
>
> Did you mean "host" in the Gnu/Debian sense, i.e. the target (in Isar
> sense)? Or "build" - but that would mean ":native"?


Yes. host in Debian sense.

>
> >
> > Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> > ---
> >  meta/recipes-bsp/u-boot/u-boot-custom.inc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc
> > index bc92552..0887757 100644
> > --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc
> > +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc
> > @@ -25,7 +25,8 @@ python() {
> >  }
> >
> >  DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, libssl-dev:native"
> > -DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if d.getVar('ISAR_CROSS_COMPILE') == '1' else ''}"
> > +DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if (d.getVar('ISAR_CROSS_COMPILE') == '1' and \
> > +                     bb.utils.contains('U_BOOT_BUILD_PROFILES', 'tools', 1, 0, d)) else ''}"
> >
> >
> >  TEMPLATE_FILES = "debian/control.tmpl"
> >
>
> Code makes sense - I assume to tested with a very recent U-Boot and all
> profiles on.

Yes, tested with all profiles on. I will also push it through CI once.

Thanks,
Vijai Kumar K

>
> Jan
>
> --
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux
>
> --
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/6d5763b1-97a5-390c-91b9-1e0a89b1da4f%40siemens.com.