From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7033292862949163008 X-Received: by 2002:a7b:ca54:: with SMTP id m20mr13322264wml.21.1637909779120; Thu, 25 Nov 2021 22:56:19 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:770f:: with SMTP id t15ls2540961wmi.3.gmail; Thu, 25 Nov 2021 22:56:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJwHlAf2F0FE8LkPlMNFNPq7gQi8Pl72qpyYYEu8INwt37XY6Ul4/33bNdnfgyYeK7mmhj1A X-Received: by 2002:a05:600c:3510:: with SMTP id h16mr13327178wmq.144.1637909778210; Thu, 25 Nov 2021 22:56:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637909778; cv=none; d=google.com; s=arc-20160816; b=aPn40WkfJkzBWuqbaweDDDaPWVvc1VdlDkTzdepCe16A7Krh/esP9MuiimJ5QAMq4m MCnu9Uwm1EGGdSOMVihDtiZS0+BjpNUchiUgkgNeEocPOqLbA2M04VtXxxwmRZFlumr4 PkIpg/tUjsDrqCjlUXQDgwr0o2ExvUVcIZ+ZdF11CZkXD4cpWVYszBEL8ha8aDhp4cli O3K+rvVlMvHuorLeBedo1KXAe9OEY4inApzUG2WPfaGS/TDrW8O2bFQnRMWhSW0IS+jN OSC3gjC10QH0rbKEW3Y8AFY6kN4GuGBCJPVhccCsQnxLqY5lfczUJanV7UPvGWdoT55S mPow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=Z4HbT2CKohpDRMTnKbtOde4Fvuter7bgBWv+AB/T2aM=; b=DYMUYUrJHJVanfPutUwKp6KCjjXHEGhExZo51H+jsy0p9WKcV1rLvgYLigADz+2h0I GkfGpl2Rm/Xf5LMYSSGdzyBmLIHmlfIkjyJlVcdqGGuV9VFTEQHsaXnpeaXZ9GGWnpaG R6LcG2f3OPZTzKNBBMCRWZnYCazBpM+Snk+w0qX90Dlvc09UbIcGmgvB7uuiH0J121N8 ie9D3oq8f4PoCYguMig67D9yA/xOZHCMoA6Oj7RRR2cTm63CYzyd3bylLIFYn8CGN/Uq LLw9HdvUxzZcoci69c/zWqpbA219vjPH5E946UGmMZO+DuvjndzD/uY5KVHyhAVyqyey 3Snw== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="Utdg6D/f"; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32c as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com. [2a00:1450:4864:20::32c]) by gmr-mx.google.com with ESMTPS id o29si939435wms.1.2021.11.25.22.56.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Nov 2021 22:56:18 -0800 (PST) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32c as permitted sender) client-ip=2a00:1450:4864:20::32c; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="Utdg6D/f"; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32c as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wm1-x32c.google.com with SMTP id o29so7273934wms.2 for ; Thu, 25 Nov 2021 22:56:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z4HbT2CKohpDRMTnKbtOde4Fvuter7bgBWv+AB/T2aM=; b=Utdg6D/fn5Amap+SHjrk6dFBX3LZ75GmgvYMX61jAoRP9J0/gJlWr11KHm+qDPPBri 6yxc2MBjKM4gm1kWBKsuENgpXOpmXx2Ls6YEhHufCxRWxKyjJAg8qmy5vLQyJavvby6+ SA5e47QHis9aq6bTK8HBvihMTSix6f2ZK81HrXNGgcRAmNaHorDdapnx9tkoDFAui2J+ Frsves7PPl8FVKhVv5CVQXR2NQxOBIJgFJBU7sX9FV5MfciL4BnL69xzA3c+gtLywu3k I8sQE2hzNpaKKGuo4n8MybXFcCpHeq+adAQhl+LnoYB/onH7PMv9Dejhnas4VA6mdAiI GzBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z4HbT2CKohpDRMTnKbtOde4Fvuter7bgBWv+AB/T2aM=; b=DNgR+cjyg6ASr/3OP3y2oYAoPjbeSxdZf03400NeAtk+UH6jR6g3q4jiLrHotSe0MN u+ljfTLDZFowZEATBjYUMvaVKMvyr4xH0CYbudJ3ZbrPsTOj9QsNlWNWjO2QSGuJM69O yzoMsy6ThuZHCk0Wf55XKuLT4OM5dJGKy15TGECazHUU0DuH31Sdwxoa4m1xpwlOUnQB YDbdWU8UuA6l6FoBnI767fU41Nbm5Z/CqNG2KAuVbz04kYSLxoKJwA5PFmj8LVlCc3lx 6xYZl4arBul2LZFbI5Ajwaw6eoCsGSpGBAXivfG29RSJywQngyyNkJ+YTYcs+Ew/O9io 2pHA== X-Gm-Message-State: AOAM530PL91s9N6Y1HjvlEZJfWbupvw8eC7g8eWqMvh+/d97xrhfGbX5 8RTClu1wFC9IQR0LXNqhJUb7lFzy8MbK9jJF9Js= X-Received: by 2002:a1c:8002:: with SMTP id b2mr13579165wmd.2.1637909777834; Thu, 25 Nov 2021 22:56:17 -0800 (PST) MIME-Version: 1.0 References: <20211122152607.2125422-1-Vijaikumar_Kanagarajan@mentor.com> <20211122152607.2125422-4-Vijaikumar_Kanagarajan@mentor.com> <8319aef1-420a-034e-9152-b0c3c8c3536a@siemens.com> In-Reply-To: From: vijai kumar Date: Fri, 26 Nov 2021 12:26:07 +0530 Message-ID: Subject: Re: [PATCH v2 3/4] meta: u-boot: Prepare for newer versions To: Jan Kiszka Cc: Gylstorff Quirin , Vijai Kumar K , isar-users Content-Type: text/plain; charset="UTF-8" X-TUID: xh45zVjPfUao On Fri, Nov 26, 2021 at 11:37 AM vijai kumar wrote: > > On Thu, Nov 25, 2021 at 10:04 PM Jan Kiszka wrote: > > > > On 25.11.21 17:27, vijai kumar wrote: > > > On Thu, Nov 25, 2021 at 12:12 PM vijai kumar > > > wrote: > > >> > > >> On Tue, Nov 23, 2021 at 3:24 PM Gylstorff Quirin > > >> wrote: > > >>> > > >>> Hi, > > >>> > > >>> On 11/22/21 4:26 PM, Vijai Kumar K wrote: > > >>>> Newer versions of u-boot require libssl-dev:native for compilation. > > >>>> It also needs libssl-dev of the host architecture for cross compilation > > >>>> of tools. > > >>>> > > >>>> Signed-off-by: Vijai Kumar K > > >>>> --- > > >>>> meta/recipes-bsp/u-boot/u-boot-custom.inc | 4 +++- > > >>>> 1 file changed, 3 insertions(+), 1 deletion(-) > > >>>> > > >>>> diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc > > >>>> index 5198809..cfae0e2 100644 > > >>>> --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc > > >>>> +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc > > >>>> @@ -41,7 +41,9 @@ python() { > > >>>> d.setVar('U_BOOT_BUILD_PROFILES_remove', "config") > > >>>> } > > >>>> > > >>>> -DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git" > > >>>> +DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, libssl-dev:native" > > >>>> +DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' \ > > >>>> + if bb.utils.contains('U_BOOT_BUILD_PROFILES', 'tools', 1, 0, d) else ''}" > > >>> > > >>> Is there are reason why you didn't use `Build-Depends syntax extension` > > >>> from[1]? > > >>> > > >> Hi Quirin, > > >> > > >> Yes. There was. The previous version of patch depends on > > >> ISAR_CROSS_COMPILE as well. > > >> > > >> Guess there is nothing stopping us now. But, wondering if we can start > > >> introducing it via some > > >> example app with some documentation so that basic users are not > > >> puzzled on seeing that line in > > >> a recipe. > > >> > > >> Also, we could define a whole new variable to help recipe writers to > > >> define profiles and seamlessly > > >> use them without the need to explicitly export DEB_BUILD_PROFILES in > > >> the recipe's dpkg_runbuild > > >> > > >> Now that we are serious enough, we should probably take care of your > > >> earlier comment > > >> as well on following the standard. So that we don't conflict with > > >> Debian's predefined variables in case > > >> we decided to build a package fetched from apt:// and wanted to make > > >> use of its profile settings. > > >> > > >> Still need to look further but these are my initial thoughts. I could > > >> probably send some patches for review in > > >> coming days. > > >> > > >> For now, maybe we should call it and use pkg.uboot.tools instead of > > >> tools here so that we don't > > >> find something in that implementation that requires us to change this > > >> in future, possibly breaking > > >> u-boot / or the need to provide compatibility. > > >> > > >> Thoughts? > > > > > > OTOH, This could still go in. Since the design I am thinking of is not > > > finalized and might take some discussions in the list, there is no > > > point in holding this back. > > > > > > > I think Quirin was just asking for > > > > DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, \ > > libssl-dev:native, libssl-dev " > > > > rather than using bitbake logic. If that also works, would be more elegant. > > Yes, that also works. But just a bit difficult to read for normal users. No. False positive. Just did a build after cleaning buildchroot. It doesnot work as expected. I will look into it when I start working on the DEB_BUILD_PROFILES framework. I hope I can spend time doing that. Fingers crossed. Thanks, Vijai Kumar K > > A framework for DEB_BUILD_PROFILES for isar would be helpful I guess, > like I mentioned above. > Will see if I can convert my thoughts to some patches sometime soon. > > Thanks, > VIjai Kumar K > > > > > Jan > > > > -- > > Siemens AG, T RDA IOT > > Corporate Competence Center Embedded Linux