From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6805226701613694976 X-Received: by 2002:a25:d7c8:: with SMTP id o191mr6032791ybg.473.1584536594102; Wed, 18 Mar 2020 06:03:14 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a25:7644:: with SMTP id r65ls4389926ybc.1.gmail; Wed, 18 Mar 2020 06:03:13 -0700 (PDT) X-Google-Smtp-Source: ADFU+vu3sC2N7YiaXht2Wj5tXQVNFIUw+3cskUTUTiWwwFWP+KB/lcRpdQlh8jJk3vam/+F5vyNS X-Received: by 2002:a25:5b08:: with SMTP id p8mr6517604ybb.446.1584536593658; Wed, 18 Mar 2020 06:03:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584536593; cv=none; d=google.com; s=arc-20160816; b=BlHdlPIbHIjSYpKFNbTaHLkYaV0LSA6vkYoTZrJMPv1a8VJlWyzZwMN96tDSBaV786 WKxnA+Jz10Ep+7iC4PMaUod7cT0Ug+lVZY4wq/GdMx+RIInGL75Fo4RbG4aMYgfzNwxK 3d80cXoKgTNuCA9MaM4eJnTlQHL9SPdpr0Dld88z4jyQTptBxqXYI0SbXtezf+Wu90Wm T4EZVZ6X198DoFFHrh2qgfXOCS0nEHolOhIckp3YHXwSx+Xn5f8GFBbgyd8qXi0VaQ7J LyoekWmwW3FIG92Kl4DCPK+G1Px6zhaVUhhv3LVvExXVVJwyqJb3p6WDx3S5YArd2rTl ONTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=CdsuNrRpIDZeSgJM3ChUmi/Im6uhlf4ctfH0bj+7isc=; b=e70GiUxHELT1J/pt/fLrtA+51icNt5VZO6kX4nqOEcjz+uzN2CO9zO6Xilv1L/sBNE OiK0jL4FdOCw7Kd4tx9jF0d2+4wf+YZISD977Nh8+LfccvnZ9u9L8ZNvooWo8ouFXmSm eSty4drkb02vUH0IC0k+zvBGeSsHQd62bdHSaxM849KBE5n6Y1gOBCsOZUri0Ee8GZkT LdsN++hv0K3mgNJCzwSRW1RxaVwM/MvmrIfLmYHGyXveCDOiNMQU7F06UZMGh45C3IFY 1HJkPhHEZtx85iw0Kud+x20BJopRWQraWSAsUM8Xv2DhQYTEqwdj2d/p0E/AQ/RMOOsX zslA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qY8wVLVh; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2607:f8b0:4864:20::742 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com. [2607:f8b0:4864:20::742]) by gmr-mx.google.com with ESMTPS id x13si586545ybs.4.2020.03.18.06.03.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2020 06:03:13 -0700 (PDT) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2607:f8b0:4864:20::742 as permitted sender) client-ip=2607:f8b0:4864:20::742; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qY8wVLVh; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2607:f8b0:4864:20::742 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qk1-x742.google.com with SMTP id x18so18303648qki.10 for ; Wed, 18 Mar 2020 06:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CdsuNrRpIDZeSgJM3ChUmi/Im6uhlf4ctfH0bj+7isc=; b=qY8wVLVhUG4kOeosCaTcQMzA1qjcVhWl+Ee8yhY0R/HjmtJoQecKkn4UWk7F+n+CbQ SJCTgs7/5TEYsftKWvdQhk4Xr10jVDDt04bHsgLknXdV1Rq5E9FltSNYcECYDmASi5xI COVTMa9Q5Ixje2mswtTR3FoTEYOz/s3Z2M0+tZlqa4h2+meRCeD1tVWdcvCU9nzbUiF5 nUPV1u4X7onR5V/eGT9aAB+KLYKFTAxtZ2RYXpXJ6L5BRO3iuVP/6ir019r52NV4JQLS kFtpJ9T2bd7QfWhcEYwY+xeItYDsF4C1MKx0EitJ6gfHKr26JgCO0utp/7NvAsLcILF6 Z1jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CdsuNrRpIDZeSgJM3ChUmi/Im6uhlf4ctfH0bj+7isc=; b=icaRv+FeezBrl4KMxPy24BdmIPyD2pgB1OYch/i84muIu+iqom/Fh5kfPqrtRhwlbb 33REDIyUSGiIf4TJoxPdgag2mID7+w+D9HIbnCbIDH8jxfuywlCa6e5MUOSVebnN4z3R gjXq7fXsWd/1lBxi2cYLBN3PreOCj8yO8yFUR6tsdGfnUy68Iv1bUhuYGhCb31tb5MBE nEKymlVF0qbkrj0XZRM1h8r7z0dmYXp7D/LzH8HZBk4Oyiu3PAv1iT3LedhbFBPtsHmA VaJgXS2DK0339ko6d301ZefDkWGOTdTiDruLaG2dTcXwHAowjxG6amxMoIOg794fpS3p sEZg== X-Gm-Message-State: ANhLgQ2QksOUsCk9+iyt9fL0hGtYdiJ7+wNWMw0fH9Py7RQKPNqLwjRT vnOzvLzczaUhkKGwfQK/cpSNNTXXo05r6u47tuA= X-Received: by 2002:a37:6455:: with SMTP id y82mr3916662qkb.286.1584536593268; Wed, 18 Mar 2020 06:03:13 -0700 (PDT) MIME-Version: 1.0 References: <20200317171455.17840-1-Vijaikumar_Kanagarajan@mentor.com> <20200318083443.57bfb489@md1za8fc.ad001.siemens.net> In-Reply-To: <20200318083443.57bfb489@md1za8fc.ad001.siemens.net> From: vijai kumar Date: Wed, 18 Mar 2020 18:33:05 +0530 Message-ID: Subject: Re: [PATCH] linux-custom: Install config and map file to /boot To: Henning Schild Cc: Jan Kiszka , isar-users , Vijai Kumar K Content-Type: text/plain; charset="UTF-8" X-TUID: +LS0Ade0DGlV On Wed, Mar 18, 2020 at 1:04 PM Henning Schild wrote: > > On Wed, 18 Mar 2020 11:23:24 +0530 > vijai kumar wrote: > > > On Tue, Mar 17, 2020 at 11:02 PM Jan Kiszka > > wrote: > > > > > > On 17.03.20 18:14, Vijai Kumar K wrote: > > > > Align with upstream debian linux-image package. Install the > > > > config and System.map file to /boot directory. Skip installation > > > > for User Mode Linux. > > > > > > > > Signed-off-by: Vijai Kumar K > > > > --- > > > > .../linux/files/debian/isar/install.tmpl | 14 > > > > ++++++++++++++ 1 file changed, 14 insertions(+) > > > > > > > > diff --git > > > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index > > > > 12d592d..4e1f850 100644 --- > > > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > > > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ > > > > -37,6 +37,8 @@ do_install() { set -x > > > > > > > > install_image > > Looks like the "um" guard could move here to only have it once. Yes. It could. I will send a v2. > > > > > + install_config > > > > + install_map > > > > install_hooks > > > > install_dtbs > > > > install_kmods > > > > @@ -69,6 +71,18 @@ install_image() { > > > > install_image_debug > > > > } > > > > > > > > +install_config() { > > > > + if [ "${ARCH}" != "um" ]; then > > > > + cp ${O}/.config ${deb_img_dir}/$(dirname > > > > ${kimage_path})/config-${krel} > > > > + fi > > > > +} > > > > + > > > > +install_map() { > > > > + if [ "${ARCH}" != "um" ]; then > > > > + cp ${O}/System.map ${deb_img_dir}/$(dirname > > > > ${kimage_path})/System.map-${krel} > > > > + fi > > > > +} > > > > + > > > > install_image_debug() { > > > > # Different tools want the image in different locations > > > > # perf > > > > > > > > > > I think this should be made configurable. Not every embedded system > > > may need or even want these. Can be on be default nevertheless, > > > specifically if that is Debian behavior. > > > > Sure. I believe that can be investigated and done as a separate patch. > > We are now trying to match the contents wrt Debian upstream/ the > > previous Linux build procedure as some of our downstream test cases > > rely on the config file in /boot. > > If the system under test has CONFIG_IKCONFIG_PROC and is running the > kernel, /proc/config.gz is probably the better source. > For the config i really do not see a point to not ship it, its not too > big. Some security gurus might argue that they do not want to ship it > for obfuscation ... but i would not listen to them. This is something we are considering. For now, we are relying on /boot/config*. I believe boards supported in CIP already have these configs enabled. So it should not be a problem for us to enable it for our boards too. Thanks, Vijai Kumar K > > I think your test should try /proc /boot and finally skip the test > instead of fail it ;). > > Henning > > > Thanks, > > Vijai Kumar K > > > > > > > > That said, we may also look into shrinking the dtb installations, > > > only packaging what the target actually needs. Unrelated to this > > > patch, for sure. > > > > > > Jan > > > > > > -- > > > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > > > Corporate Competence Center Embedded Linux > > >