From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7026294254479605760 X-Received: by 2002:a05:600c:4113:: with SMTP id j19mr27973583wmi.48.1637563065220; Sun, 21 Nov 2021 22:37:45 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:f1c2:: with SMTP id z2ls172534wro.2.gmail; Sun, 21 Nov 2021 22:37:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJxKXzH5OdZgwoSok1JaFiuoXS3FuEk6x/lVgNasvgyH9WRmymBgPYK3czELmQlA+BF+eajt X-Received: by 2002:adf:e904:: with SMTP id f4mr35582785wrm.245.1637563064225; Sun, 21 Nov 2021 22:37:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637563064; cv=none; d=google.com; s=arc-20160816; b=jQHtv6/HX+HZ10AYUrfrQnyoU38uDaXWdGs6rOZR1iVbIwBuuVYQQYBsmWQHSSx04L G6si4youaxPHyDS4wC8aWgOEXQ1CYy5WE1uvduWzx0LLhfMe30C3465hZj70YeVDnCdu Or1GvfvWjQko1xir2AszaL3007AHQE+vZpbkid+HnT2iK0J/Eup9bVLog9sX0HeMXDQn w16ToD4ZVRF/+TDA2MkceW3KK/0mgCMW5Kl8RbdmOoEuxqEBcR5gfanENBrixS0hNGZX nn1wO3DGG1wNrri9LG1TX6uFJXvKcJ3UzVZhGHQAxpImY3iRbZq0JdKPv3LTnAuPRVrc ixwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=ch4qwVjpkkFnDnV7IbSPv31BOyKzm4aam33QEglk2tY=; b=g4SjinBRkl67ZxUpfilX4nEDDsJXUYQ7LUAO+D10b0CsSFKj1JqMyDtI2VsFy1qrjg e261mIwdSuAC2bSEk44Lv2V0S/d9ZMXBJc9SEIqwxnE2n0/dR6s6CyPyBDxDlgq5SAdQ 4ExEKViScPd0Z8tXeLKE2VZ5g4qhG5BmfmTzXPzr214bp/grEdYPGNaHgYt1n6G9rqFN FM+PpuWSALgW3oQkB7cV88OoO4KNj6sRiO0/LVHnJhh4WXFGniq5cwv13BWvnw6fLQrR jKH5qCIoUb1pmXPw3bEwTgPHXr9FXhIXxWHegosJIkIFMv0EaoxCBmazSTYqgB/wLegm yy3A== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=GoycdDzd; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32c as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com. [2a00:1450:4864:20::32c]) by gmr-mx.google.com with ESMTPS id e18si387917wra.2.2021.11.21.22.37.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Nov 2021 22:37:44 -0800 (PST) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32c as permitted sender) client-ip=2a00:1450:4864:20::32c; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=GoycdDzd; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::32c as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wm1-x32c.google.com with SMTP id 133so14271769wme.0 for ; Sun, 21 Nov 2021 22:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ch4qwVjpkkFnDnV7IbSPv31BOyKzm4aam33QEglk2tY=; b=GoycdDzdePcb5eWSiOqhYGG8O3GPcjjL5md/edjEDFNC34YfMh6r+nsd1JyEsdgQJP JZG+aZTTUVPSdgozThWn8mcM4zlFAHyT+m8qmpCF33ZT7JFGknY/SJNjeujJ5zCTgPmY AZI0obW9UyxQMfxQqx4AmThYwprmoIaOtvTd3HujrfkN9I2FWCOQWDC/zLeD8BGMD0g3 dqi0+rsTuAFVNNsxWFjj5vPmuitRoaj6bLp9qV4frV3ZAZaYrQKgbZbun1lCg/zUftfj Oyxjr1kaU5ml8I6iGvrSN3oAFLHd3YlUiB0zX1ilNf+oV2E/B+J2+J23HYpiQ2LhyVWO JCFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ch4qwVjpkkFnDnV7IbSPv31BOyKzm4aam33QEglk2tY=; b=r1irRYE6EZXtkq/ME3oS5UwDIfuP/Q/Pb43l9sSxEexEtJ9w53u5jOelANshj44riD TmpQHwaeLtZcZMnMUb+iOKWpCtF1nU32nwiOE8RM5zEmGlfsucpYetLAxJJOEL/27E8O ynCg4rk5eW2F3NXMNWwWsgTQMgymwOn2ZK7tneUMQRl2kE/Mg71hg77hkQKX5R0xz+qD FFdbLf0ic2D2Abbr3DFIdnA5xGZ9X8hSWrii0a1BuXsN+qVEuXb9w3wwd2buK/jSYbti KB2DvO+zVHMPmF1g7Z9b6oa5jse93xf1qGxghNuQguB+ro/qOL981TfhkNhVtHNQIx4e oA7Q== X-Gm-Message-State: AOAM531zoovImxqopnrzWPXuoCfWgogzM2MyFRq9hnn8k6scBWYiT5zQ +CHk7Oe3wVLyfXYx2dGZpA7oXC7Kt0VFCRp+AAcGbABl X-Received: by 2002:a05:600c:21cd:: with SMTP id x13mr27190578wmj.52.1637563063776; Sun, 21 Nov 2021 22:37:43 -0800 (PST) MIME-Version: 1.0 References: <20211105061521.2142204-2-Vijaikumar_Kanagarajan@mentor.com> <20211106121203.3210294-1-Vijaikumar_Kanagarajan@mentor.com> <20211106121203.3210294-2-Vijaikumar_Kanagarajan@mentor.com> <07718b5f-1186-d912-419e-9dac134f9367@siemens.com> In-Reply-To: From: vijai kumar Date: Mon, 22 Nov 2021 12:07:32 +0530 Message-ID: Subject: Re: [PATCH v3 2/2] u-boot: Move libssl-dev dependency to u-boot-custom To: Jan Kiszka Cc: Vijai Kumar K , isar-users Content-Type: text/plain; charset="UTF-8" X-TUID: GdUas3kwMHhY On Mon, Nov 22, 2021 at 11:50 AM Jan Kiszka wrote: > > On 19.11.21 17:54, vijai kumar wrote: > > On Tue, Nov 9, 2021 at 11:31 AM Jan Kiszka wrote: > >> > >> On 06.11.21 13:12, Vijai Kumar K wrote: > >>> Move the libssl-dependency to u-boot-custom.inc. > >>> > >>> Signed-off-by: Vijai Kumar K > >>> --- > >>> meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc | 3 --- > >>> meta/recipes-bsp/u-boot/u-boot-custom.inc | 4 +++- > >>> 2 files changed, 3 insertions(+), 4 deletions(-) > >>> > >>> diff --git a/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc b/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc > >>> index 158c297..f3f822a 100644 > >>> --- a/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc > >>> +++ b/meta-isar/recipes-bsp/u-boot/u-boot-2021.10.inc > >>> @@ -5,9 +5,6 @@ > >>> > >>> require recipes-bsp/u-boot/u-boot-custom.inc > >>> > >>> -DEBIAN_BUILD_DEPENDS += ", libssl-dev:native" > >>> -DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if d.getVar('ISAR_CROSS_COMPILE') == '1' else ''}" > >>> - > >>> SRC_URI += " \ > >>> https://ftp.denx.de/pub/u-boot/u-boot-${PV}.tar.bz2 \ > >>> " > >>> diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc > >>> index 9984d8c..57d4f36 100644 > >>> --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc > >>> +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc > >>> @@ -24,7 +24,9 @@ python() { > >>> d.setVar('DEBIAN_BUILD_DEPENDS', d.getVar('BUILD_DEPENDS')) > >>> } > >>> > >>> -DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git" > >>> +DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, libssl-dev:native" > >>> +DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if d.getVar('ISAR_CROSS_COMPILE') == '1' else ''}" > >>> + > >> > >> It would feel more logical to me to put the :native part under the > >> cross-compile condition. The outcome will be the same, but :native is a > >> redundant statement in the native build case. > > > > Hi Jan, > > > > Sorry I thought I had replied to this. But it looks like not. > > > > From my testing, > > 1. libssl-dev:native is needed to build the u-boot image(bin). > > 2. libssl-dev of host(Debian) is needed only when we cross compile u-boot-tools. > > > > Even though the :native looks redundant, from the perspective of > > u-boot, it makes sense. > > Also, we now make it depend on cross-compile because tools are always built. > > > > If you see my patches on u-boot refactor[1], the libssl-dev inclusion > > will only take place in case we cross > > compile tools. (ISAR_CROSS_COMPILE == 1 && U_BOOT_TOOLS_PACKAGE = 1) > > > > [1]: https://groups.google.com/g/isar-users/c/RvvuZ5BRI0U/m/-m8u_mZMAQAJ > > > > Well, thinking about this again, the best way would be to only make this > dependent on whether we are building tools or not. The cross-compile > dependency is just unneeded, will not save any installation in practice > because non-cross means libssl-dev:native == libssl-dev. I will club the series with DEB_BUILD_PROFILES series and make sure we bring the latter first so that we can drop this cross compile dependency smoothly. Thanks, Vijai Kumar K > > Jan > > -- > Siemens AG, T RDA IOT > Corporate Competence Center Embedded Linux