public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: vijai kumar <vijaikumar.kanagarajan@gmail.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>,
	 isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH v2 1/2] u-boot: Switch to use DEB_BUILD_PROFILES
Date: Wed, 17 Nov 2021 11:26:45 +0530	[thread overview]
Message-ID: <CALLGG_JmFQ2ju4F-Tq2vOnUANYQi1brb35sLd+TRMeCojSWeLw@mail.gmail.com> (raw)
In-Reply-To: <2b8f8f63-a38e-c79a-8094-c651f4753b2e@siemens.com>

On Tue, Nov 16, 2021 at 9:10 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
> On 16.11.21 10:51, Vijai Kumar K wrote:
> > Use DEB_BUILD_PROFILES to select packages to build.
> >
> > This patch drops the U_BOOT_TOOLS_PACKAGE variable and introduces
> > U_BOOT_BUILD_PROFILES through which we can enable particular
> > packages like u-boot-tools and u-boot-dev.
> >
> > Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> > ---
> >  .../u-boot/u-boot-de0-nano-soc_2021.10.bb     |  2 +-
> >  .../u-boot/files/debian/control.tmpl          | 13 +++++++
> >  meta/recipes-bsp/u-boot/files/debian/rules    |  9 ++++-
> >  meta/recipes-bsp/u-boot/u-boot-custom.inc     | 38 +++++++------------
> >  4 files changed, 35 insertions(+), 27 deletions(-)
> >
> > diff --git a/meta-isar/recipes-bsp/u-boot/u-boot-de0-nano-soc_2021.10.bb b/meta-isar/recipes-bsp/u-boot/u-boot-de0-nano-soc_2021.10.bb
> > index dcb76c5..640b7ea 100644
> > --- a/meta-isar/recipes-bsp/u-boot/u-boot-de0-nano-soc_2021.10.bb
> > +++ b/meta-isar/recipes-bsp/u-boot/u-boot-de0-nano-soc_2021.10.bb
> > @@ -6,4 +6,4 @@
> >  require u-boot-${PV}.inc
> >
> >  # Just for testing purposes, distro package would be recent enough
> > -U_BOOT_TOOLS_PACKAGE = "1"
> > +U_BOOT_BUILD_PROFILES += "tools"
>
> Recipe-API change, needs to be documented. Ideally: Provide a compat
> solution, translating the old switch into the new one, issuing a warning
> about the recommended conversion.

Ok. Looking back it might silently break downstream layers.

Will address it in v3.

Thanks,
Vijai Kumar K

>
> Jan
>
> --
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux
>
> --
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/2b8f8f63-a38e-c79a-8094-c651f4753b2e%40siemens.com.

  reply	other threads:[~2021-11-17  5:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15 16:06 [RFC PATCH 0/2] U-boot refactor Vijai Kumar K
2021-11-15 16:06 ` [RFC PATCH 1/2] u-boot: Switch to use DEB_BUILD_PROFILES Vijai Kumar K
2021-11-15 16:44   ` Jan Kiszka
2021-11-16  8:42     ` vijai kumar
2021-11-16 15:02   ` Gylstorff Quirin
2021-11-17  5:52     ` vijai kumar
2021-11-15 16:06 ` [RFC PATCH 2/2] meta/u-boot: Include libssl-dev only when building tools Vijai Kumar K
2021-11-15 16:46   ` Jan Kiszka
2021-11-16  8:44     ` vijai kumar
2021-11-15 16:10 ` [RFC PATCH 0/2] U-boot refactor vijai kumar
2021-11-16  9:51 ` [PATCH v2 " Vijai Kumar K
2021-11-16  9:51   ` [PATCH v2 1/2] u-boot: Switch to use DEB_BUILD_PROFILES Vijai Kumar K
2021-11-16 15:40     ` Jan Kiszka
2021-11-17  5:56       ` vijai kumar [this message]
2021-11-16  9:51   ` [PATCH v2 2/2] meta/u-boot: Include libssl-dev only when building tools Vijai Kumar K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALLGG_JmFQ2ju4F-Tq2vOnUANYQi1brb35sLd+TRMeCojSWeLw@mail.gmail.com \
    --to=vijaikumar.kanagarajan@gmail.com \
    --cc=Vijaikumar_Kanagarajan@mentor.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox