Re: [RFC PATCH] image: Reorder do_copy_boot_files task

[vijai kumar <vijaikumar.kanagarajan@gmail.com>]

Hi All,

On Fri, Feb 18, 2022 at 3:24 PM Vijai Kumar K
<Vijaikumar_Kanagarajan@mentor.com> wrote:
>
> There might be cases where in there are some initramfs changes in postprocess.
> For example, via the distro config script.
>
> In such a scenario we would have an outdated initramfs file in deploy directory.
> Certain downstream Wic plugins directly consume the image from deploy directory.
> It then uses the outdated initramfs for creating the wic image.
>
> Copy boot files after rootfs postprocess but before finalizing the
> rootfs.

Any comments on this?

Thanks,
Vijai Kumar K

>
> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> ---
>  RECIPE-API-CHANGELOG.md    | 7 ++++++-
>  meta/classes/image.bbclass | 2 +-
>  2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
> index cad15a8..ef53b1a 100644
> --- a/RECIPE-API-CHANGELOG.md
> +++ b/RECIPE-API-CHANGELOG.md
> @@ -342,4 +342,9 @@ The bitbake variable defines the respective environment variable which is availa
>  When cross compiling, `cross` is added to the `DEB_BUILD_PROFILES` environment variable.
>  Please note, that manually exported versions of the variables are overwritten.
>
> -For a list of well-known Debian build profiles and common practices, we refer to Debian's BuildProfileSpec.
> \ No newline at end of file
> +For a list of well-known Debian build profiles and common practices, we refer to Debian's BuildProfileSpec.
> +
> +### Move do_copy_boot_files task after do_rootfs_postprocess
> +
> +The boot-files(kernel, initrd, dtbs) are now shipped to tmp/deploy/images after
> +do_rootfs_postprocess task and before do_rootfs_finalize task.
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 6d77243..d70a93b 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -170,7 +170,7 @@ do_copy_boot_files() {
>          cp -f "$dtb" "${DEPLOY_DIR_IMAGE}/"
>      done
>  }
> -addtask copy_boot_files before do_rootfs_postprocess after do_rootfs_install
> +addtask copy_boot_files before do_rootfs_finalize after do_rootfs_postprocess
>
>  python do_image_tools() {
>      """Virtual task"""
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20220218095428.1767282-1-Vijaikumar_Kanagarajan%40mentor.com.