From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6805226701613694976 X-Received: by 2002:a92:911b:: with SMTP id t27mr19956023ild.142.1584949768988; Mon, 23 Mar 2020 00:49:28 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6638:d2:: with SMTP id w18ls12972jao.7.gmail; Mon, 23 Mar 2020 00:49:28 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvxQMq6W7w0Y7LbMEHDvbvIK5/lmGPg/HeGby0OOap8eO9gYZ2QE19F6z+oGohtEtFL+IHk X-Received: by 2002:a02:7787:: with SMTP id g129mr18942122jac.29.1584949768655; Mon, 23 Mar 2020 00:49:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584949768; cv=none; d=google.com; s=arc-20160816; b=CaQTZsW3MQAxkvhMtMGnyCzHyRpbilMFsvshGBn5g5TQTS0Tvs6EdW3C4TWcMAHwp8 g1hVVsKk5NpHkM2Y+fSbQRMhdYRO/jTu//MoPRnmD/tOvPLqhoS/ASemLPHfYpaqhBK5 aF6C+HoFGDrensyu5pyycXjltHLk4m37dlNZ0Gm4WjD6daJ4SdjY7kVk6+J92ba2X95+ v8OTcJsqUwNnfkyOcwJegycJx+seJerWY3MTaIqY7ewcoUXQND6PnfMdXKwQkUWGs2vy jupTahrvt5DS+1wJTgjlGoRiUlOoKjG+L/DOJFw0Mnq59Rin+I5o4ESIiTA/qEWgmuM7 TZnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=SXlrmkq6dxtDOcD9KrVCFYpF9OA1GJI9G7g3HtAP7bo=; b=Lshvbr/SQXqEW3FJEapU9rXw4dS8EX1gXWz17bXQhGLEZpDAz2G7yb7Dk8MxO+84NE RNpEAJShclvTH6wUHcKiePhMveFKqIH8J4M8efMe1qtaGkIixSVWsWdt7H93/A4EtHZ0 F/2ZqUm95a72wxKeLqrvtofPKSs8dtlk0GJtMb35A3D2iTKp48127j3MxK7UZn40wpah Ind1jpOEB7LY2To3uipaIM020Uer5tF/gFwflcPOt1Jj+aGo16r1rGP3L4NbM5WYBaoF jQXiibBFlrwO1I16wlwnPKO5r3+677zl8uh5vxin4sMErZGiPc0lgzbeEesBwpU55Wqk j1yA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uKfuPC82; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2607:f8b0:4864:20::741 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com. [2607:f8b0:4864:20::741]) by gmr-mx.google.com with ESMTPS id k88si886038ilg.1.2020.03.23.00.49.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2020 00:49:28 -0700 (PDT) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2607:f8b0:4864:20::741 as permitted sender) client-ip=2607:f8b0:4864:20::741; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uKfuPC82; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2607:f8b0:4864:20::741 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qk1-x741.google.com with SMTP id d11so14323930qko.3 for ; Mon, 23 Mar 2020 00:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SXlrmkq6dxtDOcD9KrVCFYpF9OA1GJI9G7g3HtAP7bo=; b=uKfuPC82cCKxgtIU9QR+aRQH3a4LVOKhjWiNOw6R/CmOkLPEeAX5j4B6UdHV3LwSCd iC1GLs3f0krX4FGwusK5NhvaccTDZwqPY3r+rMBoLa3tzyNrp4Cbaogis/385ikVRkPj +idf5VGW/mUx1QJlYf36bcrhKMBEiUaxVDKzq6wSo/H5ZGsyA68YY14iZIkmR6HegO5a P9RlB7TbnSAnbYbljQ/rvK8/v2Vp+gbgtyDRhxvhdi9Hz4y42L0/QA9bsdU2ir/pUXY0 qmEOaEmd5IAeA3Rsen70MYflnNGmKVz/ZOI70yVgUhAPEVjKhIezzz87NYoZEbdbN87y R2kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SXlrmkq6dxtDOcD9KrVCFYpF9OA1GJI9G7g3HtAP7bo=; b=nx/xzFYmdHpWaneTDf3QoVqgq/xAIxQewPMbmaHOAoJB5aEjVjibcu7aNeFjJz38++ bYw/CHoI7IQPpSIHp+97s0MqKTnXMcC2IkRtTVbUstrITG38aOSfWxZrlMDgXg2r0XDx gMzUBBoS7bBh0ZoZrSzTCli4Ui8+3rTqHPZsC/xjLOLTDqP07QnS3ZjHTAzOY4jrJnsj 5DFvsAUSqnYSZWgU9vJ16m2Jv0JwxtwZqVSHHn2zjaryjuPCaXv3ofNTwhYiMuON7gYd viT9zWyTpZSN1c+4CVr/xMT6ofT3IhUFhGHp+pJyUMNyJ1XJ1FcQbq/KLmQfDD6D9E2q BTWA== X-Gm-Message-State: ANhLgQ0xtpR/nGWJ/Fll1gBAS3twTqnLTqZv3gMbtRdy3/2kzZmmi+XL 181POWUtV7Orr3bMM+qhhlQrdOp8nwxbCaSZOTs= X-Received: by 2002:a05:620a:1084:: with SMTP id g4mr6699897qkk.52.1584949768055; Mon, 23 Mar 2020 00:49:28 -0700 (PDT) MIME-Version: 1.0 References: <20200318083443.57bfb489@md1za8fc.ad001.siemens.net> <20200318132137.26828-1-Vijaikumar_Kanagarajan@mentor.com> <3c561d87-4082-b25c-2a7d-932ebca37a73@siemens.com> <20200323075351.0607ceb8@md1za8fc.ad001.siemens.net> <8bfc26fd-627b-bfa8-cbfc-6d1c7614ac47@siemens.com> In-Reply-To: <8bfc26fd-627b-bfa8-cbfc-6d1c7614ac47@siemens.com> From: vijai kumar Date: Mon, 23 Mar 2020 13:19:17 +0530 Message-ID: Subject: Re: [PATCH v2] linux-custom: Install config and map file to /boot To: Jan Kiszka Cc: Henning Schild , isar-users , Vijai Kumar K Content-Type: text/plain; charset="UTF-8" X-TUID: s+W8T+EKTvQx On Mon, Mar 23, 2020 at 12:26 PM Jan Kiszka wrote: > > On 23.03.20 07:53, Henning Schild wrote: > > On Mon, 23 Mar 2020 07:12:00 +0100 > > "[ext] Jan Kiszka" wrote: > > > >> On 18.03.20 14:21, Vijai Kumar K wrote: > >>> Align with upstream debian linux-image package. Install the config > >>> and System.map file to /boot directory. Skip installation for User > >>> Mode Linux. > >>> > >>> Signed-off-by: Vijai Kumar K > >>> --- > >>> Changes in v2: > >>> - Moved um condition check as per Henning's comment > >>> > >>> .../linux/files/debian/isar/install.tmpl | 12 > >>> ++++++++++++ 1 file changed, 12 insertions(+) > >>> > >>> diff --git > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index > >>> 12d592d..849da5e 100644 --- > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -37,6 > >>> +37,10 @@ do_install() { set -x > >>> install_image > >>> + if [ "${ARCH}" != "um" ]; then > >>> + install_config > >>> + install_map > >>> + fi > >>> install_hooks > >>> install_dtbs > >>> install_kmods > >>> @@ -69,6 +73,14 @@ install_image() { > >>> install_image_debug > >>> } > >>> > >>> +install_config() { > >>> + cp ${O}/.config ${deb_img_dir}/$(dirname > >>> ${kimage_path})/config-${krel} +} > >>> + > >>> +install_map() { > >>> + cp ${O}/System.map ${deb_img_dir}/$(dirname > >>> ${kimage_path})/System.map-${krel} > >> > >> I think those cp calls should be install with proper modes, no? > > > > I wanted to say that as well, but in fact the whole scripts seems to > > use a mix of cp and install and this one does not make things worse. > > Yes, there are 2 other cases that should be fixed, separately. > > Jan I believe the permissions should be 644. Please correct me if I am wrong. Will send v3 with the install command. Thanks, Vijai Kumar K > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux