From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6805226701613694976 X-Received: by 2002:a17:90a:f305:: with SMTP id ca5mr8543634pjb.75.1584955469241; Mon, 23 Mar 2020 02:24:29 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a63:7d6:: with SMTP id 205ls4123400pgh.7.gmail; Mon, 23 Mar 2020 02:24:28 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvscODHge5BDslSyL4z+n2VwTFnhd4m+pyUCMvA6RQagnm77Mr0pEnqk37lYyFIsd9Ml1Zv X-Received: by 2002:a63:144e:: with SMTP id 14mr21777363pgu.264.1584955468613; Mon, 23 Mar 2020 02:24:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584955468; cv=none; d=google.com; s=arc-20160816; b=fcQ+bO6DteBZR4BZuwwhU3h/v4MuvxB4b2T7jU0QejeV3AcfPtHe3hl+kd7FsW0wV2 cR+TpiAaYsZ7zCkVQlJkvDNDLEj+/F0SisfgOjbzYXmCYhSPCjVO+XFgMRoP1ELC23sC hYKssN5dR9DakwiehsdO2sHPeaVvunvRvSUaYIRPnHkSFxb/D3CDXVLm8nu9hiXMuGpl OLl65VatfcBtuTbt2vUnw2xxUVgXJFmdclT/USGkj4NkCwgBEw++UbTRUGWOtj2tmwmP SHuSPGTftFf/uPhTVIqQT4H4KlUrfT+HZS1S8xC993z07OxK1nN+dxar5SApsAbxhk5s 98zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=o/448KX6bstS5OpfsXJWvMYTk9EN0Nj3VoUfR5jTCxk=; b=QeYbDUp3/7mW7YOoIxiedElFxvNQpXhNjkc7sV0kQ1SR4VKbtfeXNrSzPBy2uRjjxS l8mtUyVtHqCK0VpCdfaiFSOUHdbtfNi+HoxsKZk94wMqneYSNJIv4xOgNkxKBrXRf2HJ iYetLKDs5jMI6OmKx95rMW1OWCYKB/UVXq+apRwQ7YQwDX7JsEYT4sNrEX+YWBDDCXvf m5IoZqrAUFeIR9fcXqkH1aDUdgqrRkG7Rz9GH26Nsgs9AITcXGFiQYR1J2gCTW4llur6 a+Y18FB0biTbTAXtVB5ceO671OONjH3E/h3rHWkzkrZ5goOQF0GE5wcLRs6fq66cZy/9 eomg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QvHj5bZs; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2607:f8b0:4864:20::f42 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com. [2607:f8b0:4864:20::f42]) by gmr-mx.google.com with ESMTPS id y1si276071pjv.2.2020.03.23.02.24.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2020 02:24:28 -0700 (PDT) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2607:f8b0:4864:20::f42 as permitted sender) client-ip=2607:f8b0:4864:20::f42; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QvHj5bZs; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2607:f8b0:4864:20::f42 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qv1-xf42.google.com with SMTP id c28so6763034qvb.10 for ; Mon, 23 Mar 2020 02:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o/448KX6bstS5OpfsXJWvMYTk9EN0Nj3VoUfR5jTCxk=; b=QvHj5bZstM4WqaySXWxjUhQ49H1k40GgBWHjHpD6SAYo5v8UgMO14MCNKwbqDVyI7Y 8Lc5wrTvQ+dSIAL4abCM28uowLY+HXv7fDUrZrYMIlKtNkxnyW3N+P6RIrigIeKLcFvd jfjz34mlMpDlgwKvo4mB0+ECbBi5Hlw3OxR4dR2s+jVzch9oJuiATBITj7rHZ20/5QUJ Uy6JcH8SGEzwFQ6Dz++bPGg2UeNgZlxqn7l5+p81sm0BXg7qsv4PGcIcGLSHNB1kR4yp 0zor+hAM7kZmueRFMjggXLcZbg8Q0Rt7QDmI5VFnwdcW0VxGE8onyofiedyKSzGh+vBE j19A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o/448KX6bstS5OpfsXJWvMYTk9EN0Nj3VoUfR5jTCxk=; b=ntB15GaT2IYuEeC5q6tU+fEVXHwZSB025wsHyJouqP2EKZKY61+wecCXcJECtY6Lk4 PlQjaKH6k2JCSBhCnEYIFKsnuGtaPweQo1o6z/4njZE9/z4GARsDsoGAiy+J0F7xf/zH s90ogAsdKmhBOApn8oN5WiPmwvnz3J9VitG4eFJ025+gkVE/sK954vTmdAOZ6mIFroN0 OTanzyTMZAYsE3lX0bAt5V12ubXtqOS9RU2NrxLab40X04TsGBCCIykz4rOIiPv7Jtm7 YBFSn0InPOVMIBX6AFJIBvqM9WTa6svJn25mqUmitCZ/em154KXdKBig2iIqMOZ2cZRI 9YUg== X-Gm-Message-State: ANhLgQ2DllmoxgVviW59wLpPDBA0ZAJYU7JsSo0IqZwLSnQnadiwI8Ur j4kr1f+1dt+8fW9Oyh6JwEpv/JxC4htepO0HgqLj5RVKWV0= X-Received: by 2002:a05:6214:1923:: with SMTP id es3mr13137645qvb.157.1584955467653; Mon, 23 Mar 2020 02:24:27 -0700 (PDT) MIME-Version: 1.0 References: <20200318083443.57bfb489@md1za8fc.ad001.siemens.net> <20200318132137.26828-1-Vijaikumar_Kanagarajan@mentor.com> <3c561d87-4082-b25c-2a7d-932ebca37a73@siemens.com> <20200323075351.0607ceb8@md1za8fc.ad001.siemens.net> <8bfc26fd-627b-bfa8-cbfc-6d1c7614ac47@siemens.com> <20200323101320.3a4a5774@md1za8fc.ad001.siemens.net> In-Reply-To: <20200323101320.3a4a5774@md1za8fc.ad001.siemens.net> From: vijai kumar Date: Mon, 23 Mar 2020 14:54:05 +0530 Message-ID: Subject: Re: [PATCH v2] linux-custom: Install config and map file to /boot To: Henning Schild Cc: Jan Kiszka , isar-users , Vijai Kumar K Content-Type: text/plain; charset="UTF-8" X-TUID: iexXTc9MiLfs On Mon, Mar 23, 2020 at 2:43 PM Henning Schild wrote: > > On Mon, 23 Mar 2020 07:55:58 +0100 > Jan Kiszka wrote: > > > On 23.03.20 07:53, Henning Schild wrote: > > > On Mon, 23 Mar 2020 07:12:00 +0100 > > > "[ext] Jan Kiszka" wrote: > > > > > >> On 18.03.20 14:21, Vijai Kumar K wrote: > > >>> Align with upstream debian linux-image package. Install the config > > >>> and System.map file to /boot directory. Skip installation for User > > >>> Mode Linux. > > >>> > > >>> Signed-off-by: Vijai Kumar K > > >>> --- > > >>> Changes in v2: > > >>> - Moved um condition check as per Henning's comment > > >>> > > >>> .../linux/files/debian/isar/install.tmpl | 12 > > >>> ++++++++++++ 1 file changed, 12 insertions(+) > > >>> > > >>> diff --git > > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index > > >>> 12d592d..849da5e 100644 --- > > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ > > >>> -37,6 +37,10 @@ do_install() { set -x > > >>> install_image > > >>> + if [ "${ARCH}" != "um" ]; then > > >>> + install_config > > >>> + install_map > > >>> + fi > > >>> install_hooks > > >>> install_dtbs > > >>> install_kmods > > >>> @@ -69,6 +73,14 @@ install_image() { > > >>> install_image_debug > > >>> } > > >>> > > >>> +install_config() { > > >>> + cp ${O}/.config ${deb_img_dir}/$(dirname > > >>> ${kimage_path})/config-${krel} +} > > >>> + > > >>> +install_map() { > > >>> + cp ${O}/System.map ${deb_img_dir}/$(dirname > > >>> ${kimage_path})/System.map-${krel} > > >> > > >> I think those cp calls should be install with proper modes, no? > > > > > > I wanted to say that as well, but in fact the whole scripts seems to > > > use a mix of cp and install and this one does not make things > > > worse. > > > > Yes, there are 2 other cases that should be fixed, separately. > > I would suggest we ask Vijai to do all on top, instead of changing here > and forgetting the 2 cases? > > Or maybe just the two on top as part of the series? Vijai what do you > think? Hi Henning, We could address the two cases here and rest two cases as a separate patch. I could update this patch(v3) and can send a separate patch for the remaining two cases. Is this okay for all? Thanks, Vijai Kumar K > > Henning > > > Jan > > >