From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7033292862949163008 X-Received: by 2002:a05:6402:4243:: with SMTP id g3mr35771451edb.284.1637822545592; Wed, 24 Nov 2021 22:42:25 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:907:3e05:: with SMTP id hp5ls874084ejc.6.gmail; Wed, 24 Nov 2021 22:42:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJxLGpDw733Bf7tqpCPJ6Jes0OSEr/HTk/cYGkGW/1UXiNAiuLyBiLIIlPPft06+gwzZ/NHB X-Received: by 2002:a17:906:c297:: with SMTP id r23mr27689992ejz.528.1637822544624; Wed, 24 Nov 2021 22:42:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637822544; cv=none; d=google.com; s=arc-20160816; b=b2m6OZxCwZbZehv8wI3Gfa7QiUiTAofS889vEu+kql94JsW+V4VcAE4OnxLqNlTYvi 3f6F7qrFTC0F+1xSybfr4AdOipD8EmFrjQELfk7knfD3sBVYnw4tatNmd79PbWWVhCn0 XIQEmYZCS064kNuLfavok0FRNPT2olJAxXOZE9icrKi2gICUbKsJjTDint2spxyFWsQs xHKjQlc51CxyKUUAY1EeZ3faE0YSvEkGHPlLV23t7HOyAX5Dy6ldORGBHgn9EXvSo/1f gmDDBotAzs0j+Xalkl4UCaVe0eyUBJ6mqIpn0N7oVi5eERFUjuTWVE0kFhziLEx61IXd LT0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=qFsrKRiUo7PZLB6A5xCTX/zgGUXNzMR0agaAONBB30o=; b=mtp6WseCAbuIg9uQeiSPUEgug9j9dTKk1kGrfrpqn6qSnX54L2Aze2PeEhRheWFXnS CPwmzqOdHUz/2T35DTaAcfALEzvB2VelBUHKvIRRI+ilu7hjhluc46KnquxVXLY1j45G HY2NOvCEIikffoQlxgTe1kdD/0JAuBvxTeiAzQPDuFVeAMDP4bnVRLlBUXND46rh6lCd JvnyYsPaDCTP65cCmMrVoaqtF2lu/RvT7XRigDuIG0xAEBakSt2LPVYro9ccpXLPWubI pd/f4oz1QPVtk5TgEUfrrBEW+sp+H2ump8pVFQOzzkXlG4OpW5eUuwjLHZYDCn/OK36a DgvA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="cMBCm/R6"; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::336 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com. [2a00:1450:4864:20::336]) by gmr-mx.google.com with ESMTPS id d2si111048edk.1.2021.11.24.22.42.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Nov 2021 22:42:24 -0800 (PST) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::336 as permitted sender) client-ip=2a00:1450:4864:20::336; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="cMBCm/R6"; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::336 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wm1-x336.google.com with SMTP id 137so4618181wma.1 for ; Wed, 24 Nov 2021 22:42:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qFsrKRiUo7PZLB6A5xCTX/zgGUXNzMR0agaAONBB30o=; b=cMBCm/R6loFwAH6wt1TLINCWbnOIghBBlV4atLHw2q6HmOqkCf6Nr4ridlmMkRzeT6 bAA3VGpYlJWMovzJz8m/UxGcJ5/rUFIw500XD1bqOF3+rX/GHdzXNksTGCHGekeM7Cm/ WzI5rTBhuzoeNhpR21t4Pnk6rNYx4jULDbJrgwIHnvUVCwp3PXbtLu67VL62R0WmnAcF yOxTPqED8YquaXRNZAL6xffPQtj0pidkoKCbY8duHTjddJpcRtEl7sdbeh1HMt/vyQP3 Avfqw6avXb6xg0bCSSGgW9L6Thp6qHV4AlFXFar9axDVXW5sCaCncJhA0j7AYETXzp0B jkfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qFsrKRiUo7PZLB6A5xCTX/zgGUXNzMR0agaAONBB30o=; b=MOajEJGVthy9KIte0gYPWGMUxV6i+AKnq7xAKT0ca8+dNP07Ljwo7sXRBrsJ1x0Qha e48BzhH2Lnvg+BxS2Rq1Y3jWzBwC43ThXvWbz/ZdSAeksCorTf1h73wSJtnFAixQ0WZA MTyDC60yqVYTNu4E8EXKWn7gMYQFgCf78e49LjVeUVVocyDPAWs3QLe5avLuJpGEe7v6 ire1lsezekHK4f4NyN3VuDVo48TQANBZDQ6g8T/ne1rhGlK/BPxZHDJtnK1R7vHSIyg5 t2RSVH2L2dFW9O/oPPMLD7i/NdjOFrYfO7KaASk3FkUNIWvfSoZP+FSPoZGWcnVdqxEz KStQ== X-Gm-Message-State: AOAM530PdFv3Xc6eoctK1/tUhARLX4JBESix+lFhpseAR5ZqBHTbjfj/ yTWdcoZZoyPxKgNWETujklWtJAjLiw5py7Loeg0SrIKZ X-Received: by 2002:a05:600c:21cd:: with SMTP id x13mr4611662wmj.52.1637822544159; Wed, 24 Nov 2021 22:42:24 -0800 (PST) MIME-Version: 1.0 References: <20211122152607.2125422-1-Vijaikumar_Kanagarajan@mentor.com> <20211122152607.2125422-4-Vijaikumar_Kanagarajan@mentor.com> <8319aef1-420a-034e-9152-b0c3c8c3536a@siemens.com> In-Reply-To: <8319aef1-420a-034e-9152-b0c3c8c3536a@siemens.com> From: vijai kumar Date: Thu, 25 Nov 2021 12:12:13 +0530 Message-ID: Subject: Re: [PATCH v2 3/4] meta: u-boot: Prepare for newer versions To: Gylstorff Quirin Cc: Vijai Kumar K , isar-users , Jan Kiszka Content-Type: text/plain; charset="UTF-8" X-TUID: WePZn2sY/kPq On Tue, Nov 23, 2021 at 3:24 PM Gylstorff Quirin wrote: > > Hi, > > On 11/22/21 4:26 PM, Vijai Kumar K wrote: > > Newer versions of u-boot require libssl-dev:native for compilation. > > It also needs libssl-dev of the host architecture for cross compilation > > of tools. > > > > Signed-off-by: Vijai Kumar K > > --- > > meta/recipes-bsp/u-boot/u-boot-custom.inc | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc > > index 5198809..cfae0e2 100644 > > --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc > > +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc > > @@ -41,7 +41,9 @@ python() { > > d.setVar('U_BOOT_BUILD_PROFILES_remove', "config") > > } > > > > -DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git" > > +DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, libssl-dev:native" > > +DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' \ > > + if bb.utils.contains('U_BOOT_BUILD_PROFILES', 'tools', 1, 0, d) else ''}" > > Is there are reason why you didn't use `Build-Depends syntax extension` > from[1]? > Hi Quirin, Yes. There was. The previous version of patch depends on ISAR_CROSS_COMPILE as well. Guess there is nothing stopping us now. But, wondering if we can start introducing it via some example app with some documentation so that basic users are not puzzled on seeing that line in a recipe. Also, we could define a whole new variable to help recipe writers to define profiles and seamlessly use them without the need to explicitly export DEB_BUILD_PROFILES in the recipe's dpkg_runbuild Now that we are serious enough, we should probably take care of your earlier comment as well on following the standard. So that we don't conflict with Debian's predefined variables in case we decided to build a package fetched from apt:// and wanted to make use of its profile settings. Still need to look further but these are my initial thoughts. I could probably send some patches for review in coming days. For now, maybe we should call it and use pkg.uboot.tools instead of tools here so that we don't find something in that implementation that requires us to change this in future, possibly breaking u-boot / or the need to provide compatibility. Thoughts? Thanks, Vijai Kumar K > > [1]: https://wiki.debian.org/BuildProfileSpec > > > Quirin > > > > TEMPLATE_FILES = "debian/control.tmpl" > > TEMPLATE_VARS += "MACHINE DEBIAN_BUILD_DEPENDS" > > > > -- > You received this message because you are subscribed to the Google Groups "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/8319aef1-420a-034e-9152-b0c3c8c3536a%40siemens.com.