From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7044234567900725248 X-Received: by 2002:a2e:5711:: with SMTP id l17mr39641083ljb.123.1641298417469; Tue, 04 Jan 2022 04:13:37 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:5304:: with SMTP id c4ls676754lfh.3.gmail; Tue, 04 Jan 2022 04:13:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJxs5mNsAa1eg2d+9iQ0lTKCovGbWGuU/xvVKnZk3AR6580u4LxiscXChegToG0AUNI1m2+6 X-Received: by 2002:a05:6512:1285:: with SMTP id u5mr29814203lfs.249.1641298416323; Tue, 04 Jan 2022 04:13:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641298416; cv=none; d=google.com; s=arc-20160816; b=DJ6dwFOwmfA0FKBW5vO8pNBcE5mWYnmB/kJbkl9DWqNKteria48/Q8ql2IPAj9Z5vq of8TVOnhda6feE4J/7VKa3yT9oqyhZmpyZ7G2q3YVT16qylabsFkxwkgqpz8qcAR7Q5p nYs3b5cR5LutD6iTrReUDY09SvKd59H4q7+GHr/Hlo41zEQXx6K3koPGR2CjzfTM96Fu 7ukcpC35j2hrP/SxI4WqiDWHWMWEHWUZMZAbLliKvbgZNjaL34yD+OZmF5GFCuVJCG/V Zm4ogp1+UptcpeUYd92DuuzkrN402h/hao3lJJsZz7RcEW8W/y4sYhUbM5Oh8pvTzhPC 1D1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=K8CCObRPv52nTUo71aajfu7fOqhnR3nxqT0Zxr/4YEo=; b=03bFO1+WIhMkTgugY3UqT9rHtT7ZhPbnsYZU9QMSUtPA2KVwFL9fzX7uwryjtsc6Bl HnJYcmBShytiLuMrYAnC0EPkvTAdSqVqvcGRfrlOvdS23gosYwxqB54QqWVh+fJhOEGo 8C9QGAO3kfpP0ZRWwgCTq0gs3RD+SgoMm96MlGO56dr9TKY079McMx6//w/IjKPFHgEF m8QmM6V0Tw1XjNNbGzsd+t+uIfaHisk16PndvIL3UqSIPjD7pf6y/8Hz7MtHxpVzj9hj K4x+DETAZMQhy04dDTZvjToN4HEafkZz/qWVmHiQxHXXBk9C5N6g+o6rAepBgdaE5J73 SR0Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=dZOODxxx; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::433 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com. [2a00:1450:4864:20::433]) by gmr-mx.google.com with ESMTPS id k19si1952875lfv.12.2022.01.04.04.13.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jan 2022 04:13:36 -0800 (PST) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::433 as permitted sender) client-ip=2a00:1450:4864:20::433; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=dZOODxxx; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2a00:1450:4864:20::433 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wr1-x433.google.com with SMTP id t26so75741907wrb.4 for ; Tue, 04 Jan 2022 04:13:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K8CCObRPv52nTUo71aajfu7fOqhnR3nxqT0Zxr/4YEo=; b=dZOODxxxuoabqOSaOAPKc0NCV9aV2r99Ngcfnji4anv0H2XA3rkGtoXQC1o8A7Garw d1ZdeDj6mkpBlLeh1qul+lQhcgj8zEBzWgDD2a3Hvr6WvRoHOLL9Tt6m4qYfbgUwIjqx uem3mykj+2oo1NkLg1L//cO9Ke6zJCAxy3DXu9A1loUiAGB6QPPoba+afw1W7MRXbyYB gEqFya2e+G8qKUoGxs59V2VNakFacXac+uDJuJDOhIVz/DSM1AoX0SCXQKTHz6lGfyGa y3NFTPo74xrYdZ5h4NPE4Oo4BX/WzCSLoV9mxx0Q4vYAeGqoa3ZUmtjBQnXX0n1NURq+ DM5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K8CCObRPv52nTUo71aajfu7fOqhnR3nxqT0Zxr/4YEo=; b=3zFYN2tm8an6HHZL/jnF0MlpwlDYBqN9wS1kYTi0+Hq2yrtBYNyebjT8JmU8RR9PIt TdeVlfjyhPWr9XUpOpGOha9mis6KRuBs3STvpeIX5q2o8eqSo1OIxNW/giuGmvgXTRSC 2+WjvtM/1nN7k6jX82pigg0O5MXFmqdHZtLazS/gewPu+4DFMyVArjLhSh54bWFr9ZkE ukmf+/xsZI6B1WFYYizne2CzlQ3lrcgD4n8Bibd6qeBfWQMi1i2mmkGisZwaXYaIaYDF qw5RbQm84++eOX5B67e27Uuw51mc9v2xumRahOYa/LMqwuJD2Ncl7yl8OXyUVFP9RTmr rcnw== X-Gm-Message-State: AOAM5307sEcSSVWUVSS0QyH1YujOOpiZ1SURJYkwzmOH65XX53tm0Zh9 z21axdEAUmcgA1jcugKn56W0LbbI6XMg0GO4nEg= X-Received: by 2002:a5d:58d8:: with SMTP id o24mr21259656wrf.467.1641298415934; Tue, 04 Jan 2022 04:13:35 -0800 (PST) MIME-Version: 1.0 References: <20220104100235.719079-1-felix.moessbauer@siemens.com> <20220104100235.719079-2-felix.moessbauer@siemens.com> In-Reply-To: <20220104100235.719079-2-felix.moessbauer@siemens.com> From: vijai kumar Date: Tue, 4 Jan 2022 17:43:24 +0530 Message-ID: Subject: Re: [PATCH v2 1/2] add support for debian build profiles To: Felix Moessbauer Cc: isar-users , Jan Kiszka Content-Type: text/plain; charset="UTF-8" X-TUID: bVdIBvxCuKun On Tue, Jan 4, 2022 at 3:33 PM Felix Moessbauer wrote: > > This patch adds the bitbake variables DEB_BUILD_PROFILES and > DEB_BUILD_PROFILES_CROSS. > The values of these variables are used to define the DEB_BUILD_PROFILES > environment variable. > > When cross-compiling, the DEB_BUILD_PROFILES_CROSS variable is defaulted > to "cross", to be consistent with upstream debian. > > Signed-off-by: Felix Moessbauer > --- > RECIPE-API-CHANGELOG.md | 9 +++++++++ > meta/classes/dpkg-base.bbclass | 13 +++++++++++++ > meta/classes/dpkg.bbclass | 4 +++- > 3 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > index 3bbb42a9..1f3a19b4 100644 > --- a/RECIPE-API-CHANGELOG.md > +++ b/RECIPE-API-CHANGELOG.md > @@ -314,3 +314,12 @@ The "NAME" used to be rather static and the TAG was always "latest", now the val > ### Renamed variable CONTAINER_FORMATS to CONTAINER_IMAGE_FORMATS > > The meaning remains the same, just the name changed. > +### Introduce debian build profiles > + > +All recipes that inherit from dpkg and dpkg-base can utilize the variables DEB_BUILD_PROFILES and DEB_BUILD_PROFILES_CROSS. > +These variables define the DEB_BUILD_PROFILES environment variable which is available in do_install_builddeps and do_dpkg_build. > +When cross compiling, the values in DEB_BUILD_PROFILES_CROSS (default: "cross") are used to define the environment variable. > + > +For a list of well-known Debian build profiles and common practices, we refer to Debian's BuildProfileSpec. > + > + > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > index cb5ce4a9..05c1cbd3 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -13,6 +13,8 @@ inherit deb-dl-dir > DEPENDS ?= "" > > DEPENDS_append_riscv64 = "${@' crossbuild-essential-riscv64' if d.getVar('ISAR_CROSS_COMPILE', True) == '1' and d.getVar('PN') != 'crossbuild-essential-riscv64' else ''}" > +DEB_BUILD_PROFILES ?= "" > +DEB_BUILD_PROFILES_CROSS ?= "cross" > > python do_adjust_git() { > import subprocess > @@ -201,7 +203,17 @@ dpkg_runbuild() { > die "This should never be called, overwrite it in your derived class" > } > > +def isar_export_build_profiles(d): > + import os > + deb_build_profiles = os.environ['DEB_BUILD_PROFILES'] if 'DEB_BUILD_PROFILES' in os.environ else '' > + if d.getVar("ISAR_CROSS_COMPILE") == "1": > + deb_build_profiles += ' ' + d.getVar('DEB_BUILD_PROFILES_CROSS', True) Still trying to understand the need for the extra variable. Maybe an example will help me understand better. It could just be DEB_BUILD_PROFILES += "cross" > + else: > + deb_build_profiles += ' ' + d.getVar('DEB_BUILD_PROFILES', True) > + os.environ['DEB_BUILD_PROFILES'] = deb_build_profiles.strip() > + > python do_dpkg_build() { > + isar_export_build_profiles(d) > lock = bb.utils.lockfile(d.getVar("REPO_ISAR_DIR") + "/isar.lock", > shared=True) > bb.build.exec_func("dpkg_do_mounts", d) > @@ -279,6 +291,7 @@ python do_devshell() { > > isar_export_proxies(d) > isar_export_ccache(d) > + isar_export_build_profiles(d) > > buildchroot = d.getVar('BUILDCHROOT_DIR') > pp_pps = os.path.join(d.getVar('PP'), d.getVar('PPS')) > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index 27fe84f4..68f63f93 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -9,10 +9,12 @@ PACKAGE_ARCH ?= "${DISTRO_ARCH}" > do_install_builddeps() { > dpkg_do_mounts > E="${@ isar_export_proxies(d)}" > + E="${@ isar_export_build_profiles(d)}" > distro="${DISTRO}" > if [ ${ISAR_CROSS_COMPILE} -eq 1 ]; then > - distro="${HOST_DISTRO}" > + distro="${HOST_DISTRO}" Probably an unwanted indent change. Thanks, Vijai Kumar K > fi > + > deb_dl_dir_import "${BUILDCHROOT_DIR}" "${distro}" > sudo -E chroot ${BUILDCHROOT_DIR} /isar/deps.sh \ > ${PP}/${PPS} ${PACKAGE_ARCH} --download-only > -- > 2.30.2 >