From: vijai kumar <vijaikumar.kanagarajan@gmail.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>,
Baurzhan Ismagulov <ibr@radix50.net>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v3 1/2] rootfs: Make rootfs finalize a separate task
Date: Fri, 3 Apr 2020 12:20:41 +0530 [thread overview]
Message-ID: <CALLGG_L-hX2YHxfYZeVf=ZXErGhmDV6-rmAfnsi6ax9H4r54gg@mail.gmail.com> (raw)
In-Reply-To: <CALLGG_+t+VkvwmwysFazi7gBXULNf5kSmZjUpWrJkypVChzkJQ@mail.gmail.com>
On Wed, Apr 1, 2020 at 3:59 PM vijai kumar
<vijaikumar.kanagarajan@gmail.com> wrote:
>
> On Wed, Apr 1, 2020 at 1:49 PM Henning Schild
> <henning.schild@siemens.com> wrote:
> >
> > On Wed, 1 Apr 2020 12:55:43 +0530
> > vijai kumar <vijaikumar.kanagarajan@gmail.com> wrote:
> >
> > > On Wed, Mar 11, 2020 at 12:46 PM vijai kumar
> > > <vijaikumar.kanagarajan@gmail.com> wrote:
> > > >
> > > > As said before, this series, atleast the second patch, depends on
> > > > Henning's base-apt series.
> > > >
> > > > I am going to rebase my changes on top of Hennings v5 and test it
> > > > out.
> > > >
> > > > Also, should we have these changes as part of Hennings series? Or
> > > > should I wait for the series to get in and address these later?
> > > >
> > > Hi All,
> > >
> > > While testing this series on top of the current next I got the below
> > > error. Any pointers? I am yet to try a local build.
> >
> > I guess the main question is whether that issue just came up once, or
> > whether it consist over several builds.
>
> It came up last night. I haven't seen these errors before.
>
> >
> > > Failed to fetch
> > > http://deb.debian.org/debian/pool/main/g/gettext/gettext_0.19.8.1.orig.tar.xz
> > > Writing more data than expected (7210080 > 7209808)
> > >
> > > Hashes of expected file:
> > > -
> > > SHA256:105556dbc5c3fbbc2aa0edb46d22d055748b6f5c7cd7a8d99f8e7eb84e938be4
> > > - Filesize:7209808 [weak]
> > >
> > > - MD5Sum:df3f5690eaa30fd228537b00cb7b7590 [weak]
> > > E: Failed to fetch some archives.
> >
> > A fetch should not be affected by what is in next. I would guess/hope
> > that you just into a temporary network hickup.
>
> I am assuming the same. I hit it in a couple of builds. Anyway my
> local build got through. Triggered another job in CI to see if this
> issues goes away.
>
> Thanks,
> Vijai Kumar K
I am getting this fetcher issue consistently (packages differ) in the
ISAR CI build. All my local builds went through. I believe there is
more to it. Some proxy issues affecting apt fetch in CI?
Thanks,
Vijai Kumar K
>
> >
> > Henning
> >
> > > http://ci.isar-build.org:8080/job/isar_vkk_devel/40/consoleFull
> > >
> > > Also, there are some more fixes, to strip the version info from Source
> > > field, so v4 is in pipeline.
> > >
> > > Thanks,
> > > Vijai Kumar K
> > >
> > >
> > > > Thanks,
> > > > Vijai Kumar K
> > > >
> > > > On Friday, February 14, 2020 at 11:18:11 AM UTC+5:30, vijai kumar
> > > > wrote:
> > > >>
> > > >> With the current implementation it is difficult to append a
> > > >> postprocess function which requires a chroot environment.
> > > >> For example, to add a postprocess function which runs apt-get to
> > > >> download all source of packages installed in the target.
> > > >>
> > > >> rootfs_postprocess_finalize is not actually an optional feature
> > > >> but instead a necessary cleanup function for image class.
> > > >> So, move the implementation to image class and make it as a task.
> > > >>
> > > >> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> > > >> ---
> > > >> Changes in v3:
> > > >> - Take care of non-existent downloads/deb-src directory.
> > > >>
> > > >> meta/classes/image.bbclass | 41
> > > >> ++++++++++++++++++++++++++++++++++++- meta/classes/rootfs.bbclass
> > > >> | 39 ----------------------------------- 2 files changed, 40
> > > >> insertions(+), 40 deletions(-)
> > > >>
> > > >> diff --git a/meta/classes/image.bbclass
> > > >> b/meta/classes/image.bbclass index cfd617a..c5fddba 100644
> > > >> --- a/meta/classes/image.bbclass
> > > >> +++ b/meta/classes/image.bbclass
> > > >> @@ -60,7 +60,7 @@ image_do_mounts() {
> > > >> }
> > > >>
> > > >> ROOTFSDIR = "${IMAGE_ROOTFS}"
> > > >> -ROOTFS_FEATURES += "clean-package-cache finalize-rootfs
> > > >> generate-manifest" +ROOTFS_FEATURES += "copy-package-cache
> > > >> clean-package-cache generate-manifest" ROOTFS_PACKAGES +=
> > > >> "${IMAGE_PREINSTALL} ${IMAGE_INSTALL}" ROOTFS_MANIFEST_DEPLOY_DIR
> > > >> ?= "${DEPLOY_DIR_IMAGE}"
> > > >>
> > > >> @@ -168,5 +168,44 @@ python do_deploy() {
> > > >> }
> > > >> addtask deploy before do_build after do_image
> > > >>
> > > >> +do_rootfs_finalize() {
> > > >> + sudo -s <<'EOSUDO'
> > > >> + test -e "${ROOTFSDIR}/chroot-setup.sh" && \
> > > >> + "${ROOTFSDIR}/chroot-setup.sh" "cleanup"
> > > >> "${ROOTFSDIR}"
> > > >> + rm -f "${ROOTFSDIR}/chroot-setup.sh"
> > > >> +
> > > >> + test ! -e "${ROOTFSDIR}/usr/share/doc/qemu-user-static"
> > > >> && \
> > > >> + find "${ROOTFSDIR}/usr/bin" \
> > > >> + -maxdepth 1 -name 'qemu-*-static' -type f -delete
> > > >> +
> > > >> + mountpoint -q '${ROOTFSDIR}/isar-apt' && \
> > > >> + umount -l ${ROOTFSDIR}/isar-apt
> > > >> + rmdir --ignore-fail-on-non-empty ${ROOTFSDIR}/isar-apt
> > > >> +
> > > >> + mountpoint -q '${ROOTFSDIR}/base-apt' && \
> > > >> + umount -l ${ROOTFSDIR}/base-apt
> > > >> + rmdir --ignore-fail-on-non-empty ${ROOTFSDIR}/base-apt
> > > >> +
> > > >> + mountpoint -q '${ROOTFSDIR}/dev' && \
> > > >> + umount -l ${ROOTFSDIR}/dev
> > > >> + mountpoint -q '${ROOTFSDIR}/sys' && \
> > > >> + umount -l ${ROOTFSDIR}/proc
> > > >> + mountpoint -q '${ROOTFSDIR}/sys' && \
> > > >> + umount -l ${ROOTFSDIR}/sys
> > > >> +
> > > >> + rm -f
> > > >> "${ROOTFSDIR}/etc/apt/apt.conf.d/55isar-fallback.conf" +
> > > >> + rm -f "${ROOTFSDIR}/etc/apt/sources.list.d/isar-apt.list"
> > > >> + rm -f "${ROOTFSDIR}/etc/apt/preferences.d/isar-apt"
> > > >> + rm -f "${ROOTFSDIR}/etc/apt/sources.list.d/base-apt.list"
> > > >> +
> > > >> + mv "${ROOTFSDIR}/etc/apt/sources-list" \
> > > >> + "${ROOTFSDIR}/etc/apt/sources.list.d/bootstrap.list"
> > > >> +
> > > >> + rm -f "${ROOTFSDIR}/etc/apt/sources-list"
> > > >> +EOSUDO
> > > >> +}
> > > >> +addtask rootfs_finalize before do_rootfs after
> > > >> do_rootfs_postprocess +
> > > >> # Last so that the image type can overwrite tasks if needed
> > > >> inherit ${IMAGE_TYPE}
> > > >> diff --git a/meta/classes/rootfs.bbclass
> > > >> b/meta/classes/rootfs.bbclass index 54b5e5c..c3af7c1 100644
> > > >> --- a/meta/classes/rootfs.bbclass
> > > >> +++ b/meta/classes/rootfs.bbclass
> > > >> @@ -201,45 +201,6 @@ rootfs_generate_manifest () {
> > > >> ${ROOTFS_MANIFEST_DEPLOY_DIR}/"${PF}".manifest
> > > >> }
> > > >>
> > > >> -ROOTFS_POSTPROCESS_COMMAND +=
> > > >> "${@bb.utils.contains('ROOTFS_FEATURES', 'finalize-rootfs',
> > > >> 'rootfs_postprocess_finalize', '', d)}"
> > > >> -rootfs_postprocess_finalize() {
> > > >> - sudo -s <<'EOSUDO'
> > > >> - test -e "${ROOTFSDIR}/chroot-setup.sh" && \
> > > >> - "${ROOTFSDIR}/chroot-setup.sh" "cleanup"
> > > >> "${ROOTFSDIR}"
> > > >> - rm -f "${ROOTFSDIR}/chroot-setup.sh"
> > > >> -
> > > >> - test ! -e "${ROOTFSDIR}/usr/share/doc/qemu-user-static"
> > > >> && \
> > > >> - find "${ROOTFSDIR}/usr/bin" \
> > > >> - -maxdepth 1 -name 'qemu-*-static' -type f -delete
> > > >> -
> > > >> - mountpoint -q '${ROOTFSDIR}/isar-apt' && \
> > > >> - umount -l ${ROOTFSDIR}/isar-apt
> > > >> - rmdir --ignore-fail-on-non-empty ${ROOTFSDIR}/isar-apt
> > > >> -
> > > >> - mountpoint -q '${ROOTFSDIR}/base-apt' && \
> > > >> - umount -l ${ROOTFSDIR}/base-apt
> > > >> - rmdir --ignore-fail-on-non-empty ${ROOTFSDIR}/base-apt
> > > >> -
> > > >> - mountpoint -q '${ROOTFSDIR}/dev' && \
> > > >> - umount -l ${ROOTFSDIR}/dev
> > > >> - mountpoint -q '${ROOTFSDIR}/sys' && \
> > > >> - umount -l ${ROOTFSDIR}/proc
> > > >> - mountpoint -q '${ROOTFSDIR}/sys' && \
> > > >> - umount -l ${ROOTFSDIR}/sys
> > > >> -
> > > >> - rm -f
> > > >> "${ROOTFSDIR}/etc/apt/apt.conf.d/55isar-fallback.conf" -
> > > >> - rm -f "${ROOTFSDIR}/etc/apt/sources.list.d/isar-apt.list"
> > > >> - rm -f "${ROOTFSDIR}/etc/apt/preferences.d/isar-apt"
> > > >> - rm -f "${ROOTFSDIR}/etc/apt/sources.list.d/base-apt.list"
> > > >> -
> > > >> - mv "${ROOTFSDIR}/etc/apt/sources-list" \
> > > >> - "${ROOTFSDIR}/etc/apt/sources.list.d/bootstrap.list"
> > > >> -
> > > >> - rm -f "${ROOTFSDIR}/etc/apt/sources-list"
> > > >> -EOSUDO
> > > >> -}
> > > >> -
> > > >> do_rootfs_postprocess[vardeps] = "${ROOTFS_POSTPROCESS_COMMAND}"
> > > >> python do_rootfs_postprocess() {
> > > >> # Take care that its correctly mounted:
> > > >> --
> > > >> 2.17.1
> > > >>
> > > > --
> > > > You received this message because you are subscribed to the Google
> > > > Groups "isar-users" group. To unsubscribe from this group and stop
> > > > receiving emails from it, send an email to
> > > > isar-users+unsubscribe@googlegroups.com. To view this discussion on
> > > > the web visit
> > > > https://groups.google.com/d/msgid/isar-users/7a71ebe9-9846-41ed-beae-a02360129b89%40googlegroups.com.
> > > >
> >
next prev parent reply other threads:[~2020-04-03 6:50 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 14:06 [PATCH] rootfs: Make rootfs_postprocess_finalize the last step Vijai Kumar K
2020-02-06 17:21 ` Jan Kiszka
2020-02-06 17:47 ` vijai kumar
2020-02-06 18:09 ` Jan Kiszka
2020-02-06 18:28 ` vijai kumar
2020-02-10 5:37 ` [PATCH v2] rootfs: Make rootfs finalize a separate task Vijai Kumar K
2020-02-11 11:38 ` Henning Schild
2020-02-11 14:14 ` vijai kumar
2020-02-11 15:20 ` Henning Schild
2020-02-11 18:07 ` Jan Kiszka
2020-02-13 10:08 ` [PATCH v2 1/2] " Vijai Kumar K
2020-02-13 10:08 ` [PATCH v2 2/2] meta: cache deb srcs as part of postprocessing Vijai Kumar K
2020-02-14 5:48 ` [PATCH v3 1/2] rootfs: Make rootfs finalize a separate task Vijai Kumar K
2020-02-14 5:48 ` [PATCH v3 2/2] meta: cache deb srcs as part of postprocessing Vijai Kumar K
2020-02-14 8:19 ` Jan Kiszka
2020-02-14 8:41 ` vijai kumar
2020-02-14 8:45 ` vijai kumar
2020-03-11 7:16 ` [PATCH v3 1/2] rootfs: Make rootfs finalize a separate task vijai kumar
2020-04-01 7:25 ` vijai kumar
2020-04-01 8:19 ` Henning Schild
2020-04-01 10:29 ` vijai kumar
2020-04-03 6:50 ` vijai kumar [this message]
2020-04-03 8:30 ` Baurzhan Ismagulov
2020-04-03 8:50 ` vijai kumar
2020-04-03 13:05 ` [PATCH v4 " Vijai Kumar K
2020-04-03 13:05 ` [PATCH v4 2/2] meta: cache deb srcs as part of postprocessing Vijai Kumar K
2020-04-07 6:44 ` Jan Kiszka
2020-04-07 6:58 ` vijai kumar
2020-04-07 7:04 ` Jan Kiszka
2020-04-07 7:59 ` vijai kumar
2020-04-07 8:38 ` Jan Kiszka
2020-04-07 9:08 ` vijai kumar
2020-04-07 9:40 ` vijai kumar
2020-04-08 8:13 ` Baurzhan Ismagulov
2020-04-08 10:04 ` vijai kumar
2020-04-08 13:32 ` vijai kumar
2020-04-15 6:44 ` vijai kumar
2020-04-15 7:28 ` Jan Kiszka
2020-04-15 13:20 ` vijai kumar
2020-04-15 13:44 ` Jan Kiszka
2020-04-08 10:04 ` Henning Schild
2020-04-08 10:37 ` vijai kumar
2020-04-08 12:30 ` Henning Schild
2020-04-15 12:29 ` vijai kumar
2020-04-15 18:19 ` Henning Schild
2020-04-16 15:57 ` vijai kumar
2020-04-16 17:29 ` Henning Schild
2020-04-07 6:19 ` [PATCH v3 1/2] rootfs: Make rootfs finalize a separate task vijai kumar
2020-04-07 6:45 ` Jan Kiszka
2020-04-07 6:53 ` vijai kumar
2020-04-07 7:12 ` Baurzhan Ismagulov
2020-04-07 8:04 ` vijai kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALLGG_L-hX2YHxfYZeVf=ZXErGhmDV6-rmAfnsi6ax9H4r54gg@mail.gmail.com' \
--to=vijaikumar.kanagarajan@gmail.com \
--cc=henning.schild@siemens.com \
--cc=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox