On Sat, 5 Sep 2020 at 2:34 PM, Henning Schild <henning.schild@siemens.com>
wrote:

> This looks good at a first glance, left some comments.
>
>
>
> I assume the isar tests work with it. We already heard from Jan that he
>
> tested it on one of his layers. Did you happen to test it on one of you
>
> mentor layers, maybe a board with a "complex" wic setup.
>

We tested with isar siemens and jailhouse images project. I didnt test with
our mentor layers though. It is there in pipeline. Maybe in coming weeks I
would give it a try.

Thanks,
Vijai Kumar K


>
>
> Henning
>
>
>
> On Wed, 2 Sep 2020 22:46:18 -0700 (PDT)
>
> "vijaikumar....@gmail.com" <vijaikumar.kanagarajan@gmail.com> wrote:
>
>
>
> > If there are no review comments, can this get merged to next?
>
> >
>
> > Thanks,
>
> > Vijai Kumar K
>
> >
>
> > On Thursday, September 3, 2020 at 12:26:57 AM UTC+5:30
>
> > vijaikumar_...@mentor.com wrote:
>
> >
>
> > > Changes since RFC(v1):
>
> > >
>
> > > - P9 commit is upstreamed and replaced with the version from
>
> > > OE-core.
>
> > > - P10: Lot of downstream projects tend to use /boot mountpoints for
>
> > > bootloader/EFI
>
> > > partitions. Added RECIPE-API-CHANGELOG entry to warn user about
>
> > > potential issues
>
> > > that might arise when doing so with latest wic.
>
> > >
>
> > > Henning Schild (1):
>
> > > lib/oe/path: try hardlinking instead of guessing when it might fail
>
> > >
>
> > > Paul Barker (1):
>
> > > oe.path: Add copyhardlink() helper function
>
> > >
>
> > > Vijai Kumar K (8):
>
> > > wic: Update to the latest wic from openembedded core
>
> > > wic/plugins: Fix wic plugins to work with the latest wic
>
> > > wic-img: Satisfy the quirks of latest wic
>
> > > wic_fakeroot: Handle standalone pseudo invocations
>
> > > meta-isar/conf: Add provision to debug WIC
>
> > > debian-common: Add tar as a dependency for wic
>
> > > wic: misc: Add /bin to the list of searchpaths
>
> > > meta-isar/canned-wks: Remove /boot mountpoint
>
> > >
>
> > > RECIPE-API-CHANGELOG.md | 17 +
>
> > > meta-isar/conf/local.conf.sample | 3 +
>
> > > .../lib/wic/canned-wks/common-isar.wks.inc | 2 +-
>
> > > .../scripts/lib/wic/canned-wks/hikey.wks | 2 +-
>
> > > .../lib/wic/canned-wks/sdimage-efi.wks | 2 +-
>
> > > meta/classes/wic-img.bbclass | 15 +-
>
> > > meta/conf/distro/debian-common.conf | 3 +-
>
> > > meta/lib/oe/path.py | 27 +-
>
> > > .../wic/plugins/source/bootimg-efi-isar.py | 2 +-
>
> > > .../wic/plugins/source/bootimg-pcbios-isar.py | 9 +-
>
> > > .../lib/wic/plugins/source/rootfs-u-boot.py | 2 +-
>
> > > scripts/lib/scriptpath.py | 32 ++
>
> > > scripts/lib/wic/__init__.py | 14 +-
>
> > > scripts/lib/wic/canned-wks/common.wks.inc | 2 +-
>
> > > .../directdisk-bootloader-config.cfg | 8 +-
>
> > > .../lib/wic/canned-wks/efi-bootdisk.wks.in | 3 +
>
> > > scripts/lib/wic/canned-wks/mkhybridiso.wks | 2 +-
>
> > > scripts/lib/wic/canned-wks/qemuriscv.wks | 3 +
>
> > > .../lib/wic/canned-wks/qemux86-directdisk.wks | 2 +-
>
> > > .../lib/wic/canned-wks/sdimage-bootpart.wks | 4 +-
>
> > > .../lib/wic/canned-wks/systemd-bootdisk.wks | 4 +-
>
> > > scripts/lib/wic/engine.py | 421 +++++++++++++++-
>
> > > scripts/lib/wic/filemap.py | 170 ++++---
>
> > > scripts/lib/wic/help.py | 401 ++++++++++++++--
>
> > > scripts/lib/wic/ksparser.py | 115 +++--
>
> > > scripts/lib/wic/{utils => }/misc.py | 100 ++--
>
> > > scripts/lib/wic/partition.py | 234 ++++-----
>
> > > scripts/lib/wic/pluginbase.py | 36 +-
>
> > > scripts/lib/wic/plugins/imager/direct.py | 175 ++++---
>
> > > .../wic/plugins/source/bootimg-biosplusefi.py | 213 +++++++++
>
> > > scripts/lib/wic/plugins/source/bootimg-efi.py | 111 +++--
>
> > > .../wic/plugins/source/bootimg-partition.py | 153 ++++--
>
> > > .../lib/wic/plugins/source/bootimg-pcbios.py | 91 ++--
>
> > > scripts/lib/wic/plugins/source/fsimage.py | 56 ---
>
> > > .../wic/plugins/source/isoimage-isohybrid.py | 185 +++----
>
> > > scripts/lib/wic/plugins/source/rawcopy.py | 44 +-
>
> > > scripts/lib/wic/plugins/source/rootfs.py | 159 ++++--
>
> > > scripts/lib/wic/utils/__init__.py | 0
>
> > > scripts/lib/wic/utils/runner.py | 114 -----
>
> > > scripts/wic | 452 +++++++++++++-----
>
> > > scripts/wic_fakeroot | 5 +
>
> > > 41 files changed, 2357 insertions(+), 1036 deletions(-)
>
> > > create mode 100644 scripts/lib/scriptpath.py
>
> > > create mode 100644 scripts/lib/wic/canned-wks/efi-bootdisk.wks.in
>
> > > create mode 100644 scripts/lib/wic/canned-wks/qemuriscv.wks
>
> > > rename scripts/lib/wic/{utils => }/misc.py (70%)
>
> > > create mode 100644
>
> > > scripts/lib/wic/plugins/source/bootimg-biosplusefi.py delete mode
>
> > > 100644 scripts/lib/wic/plugins/source/fsimage.py delete mode 100644
>
> > > scripts/lib/wic/utils/__init__.py delete mode 100644
>
> > > scripts/lib/wic/utils/runner.py
>
> > >
>
> > > --
>
> > > 2.17.1
>
> > >
>
> > >
>
> >
>
>
>
>