From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6864480010557718528 X-Received: by 2002:a25:3403:: with SMTP id b3mr6489276yba.455.1599297944480; Sat, 05 Sep 2020 02:25:44 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a25:5755:: with SMTP id l82ls826748ybb.5.gmail; Sat, 05 Sep 2020 02:25:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrxP5jp9FGSw1A2Z48ggoiPTRzBpOWp0cNAOzyb2UH1T1Jk9MVICaX+fQaxQ6epzN2jwLl X-Received: by 2002:a25:af05:: with SMTP id a5mr16415796ybh.365.1599297943845; Sat, 05 Sep 2020 02:25:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599297943; cv=none; d=google.com; s=arc-20160816; b=QXZhH4f14DolaxkMVdaYaJcbfeTg4ClIgGKRQgBPcM1dqSHqY+q65KoS46LVi6EPRb 5W2ncLMTL2AidlC9s1R5XW5D6yeo8F+DsxO6ng4GbroXYPrDY//iJQI7gv2b+nJFDOkL I9uQgcD/4Nns/8ZZ4mc31PS6XujwWKn99tvrAVfcF+ZarghUZD9gWie7zsE39ti7DnhB rjiNFmtrRRiAVJCvhj+If+0/b5KC1BWdMrOhZkpTszhRlLPTfG3ZjjAdEMvxcD+n6Gaa iaG7YYqrn/H754hv/QgoC8TeCVIYa/0cOVLcWaVmFG0niHNm+MuzGNJ7cJxE48lMJ8Bs Zu5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=6Jmfwg8WQ3UCvh0jV59a5a/igbf+chh77HojH8UJGgk=; b=daCOxispptUjQs+tlIh0iRqwcco5xaE6OfBMe5A/3r/8kTbGjLxMqWRdgHEgt9SjBw uO1Spo5qFIXKNuyjxFULFOc9ktU9xgSGrRdQifX9ry65BUNBQDssy8lud8dVblnqm1lp XMmUH+jfcvmo1m5qhb6t805JjcFnssLLXeUVAhYLuV5I6uzwgHW9BsIh2oLGDsI8QKc6 q7wjLYZSu9mAZN7ILLq7a0zCfNd3s72hzZMc9+fxuLmeAjXKs/ZVfcuuF50gfc3SlX0l v3OnhywKlSQm4VFVTInNs9YbBTcSyMr3fGvEHzl4CxjvlHFgHyeYckPTA6zRmttT2PvF R/3A== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GHw9jek6; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2607:f8b0:4864:20::731 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com. [2607:f8b0:4864:20::731]) by gmr-mx.google.com with ESMTPS id m193si777360ybf.1.2020.09.05.02.25.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Sep 2020 02:25:43 -0700 (PDT) Received-SPF: pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2607:f8b0:4864:20::731 as permitted sender) client-ip=2607:f8b0:4864:20::731; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GHw9jek6; spf=pass (google.com: domain of vijaikumar.kanagarajan@gmail.com designates 2607:f8b0:4864:20::731 as permitted sender) smtp.mailfrom=vijaikumar.kanagarajan@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qk1-x731.google.com with SMTP id d20so8767203qka.5 for ; Sat, 05 Sep 2020 02:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6Jmfwg8WQ3UCvh0jV59a5a/igbf+chh77HojH8UJGgk=; b=GHw9jek6vZrhYAGruQklGWObgj1uJSmWhxGnKaH2WdJt1RvSHi9x3gIlF3W6fR26Om nT2X4Uqh863So+cJGE8zBS3/PvQpQVKAJhhRNhJIXrOOcIQ8i6Stjp+JFkvFo1eblBk1 SELGoX8h556pQnAtmFDxKvn7/ygcHcwSiVo+qlQIePRxhpB+Q+g5S4AP4/QIggA6BxJs fmGE9c+zIpNdt7x9JIQvJjX92pkbWeg6hxSDlYiJUl4A3oGPE3nAazHaykrj8DgDYzWB kfUVCklgk911LUFcXLOQGWZImuCOVD9iUMDKm/vic4fV9154hWdXptUqSCmzhhGQR9xd xgFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6Jmfwg8WQ3UCvh0jV59a5a/igbf+chh77HojH8UJGgk=; b=rHxYY1ko5UfS8km+Wk1Mauy3IfO9EKcNcc4CEDYRGssryeNemJExj/CksiwZ5cD8H6 E/nRBJ8L2zoXhESSYPIPoG7FjS6vn41aycMPQLTSJqg4Aj46NvsmpVXDCkZ/UC0VMoTE HdrLVSJaHs/rPXZ/a3wZqgFpSNMDcE6z+/tM3wwPgbzwuJuDOw7kf0NtrpHtNkqTD+no 5AJa+Do6M8XtkywrsXl/V9EM/wvWrHYZpubGv/kF7WhHFdcjlXbh2IeHJ9lne5S7yvMa uH96NyPJJi7kmhGgDSnB/Kb38ozYzfts+BivmHaf9mG8KK2XhXDf7capZ2JAdb3aLm2T 9JIA== X-Gm-Message-State: AOAM530WhZ9n05HXAiJhmdyrlM4FRMz74mMjhDk4xsqXJr6odVJHn6oE o2X7l9lwpuJpJdGsnCNOgAG4cp+fYr8R90zN7HR+5SU/3r0= X-Received: by 2002:a37:a483:: with SMTP id n125mr10319qke.286.1599297943598; Sat, 05 Sep 2020 02:25:43 -0700 (PDT) MIME-Version: 1.0 References: <20200902185624.15044-1-Vijaikumar_Kanagarajan@mentor.com> <6deeccbb-0139-4dc3-96f8-43f48d33d1c0n@googlegroups.com> <20200905110445.6a7dbf28@md1za8fc.ad001.siemens.net> In-Reply-To: <20200905110445.6a7dbf28@md1za8fc.ad001.siemens.net> From: vijai kumar Date: Sat, 5 Sep 2020 14:55:33 +0530 Message-ID: Subject: Re: [PATCH v2 00/10] WIC update To: Henning Schild Cc: isar-users Content-Type: multipart/alternative; boundary="000000000000d17b1d05ae8d9165" X-TUID: aa1SCIMstRzZ --000000000000d17b1d05ae8d9165 Content-Type: text/plain; charset="UTF-8" On Sat, 5 Sep 2020 at 2:34 PM, Henning Schild wrote: > This looks good at a first glance, left some comments. > > > > I assume the isar tests work with it. We already heard from Jan that he > > tested it on one of his layers. Did you happen to test it on one of you > > mentor layers, maybe a board with a "complex" wic setup. > We tested with isar siemens and jailhouse images project. I didnt test with our mentor layers though. It is there in pipeline. Maybe in coming weeks I would give it a try. Thanks, Vijai Kumar K > > > Henning > > > > On Wed, 2 Sep 2020 22:46:18 -0700 (PDT) > > "vijaikumar....@gmail.com" wrote: > > > > > If there are no review comments, can this get merged to next? > > > > > > Thanks, > > > Vijai Kumar K > > > > > > On Thursday, September 3, 2020 at 12:26:57 AM UTC+5:30 > > > vijaikumar_...@mentor.com wrote: > > > > > > > Changes since RFC(v1): > > > > > > > > - P9 commit is upstreamed and replaced with the version from > > > > OE-core. > > > > - P10: Lot of downstream projects tend to use /boot mountpoints for > > > > bootloader/EFI > > > > partitions. Added RECIPE-API-CHANGELOG entry to warn user about > > > > potential issues > > > > that might arise when doing so with latest wic. > > > > > > > > Henning Schild (1): > > > > lib/oe/path: try hardlinking instead of guessing when it might fail > > > > > > > > Paul Barker (1): > > > > oe.path: Add copyhardlink() helper function > > > > > > > > Vijai Kumar K (8): > > > > wic: Update to the latest wic from openembedded core > > > > wic/plugins: Fix wic plugins to work with the latest wic > > > > wic-img: Satisfy the quirks of latest wic > > > > wic_fakeroot: Handle standalone pseudo invocations > > > > meta-isar/conf: Add provision to debug WIC > > > > debian-common: Add tar as a dependency for wic > > > > wic: misc: Add /bin to the list of searchpaths > > > > meta-isar/canned-wks: Remove /boot mountpoint > > > > > > > > RECIPE-API-CHANGELOG.md | 17 + > > > > meta-isar/conf/local.conf.sample | 3 + > > > > .../lib/wic/canned-wks/common-isar.wks.inc | 2 +- > > > > .../scripts/lib/wic/canned-wks/hikey.wks | 2 +- > > > > .../lib/wic/canned-wks/sdimage-efi.wks | 2 +- > > > > meta/classes/wic-img.bbclass | 15 +- > > > > meta/conf/distro/debian-common.conf | 3 +- > > > > meta/lib/oe/path.py | 27 +- > > > > .../wic/plugins/source/bootimg-efi-isar.py | 2 +- > > > > .../wic/plugins/source/bootimg-pcbios-isar.py | 9 +- > > > > .../lib/wic/plugins/source/rootfs-u-boot.py | 2 +- > > > > scripts/lib/scriptpath.py | 32 ++ > > > > scripts/lib/wic/__init__.py | 14 +- > > > > scripts/lib/wic/canned-wks/common.wks.inc | 2 +- > > > > .../directdisk-bootloader-config.cfg | 8 +- > > > > .../lib/wic/canned-wks/efi-bootdisk.wks.in | 3 + > > > > scripts/lib/wic/canned-wks/mkhybridiso.wks | 2 +- > > > > scripts/lib/wic/canned-wks/qemuriscv.wks | 3 + > > > > .../lib/wic/canned-wks/qemux86-directdisk.wks | 2 +- > > > > .../lib/wic/canned-wks/sdimage-bootpart.wks | 4 +- > > > > .../lib/wic/canned-wks/systemd-bootdisk.wks | 4 +- > > > > scripts/lib/wic/engine.py | 421 +++++++++++++++- > > > > scripts/lib/wic/filemap.py | 170 ++++--- > > > > scripts/lib/wic/help.py | 401 ++++++++++++++-- > > > > scripts/lib/wic/ksparser.py | 115 +++-- > > > > scripts/lib/wic/{utils => }/misc.py | 100 ++-- > > > > scripts/lib/wic/partition.py | 234 ++++----- > > > > scripts/lib/wic/pluginbase.py | 36 +- > > > > scripts/lib/wic/plugins/imager/direct.py | 175 ++++--- > > > > .../wic/plugins/source/bootimg-biosplusefi.py | 213 +++++++++ > > > > scripts/lib/wic/plugins/source/bootimg-efi.py | 111 +++-- > > > > .../wic/plugins/source/bootimg-partition.py | 153 ++++-- > > > > .../lib/wic/plugins/source/bootimg-pcbios.py | 91 ++-- > > > > scripts/lib/wic/plugins/source/fsimage.py | 56 --- > > > > .../wic/plugins/source/isoimage-isohybrid.py | 185 +++---- > > > > scripts/lib/wic/plugins/source/rawcopy.py | 44 +- > > > > scripts/lib/wic/plugins/source/rootfs.py | 159 ++++-- > > > > scripts/lib/wic/utils/__init__.py | 0 > > > > scripts/lib/wic/utils/runner.py | 114 ----- > > > > scripts/wic | 452 +++++++++++++----- > > > > scripts/wic_fakeroot | 5 + > > > > 41 files changed, 2357 insertions(+), 1036 deletions(-) > > > > create mode 100644 scripts/lib/scriptpath.py > > > > create mode 100644 scripts/lib/wic/canned-wks/efi-bootdisk.wks.in > > > > create mode 100644 scripts/lib/wic/canned-wks/qemuriscv.wks > > > > rename scripts/lib/wic/{utils => }/misc.py (70%) > > > > create mode 100644 > > > > scripts/lib/wic/plugins/source/bootimg-biosplusefi.py delete mode > > > > 100644 scripts/lib/wic/plugins/source/fsimage.py delete mode 100644 > > > > scripts/lib/wic/utils/__init__.py delete mode 100644 > > > > scripts/lib/wic/utils/runner.py > > > > > > > > -- > > > > 2.17.1 > > > > > > > > > > > > > > > --000000000000d17b1d05ae8d9165 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sat, 5 Sep 2020 at 2:34 PM, Henning Schild <henning.schild@siemens.com> w= rote:
This looks good at a first gl= ance, left some comments.



I assume the isar tests work with = it. We already heard from Jan that he

tested it on one of his layers= . Did you happen to test it on one of you

mentor layers, maybe a boa= rd with a "complex" wic setup.
=
We tested with isar siemens and jailhouse image= s project. I didnt test with our mentor layers though. It is there in pipel= ine. Maybe in coming weeks I would give it a try.
Thanks,
Vijai Kumar K




Hen= ning



On Wed, 2 Sep 2020 22:46:18 -0700 (PDT)

"vijaikumar....@= gmail.com" <vijaikumar.kanagarajan@gmail.com> wrote:

<= br>
> If there are no review comments, can this get merged to next?
>

> Thanks,

> Vijai Kumar K

>
<= br>> On Thursday, September 3, 2020 at 12:26:57 AM UTC+5:30

>= vijaikumar_= ...@mentor.com wrote:

>

> > Changes since RFC(v= 1):

> >

> > - P9 commit is upstreamed and replac= ed with the version from

> > OE-core.

> > - P10:= Lot of downstream projects tend to use /boot mountpoints for

> = > bootloader/EFI

> > partitions. Added RECIPE-API-CHANGELO= G entry to warn user about

> > potential issues

> &= gt; that might arise when doing so with latest wic.

> >
> > Henning Schild (1):

> > lib/oe/path: try hardlink= ing instead of guessing when it might fail

> >

> &g= t; Paul Barker (1):

> > oe.path: Add copyhardlink() helper fu= nction

> >

> > Vijai Kumar K (8):

> &= gt; wic: Update to the latest wic from openembedded core

> > = wic/plugins: Fix wic plugins to work with the latest wic

> > = wic-img: Satisfy the quirks of latest wic

> > wic_fakeroot: H= andle standalone pseudo invocations

> > meta-isar/conf: Add p= rovision to debug WIC

> > debian-common: Add tar as a depende= ncy for wic

> > wic: misc: Add /bin to the list of searchpath= s

> > meta-isar/canned-wks: Remove /boot mountpoint

&= gt; >

> > RECIPE-API-CHANGELOG.md | 17 +

> > = meta-isar/conf/local.conf.sample | 3 +

> > .../lib/wic/canned= -wks/common-isar.wks.inc | 2 +-

> > .../scripts/lib/wic/canne= d-wks/hikey.wks | 2 +-

> > .../lib/wic/canned-wks/sdimage-efi= .wks | 2 +-

> > meta/classes/wic-img.bbclass | 15 +-

= > > meta/conf/distro/debian-common.conf | 3 +-

> > meta= /lib/oe/path.py | 27 +-

> > .../wic/plugins/source/bootimg-ef= i-isar.py | 2 +-

> > .../wic/plugins/source/bootimg-pcbios-is= ar.py | 9 +-

> > .../lib/wic/plugins/source/rootfs-u-boot.py = | 2 +-

> > scripts/lib/scriptpath.py | 32 ++

> >= ; scripts/lib/wic/__init__.py | 14 +-

> > scripts/lib/wic/can= ned-wks/common.wks.inc | 2 +-

> > .../directdisk-bootloader-c= onfig.cfg | 8 +-

> > .../lib/wic/canned-wks/efi-bootdisk.wks= .in | 3 +

> > scripts/lib/wic/canned-wks/mkhybridiso.wks = | 2 +-

> > scripts/lib/wic/canned-wks/qemuriscv.wks | 3 +
> > .../lib/wic/canned-wks/qemux86-directdisk.wks | 2 +-
> > .../lib/wic/canned-wks/sdimage-bootpart.wks | 4 +-

> = > .../lib/wic/canned-wks/systemd-bootdisk.wks | 4 +-

> > s= cripts/lib/wic/engine.py | 421 +++++++++++++++-

> > scripts/l= ib/wic/filemap.py | 170 ++++---

> > scripts/lib/wic/help.py |= 401 ++++++++++++++--

> > scripts/lib/wic/ksparser.py | 115 += ++--

> > scripts/lib/wic/{utils =3D> }/misc.py | 100 ++-- =

> > scripts/lib/wic/partition.py | 234 ++++-----

>= > scripts/lib/wic/pluginbase.py | 36 +-

> > scripts/lib/w= ic/plugins/imager/direct.py | 175 ++++---

> > .../wic/plugins= /source/bootimg-biosplusefi.py | 213 +++++++++

> > scripts/li= b/wic/plugins/source/bootimg-efi.py | 111 +++--

> > .../wic/p= lugins/source/bootimg-partition.py | 153 ++++--

> > .../lib/w= ic/plugins/source/bootimg-pcbios.py | 91 ++--

> > scripts/lib= /wic/plugins/source/fsimage.py | 56 ---

> > .../wic/plugins/s= ource/isoimage-isohybrid.py | 185 +++----

> > scripts/lib/wic= /plugins/source/rawcopy.py | 44 +-

> > scripts/lib/wic/plugin= s/source/rootfs.py | 159 ++++--

> > scripts/lib/wic/utils/__i= nit__.py | 0

> > scripts/lib/wic/utils/runner.py | 114 ----- =

> > scripts/wic | 452 +++++++++++++-----

> > sc= ripts/wic_fakeroot | 5 +

> > 41 files changed, 2357 insertion= s(+), 1036 deletions(-)

> > create mode 100644 scripts/lib/sc= riptpath.py

> > create mode 100644 scripts/lib/wic/canned-wks= /efi-bootdisk.wks.in

> > create mode 100644 scripts/lib/= wic/canned-wks/qemuriscv.wks

> > rename scripts/lib/wic/{util= s =3D> }/misc.py (70%)

> > create mode 100644

> = > scripts/lib/wic/plugins/source/bootimg-biosplusefi.py delete mode
<= br>> > 100644 scripts/lib/wic/plugins/source/fsimage.py delete mode 1= 00644

> > scripts/lib/wic/utils/__init__.py delete mode 100644=

> > scripts/lib/wic/utils/runner.py

> >

= > > --

> > 2.17.1

> >

> >=C2= =A0

>



--000000000000d17b1d05ae8d9165--