From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7333976923876360192 X-Received: by 2002:a2e:22c4:0:b0:2d0:f210:34a9 with SMTP id i187-20020a2e22c4000000b002d0f21034a9mr2425367lji.4.1707730584708; Mon, 12 Feb 2024 01:36:24 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:b0cc:0:b0:2d0:e298:25c6 with SMTP id g12-20020a2eb0cc000000b002d0e29825c6ls891500ljl.0.-pod-prod-07-eu; Mon, 12 Feb 2024 01:36:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHC6QJzaX65MmPX8ot/5pPx8/ynWtD7aWvO2GNsdp60l+lyohnYTAp0WSlWW98hSbIeI6e7 X-Received: by 2002:a05:6512:1287:b0:511:3a13:158 with SMTP id u7-20020a056512128700b005113a130158mr4648887lfs.35.1707730582626; Mon, 12 Feb 2024 01:36:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707730582; cv=pass; d=google.com; s=arc-20160816; b=ZCqc+sNbq/kUhc5/8gDMUhblsfvxc8wb4E0xh5d9ocTilV3F+xDQJ1Ao7mx7Urbfbu IgmfQJn9yK6sLFr6+Ip5EhR3pFcuArNgYNa50HHZ6QpcWusRfkIB8d13/tgDPtPpsd9+ b8dZ8ij5zDTcQuSzV76nU7feKZmcOzGmo5nX3tdbRHMpTbb1x8JJYau3tPWbo+4nehpY ftV8SlbsmMqGHMEdaprCsmybPOsO5xNtgNqotWGPFd1/0ThPm4nZSo8xEAqPZVp9JCV/ JX8wp1EfMxosal2mz56MY6K1Khc51m3PrVb7eJ//OU91J0xODrLY0JkSyu/gTJPGP6Mi oChA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:msip_labels:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:to:from:dkim-signature; bh=wdzr8sf/51TB7zeR8q8MjjmRgaLSk2fmf+j0N0ILTv0=; fh=VQF2DgB+HNyXTQVP6kGO+1QkJXNncHlLaRFCPXCtwMI=; b=PoGgGeCOQqSEpozwTkdv3PFadvfWtHUAqhLmwdcJsY87eMARhuaDwmXyjCFeln8HMi JbaqglyImgHA739fG18kqWI9xpscYLlKIgjqSurJrK1ZmGew3QLh3hATjzyumkl4tpvT fvATdplxoWWU5VHyYWobaHxPy7fQ3mXmq8wiguMbAakXK5J4CIvheQ8V6xz4gwa/2joZ +W9u8DZOfVOU8yD6aQaj7A5vEpR59yLbDyDPjFyJ/sWOO0+0LBmT/BOSn3dLB+GyyCo7 worpjZrVtheT8RI7RvN1NOnzPYtxVi7j14VUhHPeQpBg7V6taZxTRZz3sYPwTi/oO+N8 G8pQ==; dara=google.com ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=F64cKt+x; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of nicusor.huhulea@siemens.com designates 2a01:111:f403:2612::600 as permitted sender) smtp.mailfrom=nicusor.huhulea@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Forwarded-Encrypted: i=2; AJvYcCVdk6Hz1UMFcultyki5FO5DTmV1TQODp25RTula0bIlr+I9qD6o7p3TGp9QLT1VQTvJn88Glu20ESWFG+jZFskQZ0xMx05H7ZHqIoQ= Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20600.outbound.protection.outlook.com. [2a01:111:f403:2612::600]) by gmr-mx.google.com with ESMTPS id fc20-20020a056512139400b00511429b36e7si358443lfb.1.2024.02.12.01.36.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2024 01:36:22 -0800 (PST) Received-SPF: pass (google.com: domain of nicusor.huhulea@siemens.com designates 2a01:111:f403:2612::600 as permitted sender) client-ip=2a01:111:f403:2612::600; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=F64cKt+x; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of nicusor.huhulea@siemens.com designates 2a01:111:f403:2612::600 as permitted sender) smtp.mailfrom=nicusor.huhulea@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GjAqdEI6E2gUWQV6clTprSnlXu2ZwcFjk5u6DqlGDfD3hYsafEZHbgNAm7f64cu7gMVOMiyXDDeE+f678uWRdIo06oNLD2YAPtqCXUHuGB/kXLClsyzXx6B/zqRd1K8d9j+Uxj2WIRKMvFPAt9vFLzgF5aPRvAb9QKSQNBieD/fUWjPmx1K3B39yiT3Yp5IFReRcxx0EA3BWhM9w6hRgf8WVkPnGiP/cHlo2xVbJh4qCd47uommV5EzIut+aCIEDTFNXKdejDEzumK3ibXlSKsfltUrPkG58hts6gahyf5EO0e2aT3dtJq8G90UhjsC37TaOIYanqt1yz8rZLuELWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wdzr8sf/51TB7zeR8q8MjjmRgaLSk2fmf+j0N0ILTv0=; b=Wy2Uxqh6H4fPtMYzPRqmLOr9eywLwQPx85n92KgLzFVuNsAE/nJ3Nc/e+3b0xQRBhs9yJ3A2xkGmgUrxfpMtRa7iOzXXMrpt708X7chyVsv0w7p3HSAAJYwF2EakyZJS/FhbAjBJyJVviwzPS41ZrVlhaTgSGq7BsXkzn9O1qkAuJ+7qWlAzSeIJcj2BI1943ZUIEktMwY0fUsePxJQQ1U6cUc96+WRZCNPsWJufxwuSsfGk5T8raMvmuUFPsYlXBO0IsAtMX6X+2qxLWLhMB6NSsDAT2Fbup6TfxZN26nauDQnxk1Omde51WsJz8bu1f0MfBzUPS/+7P9Ok+40e4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wdzr8sf/51TB7zeR8q8MjjmRgaLSk2fmf+j0N0ILTv0=; b=F64cKt+x5QrvAChDpxwkPVEr+iGDwWbKj322XpYfaXDTjz49VrrMxNrHxgXKhgMaImF71fUYREd7rxGSCeS0S48Qx635Q70Z9nANGO6Sm6w7FfI4HpYZGAw4/Rbx92/GUkaMQdNzlHuiVDLwgD8whTRYkebBaWm2hTHd3ZCPJ0PT6Fmv7DbA84G5JR2ZJ09J1XQjbHA4QY47xLlVJpS0zwHKF0q5ZKOKubM/BWxD165BdrU7zo74rOvKGnd15l4qwo/KW4VloGvjzHVGz1O8MVMSDsoYX5I4aNggvwwdFLkHS6cY+XUH7yzYK8rdo0Yb8S508ipljMGHNDrxhTanMg== Received: from DB3PR10MB6908.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:431::21) by DB9PR10MB5306.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:338::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.33; Mon, 12 Feb 2024 09:36:20 +0000 Received: from DB3PR10MB6908.EURPRD10.PROD.OUTLOOK.COM ([fe80::3638:8d9f:c5d4:43c4]) by DB3PR10MB6908.EURPRD10.PROD.OUTLOOK.COM ([fe80::3638:8d9f:c5d4:43c4%7]) with mapi id 15.20.7270.033; Mon, 12 Feb 2024 09:36:20 +0000 From: "nicusor.huhulea@siemens.com" To: "Kiszka, Jan" , "isar-users@googlegroups.com" Subject: Re: [PATCH] classes/images.bbclass: don't copy the dtbs if they exist already Thread-Topic: [PATCH] classes/images.bbclass: don't copy the dtbs if they exist already Thread-Index: AQHaW2Ayirw4c9vr00eE26io+nLnVrEFHU4AgAFRen0= Date: Mon, 12 Feb 2024 09:36:20 +0000 Message-ID: References: <4c06659b-e7e8-442e-bdac-de7127d1a9a2@siemens.com> In-Reply-To: <4c06659b-e7e8-442e-bdac-de7127d1a9a2@siemens.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Enabled=True;MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_SetDate=2024-02-12T09:36:19.888Z;MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Name=C1 - Restricted;MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_ContentBits=0;MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DB3PR10MB6908:EE_|DB9PR10MB5306:EE_ x-ms-office365-filtering-correlation-id: 569ccbd7-28f8-49bc-0405-08dc2bae11c3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Dab/9WIhhqE70T5WJOxYkhchBiPYNnwApf23VAVxPzTjOegzc9VTwwIxwv8TjVMzvaxWnXpwmQJmIPS1RicT9oX16MNNTgDDBQojGd33E3gorpHj7xn7p11Rtw2icQuNnWq96Eh68vfVfHiRlJBFwbQid4WgK8xe1oxC1XqLKfP0UnpXpjt3BwxVDZm+olRLjSNsd8K82evglM9Alx6quTJ4uXagdwsWITORWLS7aZ1Nd+L9rbMcBypUVqXQlY4RtumIDGUVttAfJtVHlKDKHYQ9l7wTG6h+oWp57fWW6sqLntOowBapxMTC3tSmckPNulXLtkA/ztFZFKTmo+h8Emx+Mdip0GYKPM4RZ5v0EXZO/oUnZKbH2zWR9jkzmBiA6ryCj8fzIV9Sq3J1ZEetWJofzGqMSFdC01SYAvu4YfnOLzuXAfoIcJnQ+qaSFrxGzyeUeLc1fU4qAwX6I/wDthkACosEJwG9yqYicIhodIVtkWobNZXWPCnUyxI981snw8Q5qIgwxaoWCAmOpT6sVKYKslr5O085edyvp0Vb6IZZ1tkvMw0UF846I4SkOqjkFVQH+ewZyUr7TtEZ2H9UloZpN6R0do0kewa4z4pQxmw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB3PR10MB6908.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(366004)(346002)(376002)(396003)(136003)(230922051799003)(64100799003)(186009)(1800799012)(451199024)(5660300002)(52536014)(64756008)(8676002)(76116006)(91956017)(66556008)(66946007)(2906002)(66446008)(66476007)(122000001)(86362001)(38100700002)(33656002)(83380400001)(38070700009)(478600001)(110136005)(82960400001)(53546011)(7696005)(6506007)(9686003)(316002)(26005)(41300700001)(45080400002)(71200400001)(8936002)(55016003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?S+I7QM9P0UVpp+HH3xloTPdCT/MWussolqw2o8WPiWWg5nYBN4DhjD2w8r?= =?iso-8859-1?Q?8iF1xpORGfgkV65Am9rJSpFpgo1h2aW1HDG/6j9J7LrseEru0Ktm/Uig/o?= =?iso-8859-1?Q?iKyS177vlz+ccwuPtCIiN5H5GccVwAuQW8A7pZSI1QwdCbLdJTpX9ixK4C?= =?iso-8859-1?Q?Kc70mnl7CSYd7/Q2wtpTxVxBsW5+wYS0OwEUOtuZX1jMX3tdWQIZ85RrRa?= =?iso-8859-1?Q?/Oust4KRK2DYPBc56rDap7gBvr6R1vy6uCeYYYh7dK1+Xl1dhV05VeWSdm?= =?iso-8859-1?Q?9sjzhFWtdzpcqgMrvmav3dWUS6N05msC4WFCbQ8hgaukLBd0JsjbV7HfIY?= =?iso-8859-1?Q?uLiZvf7bpIpnVVj84eXs2x1LB5XFi6PKLIzSoJY0ajb7KJqkCm6YVwHXJx?= =?iso-8859-1?Q?llWw1B9DTE2uD35a245BH2pCCmiZw/zSuGru5HX3m9DPa4usqRrDh1kHq4?= =?iso-8859-1?Q?2iaUpcHS1z4/TrQGgREeL4LuR2mbexTZ9itQUvGzNdokc291iknMm9mtMd?= =?iso-8859-1?Q?aeK4m/fORwqMhNAJoyuKofXvkzMETJpk1YbQKgnygrDzvyAN2FivGsp/Oj?= =?iso-8859-1?Q?7NIs/dEL8jFVh5LwCH+J8SALnWRhSBRs7YECshbTWRU4C4s2L0oYay7igx?= =?iso-8859-1?Q?3SwznJAQGtqG2rSvToV8Jkkfpfw5JFakc/SefzM3fnyE72cl5vANJQo4eJ?= =?iso-8859-1?Q?srqtduOeJyh0gYX2JhK4Mo92Ags4Tzu5EBQ4kHK60ThTcQXdRgeJO3e7E1?= =?iso-8859-1?Q?oJT0o1KuytYAlFc4X0zfk4RcQoBLzh+mco4va3aPYKPTZx6NOpMSF/wb+8?= =?iso-8859-1?Q?2R+EeGkRyq1Ls9CQ4VyoiLgI+Ru8qW/MuASimhCVHoeVj3WxEc9VOOZAa7?= =?iso-8859-1?Q?fUTJU8MT8wFev/+/qv6K4iA6es9g2biZer/kX1dFTorH0uyQk51j4OgaMf?= =?iso-8859-1?Q?py1VL+u9jFrbNWHws0u8gT/lOj00osBL77ncKsXfL5CZr4Dt1iCa/Lylrl?= =?iso-8859-1?Q?2YCV0mJOWp17PFq5LYqRLJbkIl4T3dPDKAPzrkNVE/Aez1PzS5bHfwPlLz?= =?iso-8859-1?Q?kxibDWVrQBejuxB1gAmKyTH/9XmV7sepGVW+E7YW4raqFjaHTLrf98LVE4?= =?iso-8859-1?Q?UI7OIffMvB2OeBBE4Z3jH1l54e7fwWkwf9BuS/lqguwM7oufLIgv1nbQK9?= =?iso-8859-1?Q?d6ldtA4Wxnq23kOIyDpB3xxPHVmbnxY0yKUUfDi9w8/8O1Tspi23dzn1tM?= =?iso-8859-1?Q?/4cbJWIbSNXPsNUF98P1rJzj1IhjctA1ENTzHVYqOlHf8CW+GRadJDYoxk?= =?iso-8859-1?Q?+E9gc4xGikEbezvStCuoubp8Mc0zTNPigsH6iv2lNlKeY7+OShnZ9ynk6C?= =?iso-8859-1?Q?uITtwhB/WuMFqZalM40QT24FfkN5oQkAQ2Hzh1v4ThUnezafn1EAOJB7sL?= =?iso-8859-1?Q?Xjq91oojMMng/2ID+jXbDJB/oBKcRX6YFUqTl2FjPzWhbf76ds9LASRmjp?= =?iso-8859-1?Q?JwCuw4m2Jud+FwJg6u6vPFzvNU36rT7rZFoTEJovDwbcCR6B650R5KRJVu?= =?iso-8859-1?Q?i1axXNXssBNBkjy2lRXFTraHvRqzDCcYmnvJhI3FBp7AQ0ysi2RyudPyHq?= =?iso-8859-1?Q?UwNbpKJZnAykkcG/JrP/sJLRsw+QOCOch2?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB3PR10MB6908.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 569ccbd7-28f8-49bc-0405-08dc2bae11c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2024 09:36:20.1702 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1RdVlvUzdOTKeoG3uxaxIz4K6bh/UAjnjTS/F5iu4Mp/J2xjIYAW/Mx6HToTL8o2QencFBSeGY/+XYPS0AyseQ4/15tWKtZKJilQODOjk2I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB5306 X-TUID: 5gxdTpsMhbjQ ________________________________________ From: Kiszka, Jan (T CED) Sent: Sunday, February 11, 2024 2:58 PM To: Huhulea, Nicusor Liviu (DI CTO FDS CES LX SVCS); isar-users@googlegroup= s.com Subject: Re: [PATCH] classes/images.bbclass: don't copy the dtbs if they ex= ist already On 09.02.24 15:17, 'nicusor.huhulea@siemens.com' via isar-users wrote: > This usually reproduces when more than one image is being build and it > uses the same files for boot e.g dtb > I can reproduce this using the upstream > meta-iot2050(https://github.com/siemens/meta-iot2050 > ) when trying > to build iot2050-image-example followed by a build on a > iot2050-image-swu-example > Please send patches inline. And send plaintext emails, not HTML. Sorry about this. > From 639ce9ecfb2d323a1798533884a53151bd74b202 Mon Sep 17 00:00:00 2001 > From: Nicusor Huhulea > Date: Fri, 9 Feb 2024 10:44:26 +0200 > Subject: [PATCH] classes/images.bbclass: don't copy the dtbs if they exis= t > already > > * with the introduction of do_copy_boot_files_setscene having the same > file in the same location does not seems possible anymore, so copy tho= se > files only if they don't exist. > * ERROR: development-image-1.0-r21 do_copy_boot_files_setscene: The reci= pe development-image is trying to install files into a shared area when tho= se files already exist. Those files and their manifest location are: > /home/nhuhulea/indOs/next/build-ipc-edition/tmp/deploy/images/iot2050/k= 3-am6548-iot2050-advanced-sm.dtb > (matched in manifest-arm64-service-stick-image.copy_boot_files) > > Signed-off-by: Nicusor Huhulea > --- > meta/classes/image.bbclass | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index d9fc04eb..070a14dd 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -393,7 +393,10 @@ do_copy_boot_files() { > die "${file} not found" > fi > > - cp -f "$dtb" "${DEPLOYDIR}/" > + dtb_name=3D$(basename "${file}") > + if [ ! -f "${DEPLOY_DIR_IMAGE}/${dtb_name}" ]; then > + cp -f "$dtb" "${DEPLOYDIR}/" > + fi What if the two files are actually different, eg. after updating the kernel recipe and rebuilding things? And what about the other things we deploy here? Jan I see the use case and I agree that this doesn't seem to be a valid solutio= n. I have analyzed on my side a few possible ways to have a much better soluti= on: 1. Renaming the other dtbs to avoid conflicts and doesn't seem to be the ri= ght approach 2. modify one of the recipe to use a different deploy directory e.g: "${TM= PDIR}/deploy-recipeA/" 3. instead of installing to "${DEPLOY_DIR}", recipeA should install to "${D= EPLOY_DIR}/recipeA" 4. creating separate directories within the deploy directory for each packa= ge right now all the things goes to a 'deploy' folder, I would see this so= mething like e.g: DEPLOYDIR_image_A =3D "${DEPLOYDIR}"/deploy-image_A" DEPLOYDIR_image_B =3D "${DEPLOYDIR}"/deploy-image_B" items 1,2 and 3 seem to require intervention from an isar user. I need to m= odify the other recipe. item 4 seem to require changes to the isar layer. Nicu > done > } > addtask copy_boot_files before do_rootfs_postprocess after do_rootfs_ins= tall > -- > 2.39.2 -- Siemens AG, Technology Linux Expert Center