RE: [PATCH 1/2] feat: package linux-perf-<version> in kernel recipe

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

Hi Baurzhan,

Thanks for the review.
I'll change that in the next version.

In the meantime, I discovered that there are still a couple of things missing for Debian bullseye.
They added version bindings between linux-perf and linux-perf-<version>, so we have to build the linux-perf package as well.
I'll do that in v2 as well.

Apart from that: IMO doing the debianization of the kernel tools (also kselftest) in the kernel recipe is way better than having it in a dedicated recipe.
Using this approach, it is also possible to use an upstream kernel, but our perf package.
Technically, we then have to fetch and build the whole kernel manually, but only the perf packages are installed.
That's a bit of extra work (which could be avoided if we check inside the kernel recipe which target is attracted. Don't know if that's possible).

One issue with mixing upstream kernels and custom tools is still that we do not have a guarantee that these will still work when the kernel gets updated via APT.
Maybe we should pin the kernel as well...

Best regards,
Felix

> -----Original Message-----
> From: isar-users@googlegroups.com <isar-users@googlegroups.com> On
> Behalf Of Baurzhan Ismagulov
> Sent: Wednesday, February 17, 2021 11:29 AM
> To: isar-users@googlegroups.com
> Subject: Re: [PATCH 1/2] feat: package linux-perf-<version> in kernel recipe
> 
> On Thu, Jan 21, 2021 at 11:52:23AM +0100, Felix Moessbauer wrote:
> > diff --git
> > a/meta/recipes-kernel/linux/files/debian/rules.d/tools/perf/Makefile
> > b/meta/recipes-kernel/linux/files/debian/rules.d/tools/perf/Makefile
> ...
> > +%:
> > +	CFLAGS= LDFLAGS= dh $@ --parallel
> > +
> 
> > diff --git a/meta/recipes-kernel/linux/linux-tools.inc
> > b/meta/recipes-kernel/linux/linux-tools.inc
> ...
> > +    d.appendVar('KBUILD_DEPENDS', d.getVar('PERF_BUILD_DEPENDS')) }
> > +
> 
> 
> Extra newlines.
> 
> 
> > diff --git a/meta/recipes-kernel/linux/linux-tools.inc
> > b/meta/recipes-kernel/linux/linux-tools.inc
> ...
> > +PERF_BUILD_DEPENDS = "\
> > +   asciidoctor <!stage1 !nodoc !pkg.linux.notools !nopython>, \
> 
> Inconsistent indentation, suggest 4 spaces.
> 
> 
> > diff --git a/meta/recipes-kernel/linux/linux-tools.inc
> > b/meta/recipes-kernel/linux/linux-tools.inc
> ...
> > +python() {
> > +    if d.getVar('KERNEL_PACKAGE_PERF') != '1':
> > +      return
> > +    try:
> > +      kvers = d.getVar('PV', True).split('.')
> > +    except:
> > +      bb.warn('could not extract kernel version. Disabling perf support. Version
> provided: {}'.format(d.getVar('PV', True)))
> > +      d.setVar('KERNEL_PACKAGE_PERF', '0')
> > +      return
> 
> I agree that we should at least try upstreaming the missing stuff. Also, does
> anything speak against building it as is (possibly breaking the build)?
> 
> 
> With kind regards,
> Baurzhan.
> 
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email
> to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.g
> oogle.com%2Fd%2Fmsgid%2Fisar-
> users%2F20210217102830.GB20742%2540yssyq.m.ilbers.de&amp;data=04%7C
> 01%7Cfelix.moessbauer%40siemens.com%7Cd4bc5686516141d00e2608d8d32e
> caf7%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C1%7C63749154521515
> 9014%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzI
> iLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=Ayu3mTDPJ%2F8c7u
> lMVpYEWKWp2d18cUwZmZ7iYu82gm4%3D&amp;reserved=0.