From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6919450737082630144 X-Received: by 2002:a2e:9685:: with SMTP id q5mr341858lji.344.1613635381656; Thu, 18 Feb 2021 00:03:01 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3993:: with SMTP id j19ls3356457lfu.3.gmail; Thu, 18 Feb 2021 00:03:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJz9+IaQnWUFJul3uqCjDi/w+QzNoHjbhMmrxb4WSJrSwOaENBjJ1RhtzU0CNA6PzTlIBEos X-Received: by 2002:a05:6512:986:: with SMTP id w6mr1869891lft.466.1613635380594; Thu, 18 Feb 2021 00:03:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1613635380; cv=pass; d=google.com; s=arc-20160816; b=sPz8dBV1Bdt45mep4cSicrsFxg3ZY45XjCguY6H6cIuZGL+foE64w10p933J4MqT+C DWs4GlN40Yf3vuenmXVr0txyYSxsBf/12tWS+AofQZ1bDCWAcOFG5kzJVWl3EGggabpK Kec74EzUEGbIaKHQe6Ett5cheNvl5xPALBO/l0mI7s3mB6eyal17kncPJ9Wjn7sBObyr fywSAjQwjZ+KpsjjECFGLsPEvYwb6VBi1dCqsu7AcaFtnEv1mKZuQ2hlY6/762ZjeKIN zg8cI+bCFJPL1SOVncazhrXPGSS2ApsxUiqP3d5rEw6hqeFN5PSgQYkQ5z0ABZ3l4r2z as6Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:document_confidentiality :msip_labels:content-language:accept-language:in-reply-to:references :message-id:date:content-class:thread-index:thread-topic:subject:cc :to:from:dkim-signature; bh=4AO7a/XJ/PCySrjLXQij0IjFtf//3DXiRnOMmNXLUTQ=; b=0VWhwOSl/f2gr709GRV2KsQHzTkA5X2y2hfnEdA6df1slph6Vw7jnOFP9LfuZQ7lS5 DBUoaG1nqB+xWy7a0pFzEU+9mThwBLIrtErUL/FwV9+qawEaVF7tHICPMCjQDnion46t C6+oYcZuy4jctwNXVnDnjefLQ3QLkQLTxhfHmjCE3yW6uxBHajHyT2StOeXIlDg8UcgZ wDuDPbJgOXosCS5JXUB/rHWxERz3JEcVhhPCZdOQUn7sYaNOW/AWpWX8cmO2xo9damCx Myesn26VA3B1tkkllqPNKX6yFjH5++9MojPuDWuqZRS/4UTKe1F6ix7cCyAXG5IWK4Gb 6tSA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b="jp/ZKP3D"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.1.85 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10085.outbound.protection.outlook.com. [40.107.1.85]) by gmr-mx.google.com with ESMTPS id y8si173961lfy.2.2021.02.18.00.03.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Feb 2021 00:03:00 -0800 (PST) Received-SPF: pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.1.85 as permitted sender) client-ip=40.107.1.85; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b="jp/ZKP3D"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of felix.moessbauer@siemens.com designates 40.107.1.85 as permitted sender) smtp.mailfrom=felix.moessbauer@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NsBepABz+v41QNdYLNLCk8X+6xkWtwROpGZ0QVgajF5YknDxJOtm33Ztwg36Do7OfoecqKIxQQcBklSzGbG4hp1HEXQq75zFuWuWeRRA+BnAE4usKC/+CQwKN2BbBQvYafx27buyt5EutvGhk5ClB5vYvUWKLbYZA0NV4NcF6Ph1HJxlY5OD584JqP0SV4Yqax5o3AZLJhL/UTASWUEJG94K1jJO4N1uaTTjFDaMgqPecMBpxVmT7pGO6jxAf5CzoBUWqORuVlSyzxakf+04HmCIUO776VwyBc8nWC6BCINlpByOwdLhFHDwH6zasdNG3SXj6QsTunoov9I0mJqhNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4AO7a/XJ/PCySrjLXQij0IjFtf//3DXiRnOMmNXLUTQ=; b=RcTLgxJfr21eIcNxdSE+sD4tO1ZRdY5h//1Qwq3mf1tpjyn386hdEdJ3SQcbNyh+RvuppnnhmU79rf8hB87hjcBv6CReWdUna31zCB29N+KbVOVQoPT6KETFq4sD1S4yT5UIgefYWAuQIUWmmqU2r5DzFqDUg8U7w/DTjTUgdrfxS0pzivt6FQPms3rOluhrE9+XkqzF6h2Feit5p97llxXTll5GumevqSgpN5psj6WXtbFDtYn4MzaZtFBzI1OTDI85tP3feT1GfWCg9oovOUcFt8vsSl9a1rAnBmSGWluP/qbiaDrjqRolHFOj7UrekCtxGibCDOR3QUPuR3K5vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.onmicrosoft.com; s=selector1-siemens-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4AO7a/XJ/PCySrjLXQij0IjFtf//3DXiRnOMmNXLUTQ=; b=jp/ZKP3D2aPC4m0xl054uOi389Ne82aEZ+KrwiNWPwsBJZ72CdS6C1Rqf5pEwQ2E1HYdcBWuPT/ZYZLBfiJfoBxvaFjTpyf9vBTcdzTYB2fMEl34W+SZOhij+sUrCXRS1WOc8IgaSkpK74fMZroxHg1zWGE+a4kWvk8ttV+1AtE= Received: from DB7PR10MB1948.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:5:e::28) by DB6PR10MB1832.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:6:3c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.30; Thu, 18 Feb 2021 08:01:44 +0000 Received: from DB7PR10MB1948.EURPRD10.PROD.OUTLOOK.COM ([fe80::f831:4f65:5ca:6fe0]) by DB7PR10MB1948.EURPRD10.PROD.OUTLOOK.COM ([fe80::f831:4f65:5ca:6fe0%5]) with mapi id 15.20.3846.039; Thu, 18 Feb 2021 08:01:44 +0000 From: "Moessbauer, Felix" To: Baurzhan Ismagulov , "isar-users@googlegroups.com" CC: "henning.schild@siemens.com" Subject: RE: [PATCH 1/2] feat: package linux-perf- in kernel recipe Thread-Topic: [PATCH 1/2] feat: package linux-perf- in kernel recipe Thread-Index: AQHW7+OJ4ADRuEGpjUeFqwzVyZKk3qpcT3+AgAFm+6A= Content-Class: Date: Thu, 18 Feb 2021 08:01:44 +0000 Message-ID: References: <20210121105224.26285-2-felix.moessbauer@siemens.com> <20210217102830.GB20742@yssyq.m.ilbers.de> In-Reply-To: <20210217102830.GB20742@yssyq.m.ilbers.de> Accept-Language: en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Enabled=true; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SetDate=2021-02-18T08:01:42Z; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Method=Standard; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Name=restricted-default; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ActionId=f8015b85-cda5-4697-9a8f-1035f7fc2d7c; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ContentBits=0 document_confidentiality: Restricted authentication-results: radix50.net; dkim=none (message not signed) header.d=none;radix50.net; dmarc=none action=none header.from=siemens.com; x-originating-ip: [165.225.200.160] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 04d82fcc-6fa9-4f13-103b-08d8d3e36f0c x-ms-traffictypediagnostic: DB6PR10MB1832: x-ld-processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pZDIz/VL0u2KmOOIQ/mr0PtY2fZpK0ozYSB2K0Rt/pTkBUGj7I/W+N8pcuFJ/ENYfdG9yE4fqu3xtE+D9PIfiPMZpcH8GHvlmxCG8+85uei06zPuq67SWvp3iX3LJ+EYPFd2w6m/Z3C1i9AvOmD1WWGtJ41WYYM3g9esrZYng/d0go6Qpw25+Cd6RjwZY81t4K0NC6KYS1KajPaYJDoXhWrGU1QTqP8ixd1IVgD2mbIxTos/1MAzti2C1x4rPQicdWUmf4fiTWenm4nZNFno4qbzxfmPIXUL2NaA+7GTtacjN5TWzbyhh5gp7nE60c3OiwcTdlVd/t6myoyGds6DjgvvnO2kPhNwmzN9ou5cuAlwpg/Ws0lw5crD4Zurr8GKwGBDQOYwdzYb5TqcyppFXC6Tugne69e5fpt+e+6oxiew4YYzdY1PtcklMQEiF+lJxeF376iB6Sf+GmwCDatI4oORFnGurHImwnDfLVlj7xjZhjwZEj/oh5WliYxxbYzEAgs/O0h2L+FcM5BntMO0ebD8/tP5UIW+GS2kpXsNRlNW1Oc660gPEbHBaB+G2qFTskCMdXNOIE3QBHyiO/vgHPw0X37D9dNGZFOAfVkiWjE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR10MB1948.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(136003)(396003)(376002)(366004)(55236004)(53546011)(9686003)(6506007)(71200400001)(55016002)(26005)(83380400001)(107886003)(33656002)(8936002)(2906002)(4326008)(66476007)(66556008)(64756008)(66446008)(5660300002)(86362001)(966005)(8676002)(52536014)(186003)(76116006)(478600001)(66946007)(316002)(110136005)(45080400002)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?jyPH0WKfAEGzZTGLFbVPzl/YNNHT3lpx4uQiWIGig2v2E0hTf+Eerx7rIdGR?= =?us-ascii?Q?FlCpyp9QnUQkn4YIbXd9Kg+60Lo2bG9uOq99g8lAu2klrX/bDq8x09E/FJTM?= =?us-ascii?Q?CFdmJY+O/O6rcq+nOHVelInDz2l4U3+ZxfsNKdeJDI9xbRTtzEpYaAH9OWXs?= =?us-ascii?Q?pIMLY+d4Xdx940vigfFxy6GvTyqX2RW6SUNn162twalkwWhfz3HFXDIbLUQM?= =?us-ascii?Q?FpWwfuXEacI40N8pLs2ryQ7qCifeRH+0SWxC5qMoHSGhiviOmhCMhLCojOcR?= =?us-ascii?Q?pSvlPZE93a36+T6mY4ToSjOKzTJUmxslixzHLm3sDwft+bVf9yA3x5NM/Rnw?= =?us-ascii?Q?87tVcBHwjGbsMnZQ0GDeZatNqmEsgIEBV+OGYZMPtQpRkmNfnIXbz1J6FR/a?= =?us-ascii?Q?XJpWHJOq4zZhZxMoHlPZAJFjJ+IFGMoyPRcru6Cj2647rGp0q3bukzeKLbNh?= =?us-ascii?Q?4Q1NxfIUaiZEkRxxWMx9P8ydkp5rAB6c6fmGEa7weLEML43PjmzjgDymYrzw?= =?us-ascii?Q?8D3d2f9OBitrg7pwVWNuTJWb1R+iJ+u8mMlgcnBKnpzHGDHkNSumT0H/Eg54?= =?us-ascii?Q?axNlwxyldhPN+/Jv4mWKmDvQAvPoKRksS/XSyP+bw0YsHJdfbZnrZ8NBHniq?= =?us-ascii?Q?SXEPt9dwkyM0AZW4jcGshZx8gKY6uU1b9/PUjBSHSc5GdGQE48EMGkaaQsIX?= =?us-ascii?Q?kOW/zbl6Ni4wpPqzS5df/iEv8OuQenZeqvq6GDn89WPWkNk6p3SXkLzOc5pg?= =?us-ascii?Q?4iuFhOf9G/KWgzQ8bWFAbruaUS0TC1cngh73ujOmhWFHFXXSRbCL45sDeDDX?= =?us-ascii?Q?lu+ZZcX8ZV9ZWzeU3y4ke+hY9gApyCZdsvsW5D8/eH6KEpfz7uTEzk+rcFcq?= =?us-ascii?Q?SpkImYWLn6MBpCvpRMwUwp9HoylOjxvcX8Uls0H/0ppT0yz2tUgF8Jwcpl4r?= =?us-ascii?Q?lu30RrC0x8h+IxfhwgRGAtyZ1xnDNi8yK6ZVguMrY+BMlgWX/bOchuUvKBQs?= =?us-ascii?Q?jk1iugduQXsQLX8ppdpSRW2JLPIaNWh4aqnIE3KY76CjYbAAii1y4V71QnB4?= =?us-ascii?Q?YL4XNjy2zqifIuRNnrz9AbVQAmX+OfGAHXsBp+WMc3h9ZkEmkTzHIPi8D/y0?= =?us-ascii?Q?4/JKiIcmpGDtoGSpnsrEbIEULD+A1Ip7qZBuD76oFEicOmENJn12pk1QOlXL?= =?us-ascii?Q?28EDyzHa1C4Bz84ihPkYio0FNb6tl/LR5I5Ujvf2oJUO6y3qgcxSVzLILjnk?= =?us-ascii?Q?n+MpceWVjFDh60g1rm84ZgkF8ExHEyXcOkMoTvAYxOLDsCk9COSJUctQRvXJ?= =?us-ascii?Q?+L1NIITGm6xka2Ux4f2huu3H?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB7PR10MB1948.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 04d82fcc-6fa9-4f13-103b-08d8d3e36f0c X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2021 08:01:44.5994 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EuNCjwKplDcd6jEFXctDsz/7WWwz1c45CbvTzeu/xjfwrENTSFhinb5rvIl8TsDpPQkGuKq5AKcomPkVY6VceA8ovpRy9Hjx07aGczUodgA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR10MB1832 X-TUID: fDWMZ1Ks9Kca Hi Baurzhan, Thanks for the review. I'll change that in the next version. In the meantime, I discovered that there are still a couple of things missi= ng for Debian bullseye. They added version bindings between linux-perf and linux-perf-, so= we have to build the linux-perf package as well. I'll do that in v2 as well. Apart from that: IMO doing the debianization of the kernel tools (also ksel= ftest) in the kernel recipe is way better than having it in a dedicated rec= ipe. Using this approach, it is also possible to use an upstream kernel, but our= perf package. Technically, we then have to fetch and build the whole kernel manually, but= only the perf packages are installed. That's a bit of extra work (which could be avoided if we check inside the k= ernel recipe which target is attracted. Don't know if that's possible). One issue with mixing upstream kernels and custom tools is still that we do= not have a guarantee that these will still work when the kernel gets updat= ed via APT. Maybe we should pin the kernel as well... Best regards, Felix > -----Original Message----- > From: isar-users@googlegroups.com On > Behalf Of Baurzhan Ismagulov > Sent: Wednesday, February 17, 2021 11:29 AM > To: isar-users@googlegroups.com > Subject: Re: [PATCH 1/2] feat: package linux-perf- in kernel rec= ipe >=20 > On Thu, Jan 21, 2021 at 11:52:23AM +0100, Felix Moessbauer wrote: > > diff --git > > a/meta/recipes-kernel/linux/files/debian/rules.d/tools/perf/Makefile > > b/meta/recipes-kernel/linux/files/debian/rules.d/tools/perf/Makefile > ... > > +%: > > + CFLAGS=3D LDFLAGS=3D dh $@ --parallel > > + >=20 > > diff --git a/meta/recipes-kernel/linux/linux-tools.inc > > b/meta/recipes-kernel/linux/linux-tools.inc > ... > > + d.appendVar('KBUILD_DEPENDS', d.getVar('PERF_BUILD_DEPENDS')) } > > + >=20 >=20 > Extra newlines. >=20 >=20 > > diff --git a/meta/recipes-kernel/linux/linux-tools.inc > > b/meta/recipes-kernel/linux/linux-tools.inc > ... > > +PERF_BUILD_DEPENDS =3D "\ > > + asciidoctor , \ >=20 > Inconsistent indentation, suggest 4 spaces. >=20 >=20 > > diff --git a/meta/recipes-kernel/linux/linux-tools.inc > > b/meta/recipes-kernel/linux/linux-tools.inc > ... > > +python() { > > + if d.getVar('KERNEL_PACKAGE_PERF') !=3D '1': > > + return > > + try: > > + kvers =3D d.getVar('PV', True).split('.') > > + except: > > + bb.warn('could not extract kernel version. Disabling perf suppor= t. Version > provided: {}'.format(d.getVar('PV', True))) > > + d.setVar('KERNEL_PACKAGE_PERF', '0') > > + return >=20 > I agree that we should at least try upstreaming the missing stuff. Also, = does > anything speak against building it as is (possibly breaking the build)? >=20 >=20 > With kind regards, > Baurzhan. >=20 > -- > You received this message because you are subscribed to the Google Groups > "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an= email > to isar-users+unsubscribe@googlegroups.com. > To view this discussion on the web visit > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgroup= s.g > oogle.com%2Fd%2Fmsgid%2Fisar- > users%2F20210217102830.GB20742%2540yssyq.m.ilbers.de&data=3D04%7C > 01%7Cfelix.moessbauer%40siemens.com%7Cd4bc5686516141d00e2608d8d32e > caf7%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C1%7C63749154521515 > 9014%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzI > iLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3DAyu3mTDPJ%2F8c7u > lMVpYEWKWp2d18cUwZmZ7iYu82gm4%3D&reserved=3D0.