RE: [PATCH 1/1] Re-add .wic prefix to deployed bmap file

["MOESSBAUER, FELIX JONATHAN" <felix.moessbauer@siemens.com>]

> -----Original Message-----
> From: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> Sent: Sunday, October 16, 2022 1:10 AM
> To: Schild, Henning (T CED SES-DE) <henning.schild@siemens.com>
> Cc: Moessbauer, Felix Jonathan (T CED INW-CN)
> <felix.moessbauer@siemens.com>; isar-users@googlegroups.com; Schmidt,
> Adriaan (T CED SES-DE) <adriaan.schmidt@siemens.com>; Kiszka, Jan (T CED)
> <jan.kiszka@siemens.com>
> Subject: Re: [PATCH 1/1] Re-add .wic prefix to deployed bmap file
> 
> Il giorno sab 15 ott 2022 alle ore 12:50 Henning Schild
> <henning.schild@siemens.com> ha scritto:
> >
> > Am Sat, 15 Oct 2022 11:37:58 +0200
> > schrieb "Roberto A. Foglietta" <roberto.foglietta@gmail.com>:
> >
> > > Il giorno ven 14 ott 2022 alle ore 13:51 Felix Moessbauer
> > > <felix.moessbauer@siemens.com> ha scritto:
> > > >
> > > > This patch fixes a regression introduced in edc10d9.
> > > > The bmap corresponds to the .wic file, hence it should also
> > > > contain the .wic part of the filename.
> > > >
> > >
> > > Thanks for this patch. However, the bmap tool works even if the name
> > > of that file is changed.
> >
> > It sure does. But any scripting that comes after an isar build could
> > get confused by the name change and not find the file. Like CD not
> > even deploying it.
> 
> just a matter of generalisation... :-)

Too much generalization might just break things.
The bmap file is specific to a block file, like the<image> .wic one.
There might be other imagers or deployment formats, that use a different bmap.
An with ISARs imagetypes, you can generate multiple image formats / types in a single run.
Each of these could - in theory - have its own bmap, hence just appending .bmap to the image filename is not sufficient.

In short - it's a bug I re-introduced by reverting a commit.
And this patch provides the fix. That's it.

Felix

> wicinst.sh supports .wic.bmap or .bmap, both
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co
> m%2Frobang74%2Fisar-nvidia-
> debian%2Fcommit%2Ff305954bf7934209084e9cd4c363f3cb1ca4b1d0&amp;dat
> a=05%7C01%7Cfelix.moessbauer%40siemens.com%7C9bec179e83d64168bf6c0
> 8daaed01d2c%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C638014
> 506115197709%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj
> oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdat
> a=izsy%2FYcg1Kqflnk1nmJKEe5UC42SQv4MKhb2H%2F6JFIA%3D&amp;reserved
> =0
> Best regards, R-