From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7004754512489480192 X-Received: by 2002:a65:6389:: with SMTP id h9mr10832465pgv.83.1633351909254; Mon, 04 Oct 2021 05:51:49 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a63:5963:: with SMTP id j35ls6383677pgm.9.gmail; Mon, 04 Oct 2021 05:51:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeXgX9uI95rkiQSRLknl4wFTQjm9XN5T+RVtPsnza1pGTCsCx7sM1RA8AFWeY7eaYUVNrj X-Received: by 2002:a63:a54e:: with SMTP id r14mr10740567pgu.352.1633351908599; Mon, 04 Oct 2021 05:51:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1633351908; cv=pass; d=google.com; s=arc-20160816; b=CkY76dZxGEwa5KOovHTtCtaMnQCtVBAm9GD93XH3ZvV/MtkRT7qwMzA5xOI6h6h/G5 eOY/20lBmlqj1cz73bksDLWzoPoDDFXIZPh64JrZQxlxE/SAKZ4Hs69MSLlrw0laTwIy uv5nbhqZyilMioAs0xGOLogm9xHBdoestuacsqxZfhYtvzmrswnajd9/q0jLditFxyrL QkDmlC4T/BfkauqxMO+b6rWLWM0RDzKSNEpu8HeWf59lr7+IUs6bIGm92FUA8f0L8Eyx XVqb4xyefK+KOmhIz6HxI1BoKhKukjQqzmuTN4U/cURDT8wax/zBmBkE2Xq5d1BQ++7T CRnA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=rfLynmuQtSshcayUGrmPFF9yEH0to+IwYSG+me2cuN4=; b=tJSAkPl3/0xpbno+KmXwvOVW9qCBMjz9+Bv6dL4tcYbOLwuogTtvClbmGn2roNQE6N ZIE/PWCHh11cD8ZMrfj26H+9r9Aj+2d/d0Jmc4OhOjQ03TDuVayJ4e8wBJd7uLGY4Jwh 36dtprpP9zr/T0gEy+FfLPHLg+5838kaYhgGCsgI93nN1+weCXMJxsNHux3dDv8rs3oz lm0u+9HBSzpbTWmj2pM9SVD/SdoMyxtGir47GVsJbIasD2lzx3dbu0El3zhF9PhHkHHR FLX46c6yGvMW+gDI+DugvwkKSEH1WTlaVMoWycqCLrI0EWLRUMFi6Op9OlKFlr8XQMcw U3ew== ARC-Authentication-Results: i=2; gmr-mx.google.com; arc=pass (i=1 spf=pass spfdomain=toshiba-tsip.com dkim=pass dkdomain=toshiba-tsip.com dmarc=pass fromdomain=toshiba-tsip.com); spf=pass (google.com: domain of venkata.pyla@toshiba-tsip.com designates 210.130.202.158 as permitted sender) smtp.mailfrom=Venkata.Pyla@toshiba-tsip.com Return-Path: Received: from mo-csw.securemx.jp (mo-csw1116.securemx.jp. [210.130.202.158]) by gmr-mx.google.com with ESMTPS id r14si1354841pgv.3.2021.10.04.05.51.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Oct 2021 05:51:48 -0700 (PDT) Received-SPF: pass (google.com: domain of venkata.pyla@toshiba-tsip.com designates 210.130.202.158 as permitted sender) client-ip=210.130.202.158; Authentication-Results: gmr-mx.google.com; arc=pass (i=1 spf=pass spfdomain=toshiba-tsip.com dkim=pass dkdomain=toshiba-tsip.com dmarc=pass fromdomain=toshiba-tsip.com); spf=pass (google.com: domain of venkata.pyla@toshiba-tsip.com designates 210.130.202.158 as permitted sender) smtp.mailfrom=Venkata.Pyla@toshiba-tsip.com Received: by mo-csw.securemx.jp (mx-mo-csw1116) id 194CpklM008291; Mon, 4 Oct 2021 21:51:46 +0900 X-Iguazu-Qid: 2wGrDIThyQSEVGuk9x X-Iguazu-QSIG: v=2; s=0; t=1633351905; q=2wGrDIThyQSEVGuk9x; m=YxyamfPPAnLGkCmAPu3DYCiToRUt6+N9dtRXCFKUtOk= Received: from imx2-a.toshiba.co.jp (imx2-a.toshiba.co.jp [106.186.93.35]) by relay.securemx.jp (mx-mr1113) id 194CpiL7030975 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 4 Oct 2021 21:51:45 +0900 Received: from enc01.toshiba.co.jp (enc01.toshiba.co.jp [106.186.93.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by imx2-a.toshiba.co.jp (Postfix) with ESMTPS id D8AA41000B5; Mon, 4 Oct 2021 21:51:44 +0900 (JST) Received: from hop001.toshiba.co.jp ([133.199.164.63]) by enc01.toshiba.co.jp with ESMTP id 194Cpihf014980; Mon, 4 Oct 2021 21:51:44 +0900 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WO8TYDDlDS3AyBTDVVGX4pTY2zBfISUJUioIxXXaql2tPlnfkb/mGHzlO08h0pWQwGLsR53vetBH+TRKRWq8c4gNe4JomA3DKbdRw7B6ztvEQRcJbTwBqIEpZgXFjQ3AqdDeQCbEGh0S78QkWrkXKbTPuI/VneiSuDBiIXIvL7lJwJ4T3Z2bQYU3jvbSjvPzJL4jOOIhte8b5CNVWjVZATCscxiYdag3veZUFZDYsQMOOSJVi6xzlhGf/50C/x6RxLa3lf0Y3CgQDNyDMRpUwldk5bNxusuD3OaezG6BqyCmeemvCK5TdRm+7ecQxkOWBH51FcmrKoYjw79qfBIxsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rfLynmuQtSshcayUGrmPFF9yEH0to+IwYSG+me2cuN4=; b=ccfmHdWmJhjnN8rmlB64y5lV5Ug22Lx3RPlLfViB9+pcCLIHb5gUS0RKTsgzSYLx8cYTaU4OP6lD1AogoD0BS/JfLQKQrp8jmaARn9+IFLz3qsLEyRIcbGwoFDXyKJx111tAaEymQzBQGj05DE/+DD+pcDbtnwBCYUlmnPLF5AHzKy070PEe2Grty8KImaDiKvmrbLo1NEWA5Hm9BlJY8vYRD+RLpyfevljtsuJlOVHWYkycaIGt2okQifys5yi8pl3ageAQvZLYC7vo2zbSfbE5vTCVQwO/GWi5kCndSXV9frIo+2eGA5MqlwhE7GLbT04Stz4QD+s9HenD3Xs+Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=toshiba-tsip.com; dmarc=pass action=none header.from=toshiba-tsip.com; dkim=pass header.d=toshiba-tsip.com; arc=none From: To: CC: , Subject: RE: [PATCH v2] rootfs: clean package log files that are not owned by packages Thread-Topic: [PATCH v2] rootfs: clean package log files that are not owned by packages Thread-Index: AQHXttHc9UZ9VuV2FkSzLDVxvIwaG6vCwoiAgAABRLA= Date: Mon, 4 Oct 2021 12:51:43 +0000 X-TSB-HOP: ON Message-ID: References: <20210906124831.202ce22f@md1za8fc.ad001.siemens.net> <20211001143748.8711-1-venkata.pyla@toshiba-tsip.com> <20211004140513.29414a72@md1za8fc.ad001.siemens.net> In-Reply-To: <20211004140513.29414a72@md1za8fc.ad001.siemens.net> Accept-Language: en-IN, en-US Content-Language: en-US authentication-results: siemens.com; dkim=none (message not signed) header.d=none;siemens.com; dmarc=none action=none header.from=toshiba-tsip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8b415531-7e43-48b7-bdc8-08d98735b7a9 x-ms-traffictypediagnostic: OS3PR01MB6502: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9qrHjHxgLTjEfKEja6Ukn9NLTy/impTYW48Nxwl/0Mi3fifaLumtSBx7y3WcGjlf5hy3q8umXHnmnaI/191yg53uq7eZ6m5VNgj9qbagb5eVXAiutGevUgdRqTiFvmdka5aRX3sOGfWXR3pHsDWHbsGisTTcd1uMRIwnOdIQSi+5y5S21/E9WD05eIIkl2pRt1C4v3bsMzpdQT/Q/rGyjYXyyWuruXZG8gyoJ4FpQgCQE7WAf6M7VbRyJTRDMkYNC5yLqkOiTF5PcOyREBTw8IZkzlxko1ezbC2x1YJKBm/gJ1zNl8+41oTtGcmZGDqT8MTN8CfT/hEruHPC2eEslSTeXTr0UV8Ueoi+YK6sqoiqzfakEpI3sj837OVz5rxfqoYBTiGmIp/1rLfcA5NGb9ermRvsh5tG/pWE9CnaWPNt0T4E0scEbXncgwUh9QWU5Ep2cFjf7TndVxbEQkdkbsZq2EvdOvj+mwboHKXqV7ozVCvGPFrdDnm5QkhSJwNj7YhXUaj/PLdsI0HmJG4FNi0ieuRfECESPCFJNs4Axsko+xjFyZagfjI0KFiLT4d9/O1ZNDy8R/HInY/D0biJs5uXLPff9F74oLicHTSImAksFWFSi7PUTtKGVJHQ1RsRJizUSknQKnMnDRK9Tbjzgu0vu4Cg1gOWoTWMqgn+ZL7XXwuARi++SatYhhd1Cp/1xEbTXZs398q0KdOTi8EpbA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSYPR01MB5542.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6506007)(54906003)(38100700002)(64756008)(316002)(55236004)(83380400001)(8676002)(38070700005)(66446008)(7696005)(8936002)(122000001)(86362001)(2906002)(26005)(186003)(5660300002)(55016002)(52536014)(4326008)(76116006)(33656002)(6916009)(66476007)(66556008)(66946007)(71200400001)(85182001)(9686003)(508600001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?UEtrZlZySDFaWUordUVmV3VDbGE3WXNQOGNvR2J3Qkh3K0xibGNQbU9B?= =?iso-2022-jp?B?NE9nMkg4a1VpRFVVVXlldUcvZVBKby9BMjVOakQybWh3YVdyWWJYOVVq?= =?iso-2022-jp?B?L3JKSlE0aEliY0lIbTloNG1udWs0UDdpSzh0ZHNJcFYyZUtSWFZmcnQv?= =?iso-2022-jp?B?MGNsNGJWVkthQ2lOSzkvVDYybDhsbEF6NGdyYitheWV3a2t3NUhka290?= =?iso-2022-jp?B?aGdsdlp0K3VxMjlGTjZWUmh0VE1vRkRHVDZoalkwOTFZaG9nWnh5SFMz?= =?iso-2022-jp?B?Z3BPc3RRaTVLSUdkdVJodXgzek5NMUpKcEwwdk5Oc05pYmFVc2RYMzJG?= =?iso-2022-jp?B?akY3OXN1bUg3bGtXdnJxbDNwSjBsK1VEaVgrNUpUaUdMU2tiNXc5aVZZ?= =?iso-2022-jp?B?WThEOHBXNnkrTzZ2dldmVEUweXFlaDBnRUVybnNwd2FzcmVwaTg2cTV0?= =?iso-2022-jp?B?LzVaTVlIZ1luZUI1MnZ2Ull5eTRyNVhBM0Myd2YveFRyS2xxZXBCaFpx?= =?iso-2022-jp?B?ei9yK202cFJMSWt5dW54VlNqSHB1R1lCU1dJY0xTWUMzc25DbS9idFlz?= =?iso-2022-jp?B?UFF1VHNaazlQNGlCb0srZ3lQa2xJV25nUFdVN1NXalEvejZaajZHc2hh?= =?iso-2022-jp?B?cXA3RXZuV1Y3Z1FCNmJnUzJWa2tpeEh0QytkNERNRFFCZnpyTkp2ckY5?= =?iso-2022-jp?B?akl3eFJNVWhjUlkxTFk5cXlINUdlWW12Q3RNekM2K3FIdGZvSTZ0eXpT?= =?iso-2022-jp?B?Q1NYS3ZacVdOWURCOXNOMUFaVUtiTUdnOFpRc1RlSy81K2VLNnBNWmdF?= =?iso-2022-jp?B?THEvbzI4bFVwUVE4RmZTQ3NUMmV2MlNoYzhwcTJKRmdwbWxLczFpdVlk?= =?iso-2022-jp?B?dGZvRWtSN1k0dWsyR2ZzMHY2NkVQcmc1Z3diQk5TdVd0OTB1MGRkOWxk?= =?iso-2022-jp?B?cmMxZ2ZFTXljbTdzWTJYMGEyd2lLS1lYOUx6b1YrazE0c2lDSzVsQlBP?= =?iso-2022-jp?B?SEkwSzUxTExwRGE1MFBOS1ZQa3kzRmlSQ3BWOEdtOGtSWE9LdGJITEFl?= =?iso-2022-jp?B?OEdhSGpoaThmbjdtZ0VQM2czamRtMkdnTlpUS1ppNi8wOVJGaXhMN3FY?= =?iso-2022-jp?B?V3MvMEN0SWJqMklRSzI1LzRaUnNGVi9uRXIvVXI4RktXZXlEeFZidERC?= =?iso-2022-jp?B?KzB6Z3Zpc2FFTWxWT1dwKzIwcHE5UHhRZGtvSGtzSmRSOXkzQkJWejlB?= =?iso-2022-jp?B?bFZic1R1LytQYUs2ZkxBbkZRWG10a0ducmtyeXVYZDF0UDZvWTNUSXFZ?= =?iso-2022-jp?B?VWsycklrcHFHZk81VUdsRU1HRHNhdWdIVEhtYyswL1BmMGZrcXZmek1k?= =?iso-2022-jp?B?dXZFdC9iSk1UU2p4dXd6VnJPVHZUU0dpa3gxbE1ROVhkT0hKY21xMGZC?= =?iso-2022-jp?B?aVpWTjFVK0VNY1VxcDB3Vi8wWkRQMng3Z0M0MXV6RnJFNi8vaWdiKy8v?= =?iso-2022-jp?B?QVkxVVRteVlOME4yOXRiT0pCRkpFemdaNjNJbkpqeGNMeGZHTUhMMkNL?= =?iso-2022-jp?B?WklMdko5UXpCNFNnaW9BMWE5NFVvNW5TTGt2RnZuTUt0Nk1SUTYwcnhB?= =?iso-2022-jp?B?ZTdoSmZsSFhPY0JTZmNDaVBuSU12azhGM0VjZ3VWaFdMaEt1bSsxMnEv?= =?iso-2022-jp?B?dUxwK1RIUGd6UWhJYzVvR2JTWjgzbGIrTlYyMWVvallteW5RTnVybWY4?= =?iso-2022-jp?B?K2QwWEFydWRMYllQcTVYVGJGQlhobFlDdEhGOTlsaGhLMFQ0b05RUHR6?= =?iso-2022-jp?B?NnMvWmRUUi81SnpBd3MwVkR0UzcrM0oySlpzSnVOaDB3Sy9vbXkrYURK?= =?iso-2022-jp?B?RC8zR0J5dTJmWWRER3o0UWNPdnJvPQ==?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OSYPR01MB5542.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b415531-7e43-48b7-bdc8-08d98735b7a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2021 12:51:43.3469 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f109924e-fb71-4ba0-b2cc-65dcdf6fbe4f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l0K46dxUx4mI8QSyfTzxTYjokFOkmePxb232cLUrRLt2aBlNXKiceDCijyH/KJ+Im2kd/ENiK8Vx8l5v8EGTR4bYLMg1TNWutJVW95ChCQM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB6502 X-OriginatorOrg: toshiba-tsip.com Received-SPF: Fail (TGXML363.toshiba.local: domain of Venkata.Pyla@toshiba-tsip.com does not designate 104.47.92.57 as permitted sender) receiver=TGXML363.toshiba.local; client-ip=104.47.92.57; helo=JPN01-OS2-obe.outbound.protection.outlook.com; X-TUID: QawI5KXzGwi8 >-----Original Message----- >From: Henning Schild >Sent: 04 October 2021 17:35 >To: pyla venkata(=1B$B#T#S#I#P=1B(B) >Cc: isar-users@googlegroups.com; jan.kiszka@siemens.com >Subject: Re: [PATCH v2] rootfs: clean package log files that are not owned= by >packages > >Am Fri, 1 Oct 2021 20:07:48 +0530 >schrieb : > >> From: venkata pyla >> >> /var/log/* files that are created during build stage and not owned >> by any package are not neccessary to be present in rootfs image, as >> these log files adds additional size to rootfs image, and also it >> create problems for reproducible build functionality. >> >> so this ROOTFS feature 'clean-log-files' should help to clean the log >> files when it is enalbed, disable it if we need the log files for >> debugging purpose. >> >> ROOTFS_FEATURE +=3D clean-log-files > >The two leading spaces of the commit message look a little weird. Like you= are >not using git-format-patch or git-send-email correctly. Or like you are us= ing a >funny editor for writing your commit messages. I will correct it, thanks. > >I think that adds value but i do not see why we should model it as a featu= re. It >should probably be the "new normal" and we introduce an option once there = is a >need for a switch. I added it as feature because if we delete the logs file by default from th= e image, if any user want those log files for debugging purpose then there will be p= rovision to disable this feature and get the log files as earlier > >> Signed-off-by: venkata pyla >> --- >> meta/classes/rootfs.bbclass | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass >> index f9151c5..ff0ecad 100644 >> --- a/meta/classes/rootfs.bbclass >> +++ b/meta/classes/rootfs.bbclass >> @@ -12,6 +12,7 @@ ROOTFS_PACKAGES ?=3D "" >> # 'clean-package-cache' - delete package cache from rootfs # >> 'generate-manifest' - generate a package manifest of the rootfs into >> ${ROOTFS_MANIFEST_DEPLOY_DIR} # 'export-dpkg-status' - exports >> /var/lib/dpkg/status file to ${ROOTFS_DPKGSTATUS_DEPLOY_DIR} +# >> 'clean-log-files' - delete log files that are not owned by packages >> ROOTFS_FEATURES ?=3D "" >> ROOTFS_APT_ARGS=3D"install --yes -o Debug::pkgProblemResolver=3Dyes" >> @@ -213,6 +214,15 @@ rootfs_postprocess_clean_package_cache() { >> sudo rm -rf "${ROOTFSDIR}/var/lib/apt/lists/"* >> } >> >> +ROOTFS_POSTPROCESS_COMMAND +=3D >> "${@bb.utils.contains('ROOTFS_FEATURES', 'clean-log-files', >> 'rootfs_postprocess_clean_log_files', '', d)}" >> +rootfs_postprocess_clean_log_files() { >> + # Delete log files that are not owned by packages >> + sudo -E chroot '${ROOTFSDIR}' \ >> + /usr/bin/find /var/log/ \ >> + -exec sh -c '! dpkg -S {} > /dev/null 2>&1' ';' \ >> + -exec rm -rf {} ';' > >I think we should restrict that to "-type f" and switch over to "rm -f" >(not -r) > If we delete only files then there may be some residue left over as empty f= olders. >Henning > >> +} >> + >> ROOTFS_POSTPROCESS_COMMAND +=3D >> "${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest', >> 'rootfs_generate_manifest', '', d)}" rootfs_generate_manifest () { >> mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR}