public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: <Venkata.Pyla@toshiba-tsip.com>
To: <felix.moessbauer@siemens.com>, <isar-users@googlegroups.com>
Cc: <jan.kiszka@siemens.com>, <kazuhiro3.hayashi@toshiba.co.jp>,
	<dinesh.kumar@toshiba-tsip.com>
Subject: RE: [PATCH 1/1] rootfs postprocess: clean python cache
Date: Mon, 9 Jan 2023 14:45:39 +0000	[thread overview]
Message-ID: <OSYPR01MB55429A20BB93B6E8106B34CCA4FE9@OSYPR01MB5542.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20230109112854.1532151-1-felix.moessbauer@siemens.com>



>-----Original Message-----
>From: Felix Moessbauer <felix.moessbauer@siemens.com>
>Sent: 09 January 2023 16:59
>To: isar-users@googlegroups.com
>Cc: pyla venkata(TSIP TMIEC ODG Porting) <Venkata.Pyla@toshiba-
>tsip.com>; jan.kiszka@siemens.com; hayashi kazuhiro(林 和宏 □SWC◯AC
>T) <kazuhiro3.hayashi@toshiba.co.jp>; dinesh kumar(TSIP TMIEC ODG
>Porting) <dinesh.kumar@toshiba-tsip.com>; Felix Moessbauer
><felix.moessbauer@siemens.com>
>Subject: [PATCH 1/1] rootfs postprocess: clean python cache
>
>When calling python scripts, python automatically creates cache files to
>speedup future invocations of the same sources. This often happens in postinst
>scripts, that directly run in the image chroot. The created debian packages do
>not ship these files, as the debheper scripts remove them before installing.
>
>For the rootfs part, we manually have to do it to also not include these in the
>final image. This patch implements this logic in a custom cleanup postprocess
>step. As there might be situations where shipping of a subset of the caches is
>desireable (e.g. readonly rootfs images), we add support to control this logic
>using ROOTFS_FEATURES.
>
>Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
>---
> meta/classes/image.bbclass  | 2 +-
> meta/classes/rootfs.bbclass | 6 ++++++
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index
>629a0c1..6859240 100644
>--- a/meta/classes/image.bbclass
>+++ b/meta/classes/image.bbclass
>@@ -80,7 +80,7 @@ image_do_mounts() {
> }
>
> ROOTFSDIR = "${IMAGE_ROOTFS}"
>-ROOTFS_FEATURES += "clean-package-cache generate-manifest export-dpkg-
>status clean-log-files clean-debconf-cache"
>+ROOTFS_FEATURES += "clean-package-cache clean-pycache generate-
>manifest export-dpkg-status clean-log-files clean-debconf-cache"
> ROOTFS_PACKAGES += "${IMAGE_PREINSTALL} ${IMAGE_INSTALL}"
> ROOTFS_MANIFEST_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}"
> ROOTFS_DPKGSTATUS_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}"
>diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass index
>786682d..325e7ae 100644
>--- a/meta/classes/rootfs.bbclass
>+++ b/meta/classes/rootfs.bbclass
>@@ -252,6 +252,12 @@ rootfs_postprocess_clean_debconf_cache() {
>     sudo rm -rf "${ROOTFSDIR}/var/cache/debconf/"*
> }
>
>+ROOTFS_POSTPROCESS_COMMAND +=
>"${@bb.utils.contains('ROOTFS_FEATURES', 'clean-pycache',
>'rootfs_postprocess_clean_pycache', '', d)}"
>+rootfs_postprocess_clean_pycache() {
>+    sudo find ${ROOTFSDIR}/usr -type f -name '*.pyc'       -delete -print
>+    sudo find ${ROOTFSDIR}/usr -type d -name '__pycache__' -delete
>+-print }
>+

Thanks Felix, this patch works for me.


> ROOTFS_POSTPROCESS_COMMAND +=
>"${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest',
>'rootfs_generate_manifest', '', d)}"
> rootfs_generate_manifest () {
>     mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR}
>--
>2.34.1


      reply	other threads:[~2023-01-09 14:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 11:28 Felix Moessbauer
2023-01-09 14:45 ` Venkata.Pyla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSYPR01MB55429A20BB93B6E8106B34CCA4FE9@OSYPR01MB5542.jpnprd01.prod.outlook.com \
    --to=venkata.pyla@toshiba-tsip.com \
    --cc=dinesh.kumar@toshiba-tsip.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kazuhiro3.hayashi@toshiba.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox