public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: <Venkata.Pyla@toshiba-tsip.com>
To: <isar-users@googlegroups.com>
Cc: <henning.schild@siemens.com>, <jan.kiszka@siemens.com>,
	<dinesh.kumar@toshiba-tsip.com>,
	<kazuhiro3.hayashi@toshiba.co.jp>,
	<Venkata.Pyla@toshiba-tsip.com>
Subject: RE: [isar][RFC] rootfs: clean debconf cache files
Date: Tue, 10 May 2022 07:19:58 +0000	[thread overview]
Message-ID: <OSYPR01MB55429C6F7C43C7489199CA9DA4C99@OSYPR01MB5542.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20220506094532.15696-1-venkata.pyla@toshiba-tsip.com>

Hi,

Sorry, somehow my replay mail to the below patch was not went to the mailing list earlier, I am resending.

Please provide your comments for the below patch that will remove the debconf cache files in the isar image.

I am removing these files for the purpose of the solving non-reproducible problem in debconf cache file.
I am also finding solution to not remove these files, by fixing the actual problem in packages who produces the non-reproducible content (information is present in the below commit log)

Also I am checking why not remove these files in isar image.
As I understood, the debconf cache files are used to store the answers of  debconf's questions asked during package installation and same cached information will be used in the next package update/re-install time.
I think in the isar build system the package installation is noninteractive and the debconf cache generates with default data, which is not necessary to store.
If my above understanding is correct, I think we can safely delete the debconf cache file in isar image.

Kindly let me know your feedback on this understanding and provide your suggestions.

Thanks,
Venkata.

>-----Original Message-----
>From: venkata.pyla@toshiba-tsip.com <venkata.pyla@toshiba-tsip.com>
>Sent: 06 May 2022 15:16
>To: isar-users@googlegroups.com
>Cc: pyla venkata(TSIP) <Venkata.Pyla@toshiba-tsip.com>;
>henning.schild@siemens.com; jan.kiszka@siemens.com; dinesh kumar(TSI
>P) <dinesh.kumar@toshiba-tsip.com>; hayashi kazuhiro(林 和宏 □SWC◯AC
>T) <kazuhiro3.hayashi@toshiba.co.jp>
>Subject: [isar][RFC] rootfs: clean debconf cache files
>
>From: venkata pyla <venkata.pyla@toshiba-tsip.com>
>
>Cleaning the debconf cache files for the purpose of generating reproducible
>system image.
>
>The debconf cache database sometime generates with non-reproducible
>contents because of some packages behaviour (e.g: localepurge), reported this
>to package bug tracking system[1], but because this problem is not with one
>particular package and can happen with other packages also, this should be
>solved in common place to address reproducibility problem, discussing with
>Reproducible-builds community[2] to find some common solution for this
>problem.
>
>[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1009639
>[2] https://lists.reproducible-builds.org/pipermail/rb-general/2022-
>April/002546.html
>
>Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
>Suggested-by: Henning Schild <henning.schild@siemens.com>
>---
> meta/classes/image.bbclass  | 2 +-
> meta/classes/rootfs.bbclass | 6 ++++++
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index
>eb879ff..a306bd2 100644
>--- a/meta/classes/image.bbclass
>+++ b/meta/classes/image.bbclass
>@@ -71,7 +71,7 @@ image_do_mounts() {
> }
>
> ROOTFSDIR = "${IMAGE_ROOTFS}"
>-ROOTFS_FEATURES += "clean-package-cache generate-manifest export-dpkg-
>status clean-log-files"
>+ROOTFS_FEATURES += "clean-package-cache generate-manifest export-dpkg-
>status clean-log-files clean-debconf-cache"
> ROOTFS_PACKAGES += "${IMAGE_PREINSTALL} ${IMAGE_INSTALL}"
> ROOTFS_MANIFEST_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}"
> ROOTFS_DPKGSTATUS_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}"
>diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass index
>b021e72..78f4ba6 100644
>--- a/meta/classes/rootfs.bbclass
>+++ b/meta/classes/rootfs.bbclass
>@@ -243,6 +243,12 @@ rootfs_postprocess_clean_log_files() {
>         -exec rm -f {} ';'
> }
>
>+ROOTFS_POSTPROCESS_COMMAND +=
>"${@bb.utils.contains('ROOTFS_FEATURES', 'clean-debconf-cache',
>'rootfs_postprocess_clean_debconf_cache', '', d)}"
>+rootfs_postprocess_clean_debconf_cache() {
>+    # Delete debconf cache files
>+    sudo rm -rf "${ROOTFSDIR}/var/cache/debconf/"*
>+}
>+
> ROOTFS_POSTPROCESS_COMMAND +=
>"${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest',
>'rootfs_generate_manifest', '', d)}"
> rootfs_generate_manifest () {
>     mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR}
>--
>2.20.1



  reply	other threads:[~2022-05-10  7:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-10 17:02 [isar 0/1] Fix non-reproducible issue due to localepurge venkata.pyla
2022-04-10 17:02 ` [isar 1/1] image-locales-extension: Do localepurge configuration after installation venkata.pyla
2022-04-11 10:53 ` [isar 0/1] Fix non-reproducible issue due to localepurge Henning Schild
2022-04-11 13:14   ` Jan Kiszka
2022-04-13 12:15   ` Venkata.Pyla
2022-04-14  8:08     ` Henning Schild
2022-04-14 15:38       ` Jan Kiszka
2022-05-06  9:45       ` [isar][RFC] rootfs: clean debconf cache files venkata.pyla
2022-05-10  7:19         ` Venkata.Pyla [this message]
2022-06-08 14:40           ` Venkata.Pyla
2022-06-10  7:41             ` Anton Mikanovich
2022-06-16  3:54               ` Venkata.Pyla
2022-06-16  4:36               ` [PATCH] " venkata.pyla
2022-09-26  9:03                 ` Anton Mikanovich
2022-06-09  6:04         ` [isar][RFC] " Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSYPR01MB55429C6F7C43C7489199CA9DA4C99@OSYPR01MB5542.jpnprd01.prod.outlook.com \
    --to=venkata.pyla@toshiba-tsip.com \
    --cc=dinesh.kumar@toshiba-tsip.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kazuhiro3.hayashi@toshiba.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox