RE: [PATCH v2] rootfs: clean package log files that are not owned by packages

[<Venkata.Pyla@toshiba-tsip.com>]

Hi Jan,

Thanks for the review, please find my inline comments.

>-----Original Message-----
>From: Jan Kiszka <jan.kiszka@siemens.com>
>Sent: 04 October 2021 15:26
>To: pyla venkata(ＴＳＩＰ) <Venkata.Pyla@toshiba-tsip.com>; isar-
>users@googlegroups.com
>Cc: henning.schild@siemens.com
>Subject: Re: [PATCH v2] rootfs: clean package log files that are not owned by
>packages
>
>On 01.10.21 16:37, venkata.pyla@toshiba-tsip.com wrote:
>> From: venkata pyla <venkata.pyla@toshiba-tsip.com>
>>
>>  /var/log/* files that are created during build stage and not owned
>> by any package are not neccessary to be present in rootfs image, as
>> these log files adds additional size to rootfs image, and also it
>> create problems for reproducible build functionality.
>>
>>  so this ROOTFS feature 'clean-log-files' should help to clean the log
>> files when it is enalbed, disable it if we need the log files for
>> debugging purpose.
>>
>>  ROOTFS_FEATURE += clean-log-files
>>
>
>Style: Do not indent the commit body. I think this will survive "git am"
>and will make the result look inconsistent.

Thanks for correcting me, I will send the patch again with corrected comments.  

>
>> Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
>> ---
>>  meta/classes/rootfs.bbclass | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
>> index f9151c5..ff0ecad 100644
>> --- a/meta/classes/rootfs.bbclass
>> +++ b/meta/classes/rootfs.bbclass
>> @@ -12,6 +12,7 @@ ROOTFS_PACKAGES ?= ""
>>  # 'clean-package-cache' - delete package cache from rootfs  #
>> 'generate-manifest' - generate a package manifest of the rootfs into
>> ${ROOTFS_MANIFEST_DEPLOY_DIR}  # 'export-dpkg-status' - exports
>> /var/lib/dpkg/status file to ${ROOTFS_DPKGSTATUS_DEPLOY_DIR}
>> +# 'clean-log-files' - delete log files that are not owned by packages
>>  ROOTFS_FEATURES ?= ""
>>
>>  ROOTFS_APT_ARGS="install --yes -o Debug::pkgProblemResolver=yes"
>> @@ -213,6 +214,15 @@ rootfs_postprocess_clean_package_cache() {
>>      sudo rm -rf "${ROOTFSDIR}/var/lib/apt/lists/"*
>>  }
>>
>> +ROOTFS_POSTPROCESS_COMMAND +=
>"${@bb.utils.contains('ROOTFS_FEATURES', 'clean-log-files',
>'rootfs_postprocess_clean_log_files', '', d)}"
>> +rootfs_postprocess_clean_log_files() {
>> +    # Delete log files that are not owned by packages
>> +    sudo -E chroot '${ROOTFSDIR}' \
>> +        /usr/bin/find /var/log/ \
>> +        -exec sh -c '! dpkg -S {} > /dev/null 2>&1' ';' \
>> +        -exec rm -rf {} ';'
>> +}
>> +
>>  ROOTFS_POSTPROCESS_COMMAND +=
>"${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest',
>'rootfs_generate_manifest', '', d)}"
>>  rootfs_generate_manifest () {
>>      mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR}
>>
>
>Is there any reason why this feature should be default-off? If not, I would also
>add it to image.bbclass, ROOTFS_FEATURES.

No reasons to set it to off, I taught to enable this feature where it is required (isar-cip-core),
But, It is good idea to enable in upstream also.

If no objection I can send the patch with enabling this feature in image.bbclass

>
>Jan
>
>--
>Siemens AG, T RDA IOT
>Corporate Competence Center Embedded Linux