RE: [PATCH] meta: default "Rules-Requires-Root: no", make it configurable

["'Prusty, Badrikesh' via isar-users" <isar-users@googlegroups.com>]

Hi Jan and Felix,

Thanks for your response.

> BTW, what about meta-isar/recipes-app/snake4/files/debian/control
> and meta-isar/recipes-bsp/optee-examples/files/debian/control.tmpl?

Will check and update.


> You are missing the most important control point:
> meta/classes/debianize.bbclass
> 
> But not already the changes here justify a RECIPE-API-CHANGELOG.md entry.

I saw the patch from Issac True, did the changes in debianize.bbclass: https://groups.google.com/g/isar-users/c/MYQDhaHPtX0
Avoided duplicating here. 

> Why making this a variable? optee-client already hard-codes it to no.
> Applies to the others as well.
>
> Do we have packages in isar where we know that root is indeed needed?

Yes, I initially thought the same, but needed some suggestions. Since I didn't find any recipe requiring root permissions to build (as we're not installing anything to the system paths), I also tested building all the recipes with Rules-Requires-Root: no. The build progressed fine.
On salsa.debian.org, I checked some package sources like Linux, U-Boot, etc., and they build without requiring fakeroot.

Should I avoid creating a variable and setting it to no by default for all of these ?

> While debian does not recommend to set this to yes, I'm wondering if the
> default is still yes (or if that changed in trixie).

With dpkg version 1.22.13, which is present in Debian Trixie, the default value is no.
In dpkg versions used in Debian Bookworm and earlier, the default value of Rules-Requires-Root was binary-targets.


> Anyways, your patch does not fix the hang, it just makes it less likely
> as now more packages are build without fakeroot. It merely is an
> optimization.

Yes, that's true. I also noticed that it builds slightly faster on Debian Bookworm-not a significant difference, but it may become noticeable with longer tasks.



Regards,
Badrikesh

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/SG2PR06MB51077A2852C1F5C28EA9DF8D9109A%40SG2PR06MB5107.apcprd06.prod.outlook.com.