From: "'Prusty, Badrikesh' via isar-users" <isar-users@googlegroups.com>
To: Anton Mikanovich <amikan@ilbers.de>,
isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH v3 3/3] meta: Move DTB deployment to a separate dtb-files recipe
Date: Thu, 8 Jan 2026 13:15:08 +0000 [thread overview]
Message-ID: <SG2PR06MB5107BA6E1B56407106193B149185A@SG2PR06MB5107.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <3c808186-0df5-41b3-b752-871b1b42dea7@ilbers.de>
Hello Anton,
Can we proceed with merging this patch?
Regarding the kernel name issue, I would like to share a suggestions for
consideration. For images that do not require kernel installation and
are intended solely for image generation (e.g., Docker images), the
deploy directory logic could be adapted as follows:
```
# Deploy directory: meta/conf/bitbake.conf
DEPLOY_DIR_IMAGE = "${DEPLOY_DIR}/images/${MACHINE}-${DISTRO}${@ (ker := d.getVar('KERNEL_NAME')) and '-' + ker or '' }"
# For fixing installer image: meta-isar/classes-recipe/installer-add-rootfs.bbclass
INSTALLER_TARGET_KERNEL ??= "${KERNEL_NAME}"
INSTALLER_TARGET_DEPLOY_DIR_IMAGE ??= "${DEPLOY_DIR}/images/${INSTALLER_TARGET_MACHINE}-${INSTALLER_TARGET_DISTRO}${@ (ker := d.getVar('INSTALLER_TARGET_KERNEL')) and '-' + ker or '' }"
```
This ensures that kernel name is included only when populated.
Any thoughts on this?
Many Thanks,
Badrikesh
________________________________________
From: Anton Mikanovich <amikan@ilbers.de>
Sent: 15 October 2025 20:19
To: Prusty, Badrikesh (FT FDS CES LX PBU 2); isar-users
Subject: Re: [PATCH v3 3/3] meta: Move DTB deployment to a separate dtb-files recipe
15/10/2025 12:55, 'Badrikesh Prusty' via isar-users wrote:
> Hello Anton,
>
> Thank you for the patch.
> With the changes, the machine base images are building as expected,
> and we are able to build multiple images with different kernels and
> distros.
>
> For isar-installer-image, the bundling process is still searching for
> images in the old deploy directory path:
>
> meta-isar/classes/installer-add-rootfs.bbclass
> ---
> INSTALLER_TARGET_DEPLOY_DIR_IMAGE ??=
> "${DEPLOY_DIR}/images/${INSTALLER_TARGET_MACHINE}"
>
> Please have a look.
>
> Thanks,
> Badrikesh
Hello Badrikesh,
Thanks for good catch.
It looks like the fix will require kernel name of installer target to be
predefined, which can be tricky in some cases.
Will try to think about any other possible solution.
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/SG2PR06MB5107BA6E1B56407106193B149185A%40SG2PR06MB5107.apcprd06.prod.outlook.com.
prev parent reply other threads:[~2026-01-08 13:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 8:55 [PATCH v3 0/3] Deploy DTBs with separate recipe Anton Mikanovich
2025-10-08 8:55 ` [PATCH v3 1/3] meta: Fix do_copy_boot_files error for different distros of same machine Anton Mikanovich
2025-10-08 8:55 ` [PATCH v3 2/3] testsuite: Add test to check dtb deployment Anton Mikanovich
2025-10-08 8:55 ` [PATCH v3 3/3] meta: Move DTB deployment to a separate dtb-files recipe Anton Mikanovich
2025-10-15 9:55 ` 'Badrikesh Prusty' via isar-users
2025-10-15 14:49 ` Anton Mikanovich
2026-01-08 13:15 ` 'Prusty, Badrikesh' via isar-users [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SG2PR06MB5107BA6E1B56407106193B149185A@SG2PR06MB5107.apcprd06.prod.outlook.com \
--to=isar-users@googlegroups.com \
--cc=amikan@ilbers.de \
--cc=badrikesh.prusty@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox