public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Kumar, Rakesh' via isar-users" <isar-users@googlegroups.com>
To: "Kiszka, Jan" <jan.kiszka@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "cedric.hombourger@siemens.com" <cedric.hombourger@siemens.com>
Subject: RE: [PATCH v1 1/1] initramfs: correct parameter reference in hook_error function
Date: Wed, 4 Sep 2024 05:26:00 +0000	[thread overview]
Message-ID: <SG2PR06MB51891D8FD701C8483A3C104C979C2@SG2PR06MB5189.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <5709db26-9c55-453f-874b-3df5c46c8772@siemens.com>

Hi all,

If there are no concerns or comments, could we proceed with merging these changes.


Regards,
Rakesh

-----Original Message-----
From: Kiszka, Jan (T CED) <jan.kiszka@siemens.com> 
Sent: 03 September 2024 18:53
To: Kumar, Rakesh (DI CTO FDS CES LX PBU 1) <kumar.rakesh@siemens.com>; isar-users@googlegroups.com
Cc: Hombourger, Cedric (DI CTO FDS CES LX) <cedric.hombourger@siemens.com>
Subject: Re: [PATCH v1 1/1] initramfs: correct parameter reference in hook_error function

On 03.09.24 15:15, Rakesh Kumar wrote:
> Fixed an issue in the hook_error function where the second parameter 
> ($2) was incorrectly referenced in the error message output.
> The correct first parameter ($1) is now used to ensure that the 
> specified argument to hook_error is correctly logged into the logfile.
> 
> Signed-off-by: Rakesh Kumar <kumar.rakesh@siemens.com>
> ---
>  .../initramfs-tee-supplicant-hook/files/tee-supplicant.hook     | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git 
> a/meta/recipes-initramfs/initramfs-tee-supplicant-hook/files/tee-suppl
> icant.hook 
> b/meta/recipes-initramfs/initramfs-tee-supplicant-hook/files/tee-suppl
> icant.hook
> index 3e6adbed..3e2f4016 100644
> --- 
> a/meta/recipes-initramfs/initramfs-tee-supplicant-hook/files/tee-suppl
> icant.hook
> +++ b/meta/recipes-initramfs/initramfs-tee-supplicant-hook/files/tee-s
> +++ upplicant.hook
> @@ -24,7 +24,7 @@ esac
>  . /usr/share/initramfs-tools/hook-functions
>  
>  hook_error() {
> -    echo "(ERROR): $2" >&2
> +    echo "(ERROR): $1" >&2
>      exit 1
>  }
>  

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

Thanks,
Jan

--
Siemens AG, Technology
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/SG2PR06MB51891D8FD701C8483A3C104C979C2%40SG2PR06MB5189.apcprd06.prod.outlook.com.

  reply	other threads:[~2024-09-04  5:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 13:15 'Rakesh Kumar' via isar-users
2024-09-03 13:23 ` 'Jan Kiszka' via isar-users
2024-09-04  5:26   ` 'Kumar, Rakesh' via isar-users [this message]
2024-09-09 14:44 ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SG2PR06MB51891D8FD701C8483A3C104C979C2@SG2PR06MB5189.apcprd06.prod.outlook.com \
    --to=isar-users@googlegroups.com \
    --cc=cedric.hombourger@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kumar.rakesh@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox