[PATCH] isar-installer: show progress bar during bmaptool copy process

[PATCH] isar-installer: show progress bar during bmaptool copy process

['Kasturi Shekar' via isar-users]

- Added support for a progress gauge using a named pipe to capture and display
 percentage progress when using `bmaptool`.
- The progress bar is displayed only when the `bmaptool` version is 3.8 or above,
 as versions prior to 3.8 has some issues with `--psplash-pipe` flag.
- For `bmaptool` versions below 3.8, the image copy process continues without a
 progress bar to maintain compatibility.
- The gauge uses `dialog --gauge` to dynamically update the progress based on
 output from the `bmaptool` process.

Signed-off-by: Kasturi Shekar <kasturi.shekar@siemens.com>
---
 .../files/usr/bin/deploy-image-wic.sh         | 44 ++++++++++++++++++-
 1 file changed, 42 insertions(+), 2 deletions(-)

diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
index 7f552eee..1265d0cc 100755
--- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
+++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
@@ -149,8 +149,48 @@ if ! $installer_unattended; then
     clear
 fi
 
-if ! bmaptool copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
-    exit 1
+# Function to compare version numbers
+version_gt() {
+    if [ "$(printf '%s\n' "$1" "$2" | sort -V | head -n 1)" != "$1" ]; then
+        return 0
+    else
+        return 1
+    fi
+}
+
+# Get bmap-tools version using dpkg-query
+bmap_version=$(dpkg-query -W -f='${Version}' bmap-tools | awk -F'[~+-]' '{ print $1 }')
+
+if version_gt "$bmap_version" "3.8" || [ "$bmap_version" = "3.8" ]; then
+    # Create a named pipe for progress communication
+    progress_pipe="/tmp/progress"
+    if ! mkfifo "$progress_pipe"; then
+        echo "Error: Failed to create named pipe $progress_pipe"
+        exit 1
+    fi
+
+    # Initialize the dialog gauge and update it dynamically
+    (
+        while true; do
+            if read -r line < "$progress_pipe"; then
+                percentage=$(echo "$line" | awk '{ print $2 }')
+                echo "$percentage"
+            fi
+        done
+    ) | dialog --gauge "Flashing image, please wait..." 10 70 0 &
+
+    # Run bmaptool with psplash for versions greater than or equal to 3.8
+    if ! bmaptool -q copy ${bmap_options} --psplash-pipe="$progress_pipe" "$installer_image_uri" "$installer_target_dev"; then
+        exit 1
+    fi
+
+    # Clean up the named pipe after completion
+    rm "$progress_pipe"
+
+else
+    if ! bmaptool copy ${bmap_options} "$installer_image_uri" "$installer_target_dev"; then
+        exit 1
+    fi
 fi
 
 if ! $installer_unattended; then
-- 
2.39.5

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250306102801.260426-1-kasturi.shekar%40siemens.com.

Re: [PATCH] isar-installer: show progress bar during bmaptool copy process

['Jan Kiszka' via isar-users]

On 06.03.25 11:28, 'Kasturi Shekar' via isar-users wrote:
> - Added support for a progress gauge using a named pipe to capture and display
>  percentage progress when using `bmaptool`.
> - The progress bar is displayed only when the `bmaptool` version is 3.8 or above,
>  as versions prior to 3.8 has some issues with `--psplash-pipe` flag.

Which issues were these? Is there some related upstream or Debian bug?

3.8 means trixie, just to clearify.

> - For `bmaptool` versions below 3.8, the image copy process continues without a
>  progress bar to maintain compatibility.
> - The gauge uses `dialog --gauge` to dynamically update the progress based on
>  output from the `bmaptool` process.
> 
> Signed-off-by: Kasturi Shekar <kasturi.shekar@siemens.com>
> ---
>  .../files/usr/bin/deploy-image-wic.sh         | 44 ++++++++++++++++++-
>  1 file changed, 42 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> index 7f552eee..1265d0cc 100755
> --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> @@ -149,8 +149,48 @@ if ! $installer_unattended; then
>      clear
>  fi
>  
> -if ! bmaptool copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
> -    exit 1
> +# Function to compare version numbers
> +version_gt() {
> +    if [ "$(printf '%s\n' "$1" "$2" | sort -V | head -n 1)" != "$1" ]; then

This should be possible as well:

version_ge() {
        if [ "$(printf '%s\n' "$1"X "$2" | sort -V | head -n 1)" != "$1"X ]; then

> +        return 0
> +    else
> +        return 1
> +    fi
> +}
> +
> +# Get bmap-tools version using dpkg-query
> +bmap_version=$(dpkg-query -W -f='${Version}' bmap-tools | awk -F'[~+-]' '{ print $1 }')
> +
> +if version_gt "$bmap_version" "3.8" || [ "$bmap_version" = "3.8" ]; then

... and will obsolete the second test.

> +    # Create a named pipe for progress communication
> +    progress_pipe="/tmp/progress"
> +    if ! mkfifo "$progress_pipe"; then
> +        echo "Error: Failed to create named pipe $progress_pipe"
> +        exit 1
> +    fi
> +
> +    # Initialize the dialog gauge and update it dynamically
> +    (
> +        while true; do
> +            if read -r line < "$progress_pipe"; then
> +                percentage=$(echo "$line" | awk '{ print $2 }')
> +                echo "$percentage"
> +            fi
> +        done
> +    ) | dialog --gauge "Flashing image, please wait..." 10 70 0 &
> +
> +    # Run bmaptool with psplash for versions greater than or equal to 3.8

The version tests are done above - commenting here is a bit confusing.

> +    if ! bmaptool -q copy ${bmap_options} --psplash-pipe="$progress_pipe" "$installer_image_uri" "$installer_target_dev"; then
> +        exit 1
> +    fi
> +
> +    # Clean up the named pipe after completion
> +    rm "$progress_pipe"
> +
> +else
> +    if ! bmaptool copy ${bmap_options} "$installer_image_uri" "$installer_target_dev"; then
> +        exit 1
> +    fi
>  fi
>  
>  if ! $installer_unattended; then

Didn't try yet, but I can imagine that it looks nice :)

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/98136ab9-5b75-49c3-8b7b-f6eb9d900245%40siemens.com.

RE: [PATCH] isar-installer: show progress bar during bmaptool copy process

['Shekar, Kasturi' via isar-users]

-----Original Message-----
From: Kiszka, Jan (FT RPD CED) <jan.kiszka@siemens.com> 
Sent: 07 March 2025 16:11
To: Shekar, Kasturi (FT FDS CES LX PBU 2) <kasturi.shekar@siemens.com>; isar-users@googlegroups.com
Subject: Re: [PATCH] isar-installer: show progress bar during bmaptool copy process

On 06.03.25 11:28, 'Kasturi Shekar' via isar-users wrote:
> - Added support for a progress gauge using a named pipe to capture and 
> display  percentage progress when using `bmaptool`.
> - The progress bar is displayed only when the `bmaptool` version is 
> 3.8 or above,  as versions prior to 3.8 has some issues with `--psplash-pipe` flag.

Which issues were these? Is there some related upstream or Debian bug?

3.8 means trixie, just to clearify.

Yes, it’s a Debian issue and 3.8 is Trixie. 

> - For `bmaptool` versions below 3.8, the image copy process continues 
> without a  progress bar to maintain compatibility.
> - The gauge uses `dialog --gauge` to dynamically update the progress 
> based on  output from the `bmaptool` process.
> 
> Signed-off-by: Kasturi Shekar <kasturi.shekar@siemens.com>
> ---
>  .../files/usr/bin/deploy-image-wic.sh         | 44 ++++++++++++++++++-
>  1 file changed, 42 insertions(+), 2 deletions(-)
> 
> diff --git 
> a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-
> wic.sh 
> b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-
> wic.sh
> index 7f552eee..1265d0cc 100755
> --- 
> a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-
> wic.sh
> +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-im
> +++ age-wic.sh
> @@ -149,8 +149,48 @@ if ! $installer_unattended; then
>      clear
>  fi
>  
> -if ! bmaptool copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
> -    exit 1
> +# Function to compare version numbers
> +version_gt() {
> +    if [ "$(printf '%s\n' "$1" "$2" | sort -V | head -n 1)" != "$1" 
> +]; then

This should be possible as well:

version_ge() {
        if [ "$(printf '%s\n' "$1"X "$2" | sort -V | head -n 1)" != "$1"X ]; then

> +        return 0
> +    else
> +        return 1
> +    fi
> +}
> +
> +# Get bmap-tools version using dpkg-query bmap_version=$(dpkg-query 
> +-W -f='${Version}' bmap-tools | awk -F'[~+-]' '{ print $1 }')
> +
> +if version_gt "$bmap_version" "3.8" || [ "$bmap_version" = "3.8" ]; 
> +then

... and will obsolete the second test.

> +    # Create a named pipe for progress communication
> +    progress_pipe="/tmp/progress"
> +    if ! mkfifo "$progress_pipe"; then
> +        echo "Error: Failed to create named pipe $progress_pipe"
> +        exit 1
> +    fi
> +
> +    # Initialize the dialog gauge and update it dynamically
> +    (
> +        while true; do
> +            if read -r line < "$progress_pipe"; then
> +                percentage=$(echo "$line" | awk '{ print $2 }')
> +                echo "$percentage"
> +            fi
> +        done
> +    ) | dialog --gauge "Flashing image, please wait..." 10 70 0 &
> +
> +    # Run bmaptool with psplash for versions greater than or equal to 
> + 3.8

The version tests are done above - commenting here is a bit confusing.

> +    if ! bmaptool -q copy ${bmap_options} --psplash-pipe="$progress_pipe" "$installer_image_uri" "$installer_target_dev"; then
> +        exit 1
> +    fi
> +
> +    # Clean up the named pipe after completion
> +    rm "$progress_pipe"
> +
> +else
> +    if ! bmaptool copy ${bmap_options} "$installer_image_uri" "$installer_target_dev"; then
> +        exit 1
> +    fi
>  fi
>  
>  if ! $installer_unattended; then

Didn't try yet, but I can imagine that it looks nice :)

Jan

--
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/SG2PR06MB531137E8BA73B72BE10F96C294D62%40SG2PR06MB5311.apcprd06.prod.outlook.com.

RE: [PATCH] isar-installer: show progress bar during bmaptool copy process

['Shekar, Kasturi' via isar-users]

-----Original Message-----
From: Kiszka, Jan (FT RPD CED) <jan.kiszka@siemens.com>
Sent: 07 March 2025 16:11
To: Shekar, Kasturi (FT FDS CES LX PBU 2) <kasturi.shekar@siemens.com>; isar-users@googlegroups.com
Subject: Re: [PATCH] isar-installer: show progress bar during bmaptool copy process

On 06.03.25 11:28, 'Kasturi Shekar' via isar-users wrote:
> - Added support for a progress gauge using a named pipe to capture and 
> display  percentage progress when using `bmaptool`.
> - The progress bar is displayed only when the `bmaptool` version is
> 3.8 or above,  as versions prior to 3.8 has some issues with `--psplash-pipe` flag.

Which issues were these? Is there some related upstream or Debian bug?

3.8 means trixie, just to clearify.

Yes, it’s a Debian issue and 3.8 is Trixie. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034290

> - For `bmaptool` versions below 3.8, the image copy process continues 
> without a  progress bar to maintain compatibility.
> - The gauge uses `dialog --gauge` to dynamically update the progress 
> based on  output from the `bmaptool` process.
> 
> Signed-off-by: Kasturi Shekar <kasturi.shekar@siemens.com>
> ---
>  .../files/usr/bin/deploy-image-wic.sh         | 44 ++++++++++++++++++-
>  1 file changed, 42 insertions(+), 2 deletions(-)
> 
> diff --git
> a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-
> wic.sh
> b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-
> wic.sh
> index 7f552eee..1265d0cc 100755
> ---
> a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-
> wic.sh
> +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-im
> +++ age-wic.sh
> @@ -149,8 +149,48 @@ if ! $installer_unattended; then
>      clear
>  fi
>  
> -if ! bmaptool copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
> -    exit 1
> +# Function to compare version numbers
> +version_gt() {
> +    if [ "$(printf '%s\n' "$1" "$2" | sort -V | head -n 1)" != "$1" 
> +]; then

This should be possible as well:

version_ge() {
        if [ "$(printf '%s\n' "$1"X "$2" | sort -V | head -n 1)" != "$1"X ]; then

> +        return 0
> +    else
> +        return 1
> +    fi
> +}
> +
> +# Get bmap-tools version using dpkg-query bmap_version=$(dpkg-query 
> +-W -f='${Version}' bmap-tools | awk -F'[~+-]' '{ print $1 }')
> +
> +if version_gt "$bmap_version" "3.8" || [ "$bmap_version" = "3.8" ]; 
> +then

... and will obsolete the second test.

> +    # Create a named pipe for progress communication
> +    progress_pipe="/tmp/progress"
> +    if ! mkfifo "$progress_pipe"; then
> +        echo "Error: Failed to create named pipe $progress_pipe"
> +        exit 1
> +    fi
> +
> +    # Initialize the dialog gauge and update it dynamically
> +    (
> +        while true; do
> +            if read -r line < "$progress_pipe"; then
> +                percentage=$(echo "$line" | awk '{ print $2 }')
> +                echo "$percentage"
> +            fi
> +        done
> +    ) | dialog --gauge "Flashing image, please wait..." 10 70 0 &
> +
> +    # Run bmaptool with psplash for versions greater than or equal to
> + 3.8

The version tests are done above - commenting here is a bit confusing.

> +    if ! bmaptool -q copy ${bmap_options} --psplash-pipe="$progress_pipe" "$installer_image_uri" "$installer_target_dev"; then
> +        exit 1
> +    fi
> +
> +    # Clean up the named pipe after completion
> +    rm "$progress_pipe"
> +
> +else
> +    if ! bmaptool copy ${bmap_options} "$installer_image_uri" "$installer_target_dev"; then
> +        exit 1
> +    fi
>  fi
>  
>  if ! $installer_unattended; then

Didn't try yet, but I can imagine that it looks nice :)

Jan

--
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/SG2PR06MB53117FEBA39D221F660434FA94D62%40SG2PR06MB5311.apcprd06.prod.outlook.com.

Re: [PATCH] isar-installer: show progress bar during bmaptool copy process

['Jan Kiszka' via isar-users]

On 10.03.25 06:40, Shekar, Kasturi (FT FDS CES LX PBU 2) wrote:
> -----Original Message-----
> From: Kiszka, Jan (FT RPD CED) <jan.kiszka@siemens.com>
> Sent: 07 March 2025 16:11
> To: Shekar, Kasturi (FT FDS CES LX PBU 2) <kasturi.shekar@siemens.com>; isar-users@googlegroups.com
> Subject: Re: [PATCH] isar-installer: show progress bar during bmaptool copy process
> 
> On 06.03.25 11:28, 'Kasturi Shekar' via isar-users wrote:
>> - Added support for a progress gauge using a named pipe to capture and 
>> display  percentage progress when using `bmaptool`.
>> - The progress bar is displayed only when the `bmaptool` version is
>> 3.8 or above,  as versions prior to 3.8 has some issues with `--psplash-pipe` flag.
> 
> Which issues were these? Is there some related upstream or Debian bug?
> 
> 3.8 means trixie, just to clearify.
> 
> Yes, it’s a Debian issue and 3.8 is Trixie. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034290
> 

Kasturi, please fix your email client settings so that you are inserting
proper citation markers ("> "), and your answers become easier
distinguishable.

Felix, did you try to motivate upstream for a stable fix as well?

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/48a8d641-9a31-4743-a3c6-eb5282d3d682%40siemens.com.

[PATCH] isar-installer: show progress bar during bmaptool copy process

['Kasturi Shekar' via isar-users]

- Added support for a progress gauge using a named pipe to capture and display
 percentage progress when using `bmaptool`.
- The progress bar is displayed only when the `bmaptool` version is 3.8 or above,
 as versions prior to 3.8 has some issues with `--psplash-pipe` flag.
- For `bmaptool` versions below 3.8, the image copy process continues without a
 progress bar to maintain compatibility.
- The gauge uses `dialog --gauge` to dynamically update the progress based on
 output from the `bmaptool` process.

Signed-off-by: Kasturi Shekar <kasturi.shekar@siemens.com>
---
 .../files/usr/bin/deploy-image-wic.sh         | 37 ++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)

diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
index 7f552eee..7df9beef 100755
--- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
+++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
@@ -149,7 +149,42 @@ if ! $installer_unattended; then
     clear
 fi
 
-if ! bmaptool copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
+# Function to compare version numbers
+version_ge() {
+    if [ "$(printf '%s\n' "$1"X "$2" | sort -V | head -n 1)" != "$1"X ]; then
+        return 0
+    else
+        return 1
+    fi
+}
+
+# Get bmap-tools version using dpkg-query
+bmap_version=$(dpkg-query -W -f='${Version}' bmap-tools | awk -F'[~+-]' '{ print $1 }')
+
+if version_ge "$bmap_version" "3.8"; then
+    # Create a named pipe for progress communication
+    progress_pipe="/tmp/progress"
+    if ! mkfifo "$progress_pipe"; then
+        echo "Error: Failed to create named pipe $progress_pipe"
+        exit 1
+    fi
+
+    # Add psplash pipe to bmap_options
+    bmap_options="$bmap_options --psplash-pipe=$progress_pipe"
+
+    # Initialize the dialog gauge and update it dynamically
+    (
+        while true; do
+            if read -r line < "$progress_pipe"; then
+                percentage=$(echo "$line" | awk '{ print $2 }')
+                echo "$percentage"
+            fi
+        done
+    ) | dialog --gauge "Flashing image, please wait..." 10 70 0 &
+
+fi
+
+if ! bmaptool copy ${bmap_options} "$installer_image_uri" "$installer_target_dev"; then
     exit 1
 fi
 
-- 
2.39.5

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250314062818.572738-1-kasturi.shekar%40siemens.com.

[PATCH] isar-installer: show progress bar during bmaptool copy process

['Kasturi Shekar' via isar-users]

- Added support for a progress gauge using a named pipe to capture and display
 percentage progress when using `bmaptool`.
- The progress bar is displayed only when the `bmaptool` version is 3.8 or above,
 as versions prior to 3.8 has some issues with `--psplash-pipe` flag.
- For `bmaptool` versions below 3.8, the image copy process continues without a
 progress bar to maintain compatibility.
- The gauge uses `dialog --gauge` to dynamically update the progress based on
 output from the `bmaptool` process.

Signed-off-by: Kasturi Shekar <kasturi.shekar@siemens.com>
---
 .../files/usr/bin/deploy-image-wic.sh         | 38 ++++++++++++++++++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
index 7f552eee..85549d57 100755
--- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
+++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
@@ -149,7 +149,43 @@ if ! $installer_unattended; then
     clear
 fi
 
-if ! bmaptool copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
+# Function to compare version numbers
+version_ge() {
+    if [ "$(printf '%s\n' "$1"X "$2" | sort -V | head -n 1)" != "$1"X ]; then
+        return 0
+    else
+        return 1
+    fi
+}
+
+# Get bmap-tools version using dpkg-query
+bmap_version=$(dpkg-query -W -f='${Version}' bmap-tools | awk -F'[~+-]' '{ print $1 }')
+
+if version_ge "$bmap_version" "3.8"; then
+    # Create a named pipe for progress communication
+    progress_pipe="/tmp/progress"
+    if ! mkfifo "$progress_pipe"; then
+        echo "Error: Failed to create named pipe $progress_pipe"
+        exit 1
+    fi
+
+    # Add psplash pipe to bmap_options
+    bmap_options="$bmap_options --psplash-pipe=$progress_pipe"
+    quiet_flag="-q"
+
+    # Initialize the dialog gauge and update it dynamically
+    (
+        while true; do
+            if read -r line < "$progress_pipe"; then
+                percentage=$(echo "$line" | awk '{ print $2 }')
+                echo "$percentage"
+            fi
+        done
+    ) | dialog --gauge "Flashing image, please wait..." 10 70 0 &
+
+fi
+
+if ! bmaptool ${quiet_flag} copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
     exit 1
 fi
 
-- 
2.39.5

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250317054911.578456-1-kasturi.shekar%40siemens.com.

Re: [PATCH] isar-installer: show progress bar during bmaptool copy process

['Quirin Gylstorff' via isar-users]

On 3/17/25 06:49, 'Kasturi Shekar' via isar-users wrote:
> - Added support for a progress gauge using a named pipe to capture and display
>   percentage progress when using `bmaptool`.
> - The progress bar is displayed only when the `bmaptool` version is 3.8 or above,
>   as versions prior to 3.8 has some issues with `--psplash-pipe` flag.
> - For `bmaptool` versions below 3.8, the image copy process continues without a
>   progress bar to maintain compatibility.
> - The gauge uses `dialog --gauge` to dynamically update the progress based on
>   output from the `bmaptool` process.
> 
> Signed-off-by: Kasturi Shekar <kasturi.shekar@siemens.com>
> ---
>   .../files/usr/bin/deploy-image-wic.sh         | 38 ++++++++++++++++++-
>   1 file changed, 37 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> index 7f552eee..85549d57 100755
> --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> @@ -149,7 +149,43 @@ if ! $installer_unattended; then
>       clear
>   fi
>   
> -if ! bmaptool copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
> +# Function to compare version numbers
> +version_ge() {
> +    if [ "$(printf '%s\n' "$1"X "$2" | sort -V | head -n 1)" != "$1"X ]; then
> +        return 0
> +    else
> +        return 1
> +    fi
> +}
> +
> +# Get bmap-tools version using dpkg-query
> +bmap_version=$(dpkg-query -W -f='${Version}' bmap-tools | awk -F'[~+-]' '{ print $1 }')
I would not use dpkg -  as bmaptool has a `--version` option.

Quirin
> +
> +if version_ge "$bmap_version" "3.8"; then
> +    # Create a named pipe for progress communication
> +    progress_pipe="/tmp/progress"
> +    if ! mkfifo "$progress_pipe"; then
> +        echo "Error: Failed to create named pipe $progress_pipe"
> +        exit 1
> +    fi
> +
> +    # Add psplash pipe to bmap_options
> +    bmap_options="$bmap_options --psplash-pipe=$progress_pipe"
> +    quiet_flag="-q"
> +
> +    # Initialize the dialog gauge and update it dynamically
> +    (
> +        while true; do
> +            if read -r line < "$progress_pipe"; then
> +                percentage=$(echo "$line" | awk '{ print $2 }')
> +                echo "$percentage"
> +            fi
> +        done
> +    ) | dialog --gauge "Flashing image, please wait..." 10 70 0 &
> +
> +fi
> +
> +if ! bmaptool ${quiet_flag} copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
>       exit 1
>   fi
>   

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/ade675f2-ae84-46a0-9b16-dbf8d57804e9%40siemens.com.

[PATCH] isar-installer: show progress bar during bmaptool copy process

['Kasturi Shekar' via isar-users]

- Added support for a progress gauge using a named pipe to capture and display
 percentage progress when using `bmaptool`.
- The progress bar is displayed only when the `bmaptool` version is 3.8 or above,
 as versions prior to 3.8 has some issues with `--psplash-pipe` flag.
- For `bmaptool` versions below 3.8, the image copy process continues without a
 progress bar to maintain compatibility.
- The gauge uses `dialog --gauge` to dynamically update the progress based on
 output from the `bmaptool` process.

Signed-off-by: Kasturi Shekar <kasturi.shekar@siemens.com>
---
 .../files/usr/bin/deploy-image-wic.sh         | 38 ++++++++++++++++++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
index 7f552eee..66c35506 100755
--- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
+++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
@@ -149,7 +149,43 @@ if ! $installer_unattended; then
     clear
 fi
 
-if ! bmaptool copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
+# Function to compare version numbers
+version_ge() {
+    if [ "$(printf '%s\n' "$1"X "$2" | sort -V | head -n 1)" != "$1"X ]; then
+        return 0
+    else
+        return 1
+    fi
+}
+
+# Get bmap-tools version
+bmap_version=$(bmaptool --version | awk '{ print $NF }')
+
+if version_ge "$bmap_version" "3.8"; then
+    # Create a named pipe for progress communication
+    progress_pipe="/tmp/progress"
+    if ! mkfifo "$progress_pipe"; then
+        echo "Error: Failed to create named pipe $progress_pipe"
+        exit 1
+    fi
+
+    # Add psplash pipe to bmap_options
+    bmap_options="$bmap_options --psplash-pipe=$progress_pipe"
+    quiet_flag="-q"
+
+    # Initialize the dialog gauge and update it dynamically
+    (
+        while true; do
+            if read -r line < "$progress_pipe"; then
+                percentage=$(echo "$line" | awk '{ print $2 }')
+                echo "$percentage"
+            fi
+        done
+    ) | dialog --gauge "Flashing image, please wait..." 10 70 0 &
+
+fi
+
+if ! bmaptool ${quiet_flag} copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
     exit 1
 fi
 
-- 
2.39.5

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250318052012.4701-1-kasturi.shekar%40siemens.com.

Re: [PATCH] isar-installer: show progress bar during bmaptool copy process

['Jan Kiszka' via isar-users]

Please always version our patches, or you will only create confusion for
reviewers and maintainers. This would be "PATCH v5" now.

Jan

On 18.03.25 06:20, 'Kasturi Shekar' via isar-users wrote:
> - Added support for a progress gauge using a named pipe to capture and display
>  percentage progress when using `bmaptool`.
> - The progress bar is displayed only when the `bmaptool` version is 3.8 or above,
>  as versions prior to 3.8 has some issues with `--psplash-pipe` flag.
> - For `bmaptool` versions below 3.8, the image copy process continues without a
>  progress bar to maintain compatibility.
> - The gauge uses `dialog --gauge` to dynamically update the progress based on
>  output from the `bmaptool` process.
> 
> Signed-off-by: Kasturi Shekar <kasturi.shekar@siemens.com>
> ---
>  .../files/usr/bin/deploy-image-wic.sh         | 38 ++++++++++++++++++-
>  1 file changed, 37 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> index 7f552eee..66c35506 100755
> --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> @@ -149,7 +149,43 @@ if ! $installer_unattended; then
>      clear
>  fi
>  
> -if ! bmaptool copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
> +# Function to compare version numbers
> +version_ge() {
> +    if [ "$(printf '%s\n' "$1"X "$2" | sort -V | head -n 1)" != "$1"X ]; then
> +        return 0
> +    else
> +        return 1
> +    fi
> +}
> +
> +# Get bmap-tools version
> +bmap_version=$(bmaptool --version | awk '{ print $NF }')
> +
> +if version_ge "$bmap_version" "3.8"; then
> +    # Create a named pipe for progress communication
> +    progress_pipe="/tmp/progress"
> +    if ! mkfifo "$progress_pipe"; then
> +        echo "Error: Failed to create named pipe $progress_pipe"
> +        exit 1
> +    fi
> +
> +    # Add psplash pipe to bmap_options
> +    bmap_options="$bmap_options --psplash-pipe=$progress_pipe"
> +    quiet_flag="-q"
> +
> +    # Initialize the dialog gauge and update it dynamically
> +    (
> +        while true; do
> +            if read -r line < "$progress_pipe"; then
> +                percentage=$(echo "$line" | awk '{ print $2 }')
> +                echo "$percentage"
> +            fi
> +        done
> +    ) | dialog --gauge "Flashing image, please wait..." 10 70 0 &
> +
> +fi
> +
> +if ! bmaptool ${quiet_flag} copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then
>      exit 1
>  fi
>  


-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/ca6aa527-e6ad-4a5d-a29b-fd4934c16f97%40siemens.com.