RE: [PATCH v2] fix premature success dialog in installer script

["'Shekar, Kasturi' via isar-users" <isar-users@googlegroups.com>]

Hi,

The gauge runs in a separate background process and reads from a named pipe.
Even after bmap tool finishes, the read loop can remain active, causing the gauge to overlap with the success dialog. Explicitly killing the gauge ensures it terminates cleanly before the next message is shown.

Thanks

> -----Original Message-----
> From: Moessbauer, Felix (FT RPD CED OES-DE)
> <felix.moessbauer@siemens.com>
> Sent: 06 August 2025 12:59
> To: Shekar, Kasturi (FT FDS CES LX PBU 2) <kasturi.shekar@siemens.com>;
> isar-users@googlegroups.com
> Subject: Re: [PATCH v2] fix premature success dialog in installer script
> 
> On Wed, 2025-08-06 at 11:24 +0530, 'Kasturi Shekar' via isar-users
> wrote:
> > The 'Installation successful' message was displayed before the
> > progress bar completed. Fixed by tracking the dialog --gauge PID and
> > terminating it after bmaptool finishes. This ensures the progress bar
> > runs to 100% before showing the final message.
> 
> Hi,
> 
> I'm still wondering how that could happen. The bmaptool is the command
> that needs to terminate before showing the next message. How does the
> killing of the gauge help here?
> 
> >
> > Changes:
> > - Tracked the PID of the dialog --gauge process.
> > - Killed gauge process after bmaptool completed.
> > - Ensured success message is shown only after the progress bar ends.
> >
> > Signed-off-by: Kasturi Shekar <kasturi.shekar@siemens.com>
> > ---
> >  .../deploy-image/files/usr/bin/deploy-image-wic.sh            | 4
> > ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/meta-isar/recipes-installer/deploy-
> > image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-
> > installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> > index aba81c84..fa1061c1 100755
> > --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-
> > image-wic.sh
> > +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-
> > image-wic.sh
> > @@ -183,12 +183,16 @@ if version_ge "$bmap_version" "3.6"; then
> >          done
> >      ) | dialog --gauge "Flashing image, please wait..." 10 70 0 &
> >
> > +    gauge_pid=$!
> >  fi
> >
> >  if ! bmaptool ${quiet_flag} copy ${bmap_options}
> > "$installer_image_uri" "${installer_target_dev}"; then
> > +    kill "$gauge_pid"
> >      exit 1
> 
> As we exit anyways, why do we need to kill the gauge?
> Isn't it reaped when leaving the script?
> 
> >  fi
> >
> > +kill "$gauge_pid" 2>/dev/null
> 
> Why do we need to ignore errors here?
> 
> PS: This script could need some shellcheck improvements.
> 
> Felix
> 
> > +
> >  if ! $installer_unattended; then
> >      dialog --title "Reboot" \
> >             --msgbox "Installation was successful. System will be
> > rebooted. Please remove the USB stick." 6 60
> > --
> > 2.39.5
> 
> --
> Siemens AG
> Linux Expert Center
> Friedrich-Ludwig-Bauer-Str. 3
> 85748 Garching, Germany

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/SG2PR06MB5311E0DFAF4AAB6A6FAB1B70942DA%40SG2PR06MB5311.apcprd06.prod.outlook.com.