Re: [PATCH v2 1/1] fix: mount pts into rootfs

[Baurzhan Ismagulov <ibr@radix50.net>]

On Mon, May 09, 2022 at 02:34:54PM +0000, Moessbauer, Felix wrote:
> > > diff --git a/meta/classes/buildchroot.bbclass
> > > b/meta/classes/buildchroot.bbclass index 3d2211b9..527f8ded 100644
> > > --- a/meta/classes/buildchroot.bbclass
> > > +++ b/meta/classes/buildchroot.bbclass
> > > @@ -43,7 +43,8 @@ buildchroot_do_mounts() {
> > >          fi
> > >          mountpoint -q '${BUILDCHROOT_DIR}/dev' ||
> > >              ( mount --bind /dev '${BUILDCHROOT_DIR}/dev' &&
> > > -              mount -t tmpfs none '${BUILDCHROOT_DIR}/dev/shm' )
> > > +              mount -t tmpfs none '${BUILDCHROOT_DIR}/dev/shm' &&
> > > +              mount --rbind /dev/pts '${BUILDCHROOT_DIR}/dev/pts' )
> > 
> > if recursion was removed on purpose we should probably mount "-t devpts" and
> > not "--rbind"
> 
> Yes, I am happy to send a v3 with that fix, but before doing so we should agree on a direction.
> In the end, it would probably be better to let schroot handle our buildchroots.
> This shouldn't be too much effort, once the sbuilder patches are merged.

I think the final solution should be removing buildchroots (we need a couple of
days for v1, +/-).

If an interim solution would be needed, mount --bind /dev/pts from the host
should be used. In my local projects, I had started with mount -t devpts but
switched to --bind in 2018 due to issues (at least "sudo: no tty present and no
askpass program specified", not sure about other packages).

In general, we'd like to work on removing the few remaining recursive mounts
from Isar due to various issues (exponential mounts, asymmetric umounts,
umounting problems).

For debugging issues like "which package version was available in isar-apt when
package X was being built", maybe we could evaluate something like an option
for cp -al or similar.

With kind regards,
Baurzhan.