From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7361699629460619264 X-Received: by 2002:a2e:9583:0:b0:2d8:785c:cdb0 with SMTP id w3-20020a2e9583000000b002d8785ccdb0mr1289947ljh.8.1714121725653; Fri, 26 Apr 2024 01:55:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9656:0:b0:2dd:c642:9361 with SMTP id 38308e7fff4ca-2deca1c7bf6ls8225421fa.0.-pod-prod-07-eu; Fri, 26 Apr 2024 01:55:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF4VToHEjeHlWaen+zG/qUKUOb6uAz9nk16mockbC+7gaOoGJaaZuE7qd6SfWND/NbWN+Ha X-Received: by 2002:a2e:96c5:0:b0:2de:1457:9d27 with SMTP id d5-20020a2e96c5000000b002de14579d27mr1157428ljj.0.1714121723203; Fri, 26 Apr 2024 01:55:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1714121723; cv=none; d=google.com; s=arc-20160816; b=ptiddEnUQD2ytZBmRQy8OggdXvueTaNM7Pwk0vm11vUxU7J4/cZQnjdiVON95D6ZWw pGy7iKkbhW2cnoQGUXMCAjTORRBWW0eSKyP5IJGJSbvbqCHfxxsyk2Van74eSC0SRw/W F2cx0sc9jwcyYVqtNhmneGmDnGVY8LHFn3fzP3zHQphSYJeslHLna83CKYkVX2cucT7C mEvpMV7okM2pE4NQGTkftUeoGJ2ePRh2tztEt/vRjKTGNvJdae5xssSkM0A30XuN37x/ +g1+wXgOKLODbk2pocSfp7zN6nf8CH+vwCMdtj9LLGX94YATNmr0U5dbxw7l1J9ZwdWQ p1wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date; bh=GSeYWqG3WOkBB4muBVtHVz7Vzv6xwzMvox+Dm6417H4=; fh=U5GU3LG1VfdGOjQVDhc0FfNbrOYyO00qz578e3VKSyc=; b=i9MXu6FoLC0s4xQWlL05JgUiDIRm1/bD68u73ZABGz+1HKunpt/BTdCbr+LexrFfE2 aXm1S1ZRsBJC9XRjCSCuK3pr+hlZZWn2spckf/QltzLr6Ye2ckpJC9/aV88RnyZL7JYR xrd8Jl5Sxd2ZobHYXqEmeLvWLw7FV1RF3/9jyQOMPRe09i9pI9DJd58SvwQnzqFY3c9e XriL1R3JAcDQ5KmEzwwheW6y5D2KnDQDXNcGdXXvR4uY8nVCQo5G5JcZDnYFgA918TOW BvtIfcxjlrzF63H5hmYEGcRpzUCndpXdd1/ukwLZCUGLMv0PUulI2jxb2yiZ++mzWf// 1FnA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ibr@radix50.net designates 85.214.156.166 as permitted sender) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id b18-20020a2e8952000000b002dd5ea1636esi448953ljk.3.2024.04.26.01.55.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Apr 2024 01:55:23 -0700 (PDT) Received-SPF: pass (google.com: domain of ibr@radix50.net designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ibr@radix50.net designates 85.214.156.166 as permitted sender) smtp.mailfrom=ibr@radix50.net Received: from ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 43Q8tK7N007809 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Apr 2024 10:55:21 +0200 Date: Fri, 26 Apr 2024 10:55:20 +0200 From: Baurzhan Ismagulov To: isar-users@googlegroups.com Cc: felix.moessbauer@siemens.com, jan.kiszka@siemens.com, Quirin.Gylstorff@siemens.com Subject: Re: [PATCH v2] classes/rootfs: remove content of /dev, /run and vmlinux old Message-ID: Mail-Followup-To: isar-users@googlegroups.com, felix.moessbauer@siemens.com, jan.kiszka@siemens.com, Quirin.Gylstorff@siemens.com References: <20240425071419.292013-1-Quirin.Gylstorff@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425071419.292013-1-Quirin.Gylstorff@siemens.com> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: nLOTendvDfmJ On 2024-04-25 09:13, 'Quirin Gylstorff' via isar-users wrote: > `/dev` and `/run` contain artifacts from the ISAR build clean them > up for reproducability. Suggest "Isar" and "reproducibility". > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 98741da0..4af0d448 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -427,12 +427,17 @@ do_rootfs_finalize() { > rmdir --ignore-fail-on-non-empty ${ROOTFSDIR}/base-apt > > mountpoint -q '${ROOTFSDIR}/dev' && \ > - umount -l ${ROOTFSDIR}/dev > + umount -l -R ${ROOTFSDIR}/dev && \ > + rm -rf ${ROOTFSDIR}/dev/* > + > mountpoint -q '${ROOTFSDIR}/proc' && \ > umount -l ${ROOTFSDIR}/proc > mountpoint -q '${ROOTFSDIR}/sys' && \ > umount -l ${ROOTFSDIR}/sys > > + rm -rf ${ROOTFSDIR}/run/* > + rm -f ${ROOTFSDIR}/vmlinuz.old > + Could you provide the list of the specific files that you want to have removed? Debian normally has /dev populated even though devtmpfs is mounted later on top of it. If the problem is that the entries have different timestamps on different builds, then the question is not limited to /dev but applies to any files created in postinstall scripts. I don't think the general approach should be to remove such files at the meta level. On an unrelated note, we've tested non-lazy mounts and haven't observed any issues; we'll share the patches for it as well as for recursive mounts. With kind regards, Baurzhan