Re: [PATCH] meta: Drop lazy and recursive unmounts

[Baurzhan Ismagulov <ibr@radix50.net>]

On 2024-10-10 06:33, 'Jan Kiszka' via isar-users wrote:
> No, we should not start to consolidate the umounts again. If we do that,
> we could also drop the warning from the catch-all handler
> build_completed and let it umount everything, as we've done in the past.
> If we don't want this anymore, every individual task that does mounting
> must also do the umounting at its end. And that means even the umount in
> do_rootfs_finalize would become obsolete.

I agree, the vision has always been to mount-umount as locally as possible. To
avoid misunderstanding, it isn't about "consolidate the umounts again" -- the
single goal of the cleanup handler is to warn about the problem; unmounting was
done as a by-product only to return a saner state to the user, as executing
sudo rm -rf build afterwards might delete the host /dev, making the system
unusable.

On the whole, the approach in the patches looks good to us; we'll provide a
consolidated patchset today / tomorrow as long as we don't encounter any
surprises underway.

With kind regards,
Baurzhan

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/ZwehtJp6hJ7B2LfT%40abai.m.ilbers.de.