Re: [PATCH 0/4] Allow better control over container tags

[Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>]

Apart from the comment to Patch 3 regarding the breaking change that the default would produce that need some clarification, it looks good to me.

In any case, as you mention yourself, the breaking change (either direct on the application of the patch or later) needs to be well documented and announced. Also the variables CONTAINER_NAME and CONTAINER_TAG need to be documented.

Cheers,
  Silvano

On 28/07/2021 17:22, Henning Schild wrote:
> A container tags consists of "name:tag" and both have been kind of
> hardcoded so far. "tag" was always "latest" which is not proper
> versioning. And "name" has always been "isar-DISTRO-ARCH" which is also
> not proper because the name should probably describe the content and not
> so much the build system. Plus that name means guaranteed collision if
> you build two containers with isar based on the same disto and arch.
> 
> p3 is kind of interface breaking, i may have forgotten some docs and
> stuff
> 
> Henning Schild (4):
>   classes: make sure container extension can run multiple times
>   classes: simplify tag handling in container class
>   classes: allow more control over container image name and tag
>   classes: fix comment in container-img class
> 
>  meta/classes/container-img.bbclass            |  6 ++---
>  .../classes/image-container-extension.bbclass | 25 ++++++++++---------
>  meta/classes/image-sdk-extension.bbclass      |  2 +-
>  3 files changed, 16 insertions(+), 17 deletions(-)
> 
-- 
  Silvano Cirujano Cuesta
-- 
Siemens AG, T RDA IOT SES-DE
Corporate Competence Center Embedded Linux