From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6989998000320806912 X-Received: by 2002:ab0:7a68:: with SMTP id c8mr4111534uat.58.1627563525823; Thu, 29 Jul 2021 05:58:45 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a67:d607:: with SMTP id n7ls156170vsj.9.gmail; Thu, 29 Jul 2021 05:58:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxB5BMoZgQb/dhIV30rFwudz8aq8FJmt8q5GZHouCp5vid38HEP3xn/b3QrAylsp2UW9Ps X-Received: by 2002:a67:2d87:: with SMTP id t129mr2730100vst.19.1627563525222; Thu, 29 Jul 2021 05:58:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1627563525; cv=pass; d=google.com; s=arc-20160816; b=alMYETuWQLp80BNMnmayp7NDoMxso9nTqZ/6BS2YlaSd+zY05Vwk3FGgoxpAUOdqk+ pT49CmMVFdWjuC9obnmnxocdii+xpsEftmE/xgQ9VwnZyzqv4kKDfHux1S+lpGTTcd9c paU+Wlwb0+IWscbbpM4yF3LjcOk+s8hisBtsH5wwhrfdJU7CTbQ4wdfgHZMTJfY6be1V 9VPd8/4+vK/Gow97z9BZAkvgTgTItompIW+SGWNhZv9vlSmhA0I2B6AeV+pASS7A1YKP 8VSeWBn3Bwn5gRT0k9ciL+h3c1hvgAz5Wf41qXzpFz2Z+EX09TKt+VBD4Ic2wjpUh+Kp 5CqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:content-language:in-reply-to :user-agent:date:message-id:from:references:to:subject :dkim-signature; bh=xWCi3KVJevP78tKLEqMUHAEngjXAM/KVoZBDGespe0I=; b=02zkYizB1wZ+2EVYhfakqgH/8a/clUDaNsrtyvcCxUredGqSeFDvBDo2gdxkTqTJT3 I9446Sl8H70uH+JxA5qz2G28d3fmbHpdKcfmLPayIgxhiorQXa/O/0wNsQ4Xen5VedKP YXMgODT7CTqqVSVBAsVeQ3ILiIAb0c9cxRKQ1UAEdhY4wMVFjra4sz5tRi16g5n5rebr ceg/8KP11MbV5F43R+1O2jkS89eAVB4XuSEPfSx2aXZT1l8M69Dq5AfcViHTSBrGPrBM DxrVHWtCCefmbRXJsTOC8+BO4mEsdBdqBl4ZBOKH+yO2+o3f2UYQCEGzldFzCHic8UvG p4fg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b=T7cnMFtM; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.6.66 as permitted sender) smtp.mailfrom=silvano.cirujano-cuesta@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60066.outbound.protection.outlook.com. [40.107.6.66]) by gmr-mx.google.com with ESMTPS id o17si229137uat.1.2021.07.29.05.58.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jul 2021 05:58:44 -0700 (PDT) Received-SPF: pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.6.66 as permitted sender) client-ip=40.107.6.66; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b=T7cnMFtM; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.6.66 as permitted sender) smtp.mailfrom=silvano.cirujano-cuesta@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VTlm69mNRi2qQ+z5BjNGH6QQZGu/iqQxwfsXg0PdnWJ88I7/FJw6M3N8/kmVwkTALb1F0N2ty2XI/oI+VvUrmaJTtdRfTn6/Pbi9+Zp8u6cEuXCz12j6nVzQa7caC6UOgR1pehzVoCvquzoACK8yB4odNO/TtNrF6LNMo4w/nC6J6L0zTuk83BNcE43lzIa/Jmx3zYDseuoYzmH+w3KtAchXKqLfjhQGXzD6AkxIDhxkGV0mLLjsu2ocIuGTvdvZwmfQeFmiM4lHGoN1DI6ucJVoThml6fPZUZsdFL2dW9vGgMy2Og0MdPYBDRUmHU6y+hx09R6mlkCU2ZKPg8Vw7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xWCi3KVJevP78tKLEqMUHAEngjXAM/KVoZBDGespe0I=; b=AylRL0+bqA4HhPhBjC2+nNcg7ZD2MlQtSzncx2Ne0RALVRlfcWhS3GvOF3b1kCUtrU2KqXGeGlN2rhgQRFQ4D4gLDiE+ExjdWp5c7yoz2yTCQKz5jGkYIixGK4QWRKZ8yqN8HonsiFYt2PzphsKkyIhcyrMUc9tjesMGtgBpOrEtBjs/79KiqPxNNjec+FvE/QybZwUb2ck+dhqNkcobkYgZVmSzT1K3GtZ1v9ao/C98V+UKTMLq0xSvn9qwILjvjn9/N7YLNB+VJkh+nX+i2ERPPYUWFYCiLcrHAxE8hei76OuMLPaPOvB8yL14AeAy4/oT7R0dlLebxwSYdONaZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.onmicrosoft.com; s=selector1-siemens-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xWCi3KVJevP78tKLEqMUHAEngjXAM/KVoZBDGespe0I=; b=T7cnMFtMaAvWRYE7Fdu58IsElmdbxyu1wuIwwfr7zdmJxiwALgSsDsQYoJtFBcWdFRFRMEk0eufEkVFxJyhBd5jFwY8v3j4YX1foK9bnF0/v+p1fY83fhoaVJlqqghfM3ytQYsu+HvJicUPv2eJX/V08OUo5FppO92nQgBdXRzQ= Authentication-Results: googlegroups.com; dkim=none (message not signed) header.d=none;googlegroups.com; dmarc=none action=none header.from=siemens.com; Received: from PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:ab::7) by PA4PR10MB4559.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:be::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18; Thu, 29 Jul 2021 12:58:41 +0000 Received: from PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d6e:ae99:c95c:83bd]) by PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d6e:ae99:c95c:83bd%9]) with mapi id 15.20.4373.018; Thu, 29 Jul 2021 12:58:41 +0000 Subject: Re: [PATCH 0/4] Allow better control over container tags To: Henning Schild , isar-users@googlegroups.com References: <20210728152210.7089-1-henning.schild@siemens.com> From: Silvano Cirujano Cuesta Message-ID: Date: Thu, 29 Jul 2021 14:58:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 In-Reply-To: <20210728152210.7089-1-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P191CA0024.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:54::29) To PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:ab::7) Return-Path: silvano.cirujano-cuesta@siemens.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [139.23.72.45] (195.145.170.204) by PR3P191CA0024.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:54::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.31 via Frontend Transport; Thu, 29 Jul 2021 12:58:40 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8a6a7efc-c744-4c32-09ae-08d9529096d9 X-MS-TrafficTypeDiagnostic: PA4PR10MB4559: X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yo+wcpYBk6nPNoo1183PR8qAJ2e3NTHo77YgxQ6YJaqrXPYVKoSxsqOVIXnpYA7tVHObpW1hncqfFWfDV0aaM5N9Dx8LaueH6FKKBVhw8UxrovOK3M0J4mbG5QgyAKaxpUnNAzDnW5SWgD8yrFTcJdRc54N9A09UC29UuAb8m/TFEPUz8R6IQ0lvCbFgdZMdZVNPOW/6vj6v2xpbiAUkVziKaZkh+4y/LtcjYmlGXRfrhDx7NJXckbkj3BaI0+UZx7bBhOhQDfU359VmZmtrjvaFsTmxi+ttqdTuEwDsUHSXDamMusUXCbloUamP5BLp3/cK1tir0lEQJY7sU2jXHx+82dGT7w8Z1zRpCwGw1WqQGLHN73xOiE69wkhsIcPUTgiRJAT5IFHXFlBmGvpv4JlNdXvlv03hUi3zyR+KleeHTrGT6D+AOg++i9aFujLiC3RA/tA7Tn75fOUopd+2kVBNyYozbLRhyiJKsOhEOnVNc6PQLeIc9vJfTaE6NuzXH1yei1Qeoy6va+9tFZiyfMPXtt6iWY2SP9LtoK0KOqApAEHa20VPInsZ+h9Dd9Lq4F2GU6BNmfLMwmRZQxJNGWeMCBf5B/k7UcnTy/GIJ0xGMxQQ6QTF9sNnWk+mqPZdxh+r9awEj+PB8fojSQJuxI6XBjOLzeEJLGfvs8a6BWWQE7u3J6a6FZSoGH9vJxvkdBDEv/G0dnWzMYiO+6le85IFpxXyrMTPFS8h9PfRecejaG3QP+C4FvzkOxy1Pgl5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(376002)(39860400002)(136003)(366004)(6706004)(8676002)(2616005)(26005)(956004)(186003)(6486002)(83380400001)(53546011)(38100700002)(36756003)(478600001)(316002)(16576012)(5660300002)(31696002)(2906002)(8936002)(66556008)(86362001)(66946007)(31686004)(66476007)(78286007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wmgvc09rcVhuVWlDSlNUcUtHcGJWMWI1bC83OHRyL3NJa21FYjVhNksrKzNi?= =?utf-8?B?SGQ0MWpyK0ZQN0wrWU9PUThEM1RVZ29kTUJyWWRsTWVDc2t0a0d6MHFTVnpq?= =?utf-8?B?OVhmWGVBYklOQmNHUEh3dm9yWnRHUXA5YnNvRFk2ckp6NnNLZTVwcGR4TVp3?= =?utf-8?B?YzloS3Fab0Y4UGZFYUZXbnNqdVN1SHJudGsxN0NUU2FyODk5VDAxbWExWUor?= =?utf-8?B?YzE4TVd6aDJUcmsramxGVWFCN3lPcXkzV08ySkZDMTJ6cjRBODd6ZXJsNnRy?= =?utf-8?B?OWh4RVlKWlYxclU1RTJITFMvdzhzcTlSWmRoVWkyaFpQOGJ2eWNNQURaeHRL?= =?utf-8?B?ZnpOZ0NpeWU2WnhTRTFFTUVtUDM5bUtET1RSSGluaU1uM1pTdUNkUnRSTE1o?= =?utf-8?B?c2xUbmdyZHlCNEE3RHNRcGErdGZHTVFzVjJXbDB0WXJtN0lsNzlSMTU0aTFq?= =?utf-8?B?RUExR1p6blNCM2hzM0k2dTZPd3J5K0tsWUNEUk14dll6cHJCR29HcjFzY210?= =?utf-8?B?ZzdZcG8vRk5KRUNHMEg0dURBS0JKOXk5MkF4SkxXLy9tRGJ1MjdEQjdqTUpT?= =?utf-8?B?aUtLenBnYlIzeEtJdk9WbWdUUk9XWTM1NFJzZXBZVlhiTVFwKzg2WFpiWWd1?= =?utf-8?B?SVE5RWxRWTgzYjJEWC9OME82MUg2WUVFMDJxS0x0bXFLNzM1bWFtUGVMU2ZU?= =?utf-8?B?YVJuMGs0dGMvcjUvSUVidmk1dlBPKzJHQUNmVjhSbEZzNWIvcjRUa0QwQ3Fa?= =?utf-8?B?a0lyaGxDV3Y2ZmtZcVFGVUNRMVpwKyt6V1ZuRWdkTndCelBBSXZRb2F2WmNW?= =?utf-8?B?TVJJRUt5dXo2cU5abkpMZWNzSmhEME1LQmhDQTNURXJYWjVROVZjKzNFK21a?= =?utf-8?B?Ulhza2JOZ2NsM0dudTl0elJqSkYzU2xwdjR4d3RVaFpqVmI5QTEwRmloSjRJ?= =?utf-8?B?RTdjSnFXM2ZYdmsvdDV3YVIxaVN0YWlUVjBlS3Q2VWs2OXp2ZlBPekYvdXBk?= =?utf-8?B?d0ZNeVgzMWJ2cnVWVWhXWG1HM2x4V09pb3IrRXJ2NmgxSzVid0Z4VTQzYUNi?= =?utf-8?B?bVdHZWI5cy9ZYlAzZm4ydVl6Q0ZlaFNZSllNQThvMnVCaTQ1LzBzUmh1SUVC?= =?utf-8?B?NGZoOWtHR1Nac3dsYzM3U0dnNHBaM1FwbVlGaGZJa2VpQkkyeDN3Nk5yUGtW?= =?utf-8?B?Mlp1amN1SXR2U0txOWhuTStjcXNaVDRra1YyclBRZmFDWXNrcTVHU0gvOVl1?= =?utf-8?B?MGl3MGI3SjVPRWRWNm5CN3paZXFiaWh1ZU15SVcyUjAwMGxlVERwMXdzOVV4?= =?utf-8?B?MU0wQmFVNlJFZUpCeUlLeC9XcDN6OHFuWE5YUDRyL1Nya3BZdEk3N1FzTGow?= =?utf-8?B?R3Iwa1dCQUpHWXJWK3N1OEp1ems1Q2kvVVdjMllnQ0FsSm1RNG5nYXB2YTNl?= =?utf-8?B?c0hrc3FHZzFubHU3NzhwS0VMalVrcU9YT0E1R1QzZDVYY2tiRlJNNFFtSHN0?= =?utf-8?B?ajkxTy9zSGFpWjFzSko1dTZVbTVXVG94YXFZZG9ITm1SSjFDaUR3a0RSYnI5?= =?utf-8?B?Wk1tdnpyVXBkaTkrZW4xalJKWDc3S3h6dW1LSmdlUjNNQjNZQ2VTa3laUGE3?= =?utf-8?B?ai9KK2lGYzF6N0wwWEU1dUdCVFpxZW1BZmw5SjUzODNnZ29aNkhxK2tXTnY0?= =?utf-8?B?M01vZjlGTHl0MmFBcjVPMHc2K2VieC8yUGpka3NjNGd2K1p6VElqZTVYT3JY?= =?utf-8?Q?3JAdibizoAJV1rlKPxsbSxcDzMKjq3rc9nf82f2?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a6a7efc-c744-4c32-09ae-08d9529096d9 X-MS-Exchange-CrossTenant-AuthSource: PR3PR10MB4254.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2021 12:58:41.0096 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HCZhLyoueudxiAOJqw1gpT4khgPd+/FRK84gcvbhPA1d1OBFQATkmavGI9thDOGdxYNQHUS4ITOzasuqg5G/fvPsYBYwA/Hh3wXKt/lQSfDELTnAb0TGifGuhjn4CrWZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR10MB4559 X-TUID: B8TSdxSEwmiw Apart from the comment to Patch 3 regarding the breaking change that the default would produce that need some clarification, it looks good to me. In any case, as you mention yourself, the breaking change (either direct on the application of the patch or later) needs to be well documented and announced. Also the variables CONTAINER_NAME and CONTAINER_TAG need to be documented. Cheers, Silvano On 28/07/2021 17:22, Henning Schild wrote: > A container tags consists of "name:tag" and both have been kind of > hardcoded so far. "tag" was always "latest" which is not proper > versioning. And "name" has always been "isar-DISTRO-ARCH" which is also > not proper because the name should probably describe the content and not > so much the build system. Plus that name means guaranteed collision if > you build two containers with isar based on the same disto and arch. > > p3 is kind of interface breaking, i may have forgotten some docs and > stuff > > Henning Schild (4): > classes: make sure container extension can run multiple times > classes: simplify tag handling in container class > classes: allow more control over container image name and tag > classes: fix comment in container-img class > > meta/classes/container-img.bbclass | 6 ++--- > .../classes/image-container-extension.bbclass | 25 ++++++++++--------- > meta/classes/image-sdk-extension.bbclass | 2 +- > 3 files changed, 16 insertions(+), 17 deletions(-) > -- Silvano Cirujano Cuesta -- Siemens AG, T RDA IOT SES-DE Corporate Competence Center Embedded Linux