From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6995471841453146112 X-Received: by 2002:a17:906:c251:: with SMTP id bl17mr14745250ejb.219.1629100533586; Mon, 16 Aug 2021 00:55:33 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:907:d1f:: with SMTP id gn31ls3300472ejc.11.gmail; Mon, 16 Aug 2021 00:55:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyy7SgUPfi0WTd5SpcpHqwrI2mdNNOdoQwSeLN/W3gwp9UMgfAWTn04wt7TbNXDdIyqmWfg X-Received: by 2002:a17:906:2642:: with SMTP id i2mr15150528ejc.323.1629100532513; Mon, 16 Aug 2021 00:55:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629100532; cv=none; d=google.com; s=arc-20160816; b=ZBxe0WgTtMNqauBeX3ewrQfM1by7Z2GzC3RR3v08aqNpI2azRW424lIFPVJZWn5d8g tWflhhAZiPN0e8V30+XF2aG5OLoopFGha9/jrWkLoGHF+dRuF83Nu+ON9p3c3l6c1p84 2iMaPXcVquQ45sSiK+VSmYlfAYjXYUqivtm7L/cCfXf0I/P1ahW/+vZDB+lfM6Zd55l/ DCp+kNEF7jVTiMOpdmkIiBo/Q+ru7Q7M7R+b38Ei7vkwdZUtHrra/jl550VFlYBI3fbX faFJxpGKPTce3JCr2gr94xUsURtOPXp9Onhujx5WMzh8UFMFS4/diV/UciNSfvm4GfdU BS+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=P4PadepfE1UtRfePsOOAYI2+wDPZVhZ2KFHgZf5Dw+A=; b=S5dJ8vjIKNOAqYLx/59ADqUqPOhA/AJl5cVDhM/QMaXTuuj+egB9SJzHviwW96pTWv 8Y6NQ9V+7SthJooQf2DoHs6uMu0q5ZwV13AAlgRmFaZVwdcQqf+gVPAIi6z0+OrGMYS0 bWX7nBoI+YrG3WgfsmHVHR/Vxt8Fh5h1u9DzXnhYdYUHefirOudZCBh0HTPIpJ/U5Ds3 ntIrulqsvTVI0o/ro1S1Z78IrA+cqok0XytrkdkHWCb9zjumH6kX2UG3wxlthKEdeaGQ 56FTyOlzsnMkRmo1Nf9qhNKRTytNajg5WqlB6b5tgDcKujaO0sseSQ9v9IC5wYW2xy+G PV9g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id s18si647455ejo.1.2021.08.16.00.55.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Aug 2021 00:55:32 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 17G7tWEo012612 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Aug 2021 09:55:32 +0200 Received: from [167.87.73.147] ([167.87.73.147]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 17G7tVML026903; Mon, 16 Aug 2021 09:55:31 +0200 Subject: Re: [PATCH v2 0/4] Make adjust_git work in both worlds To: Uladzimir Bely , isar-users References: <9030e8b4-5a26-42b8-bca4-7e07977044b1n@googlegroups.com> <6d790e37-a2c8-012f-46b9-3e4ccb0806f2@siemens.com> <2143861.vFx2qVVIhK@home> From: Jan Kiszka Message-ID: Date: Mon, 16 Aug 2021 09:55:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <2143861.vFx2qVVIhK@home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: ryZyELGGtPkv On 16.08.21 09:52, Uladzimir Bely wrote: > In the email from воскресенье, 15 августа 2021 г. 22:02:25 +03 user Jan Kiszka > wrote: >> On 13.08.21 14:40, Uladzimir Bely wrote: >>> When I previously looked at patch.bbclass, I noted, that we don't use it >>> completely. >>> >>> There are some patch_task_patch_prefunc() and patch_task_postfunc() here >>> that are used in OE when PATCHTOOL='git'. But in our case they are never >>> run due to not using PATCH_COMMIT_FUNCTIONS in isar. >>> >>> I suppose (but can't be completely sure without deep look to OE) that >>> prefunc may fix this 'patch is allready applied' issue in OE. >> >> If you can still reproduce the issue, just set PATCH_COMMIT_FUNCTIONS=1 >> to check if it has any impact. >> >> Browsing poky and OE-core, I only find devtool setting this var. But >> both aren't using git as patch tool anyway, a downstream layer/recipe >> needs to requests that. >> >> Jan > > Yes, I also tried this way. > > Actually, enabling PATCH_COMMIT_FUNCTIONS also forces to make some more > changes in patch.bbclass (like sys.path.insert for OE lib path) that makes the > difference increase. > > Anyway, even if this set to "1", the problem of patch reapply is still here - > custom patch is going to be applied despite it was already done on previous > build. So, reset to SRC_REV is still required. > Strange. Did you try the same procedure in an OE setup, to compare what happens there? Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux