* [PATCH v4 1/2] Minor cleanup: Refactor ROOTFS_FEATURES assignment for image to make upcoming changes more easily trackable.
2025-10-30 11:33 [PATCH v4 0/2] Enable systemd units based on systemd presets alexander.heinisch via isar-users
@ 2025-10-30 11:33 ` alexander.heinisch via isar-users
2025-10-30 11:33 ` [PATCH v4 2/2] classes/image-postproc: Enable systemd units based on systemd presets alexander.heinisch via isar-users
2025-11-04 14:15 ` [PATCH v4 0/2] " Zhihang Wei
2 siblings, 0 replies; 4+ messages in thread
From: alexander.heinisch via isar-users @ 2025-10-30 11:33 UTC (permalink / raw)
To: isar-users
Cc: jan.kiszka, felix.moessbauer, cedric.hombourger, wzh, Alexander Heinisch
From: Alexander Heinisch <alexander.heinisch@siemens.com>
Signed-off-by: Alexander Heinisch <alexander.heinisch@siemens.com>
---
meta/classes/image.bbclass | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 441ea936..08715647 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -66,7 +66,14 @@ inherit multiarch
inherit essential
ROOTFSDIR = "${IMAGE_ROOTFS}"
-ROOTFS_FEATURES += "clean-package-cache clean-pycache generate-manifest export-dpkg-status clean-log-files clean-debconf-cache"
+ROOTFS_FEATURES += "\
+ clean-package-cache \
+ clean-pycache \
+ generate-manifest \
+ export-dpkg-status \
+ clean-log-files \
+ clean-debconf-cache \
+ "
# when using a custom initrd, do not generate one as part of the image rootfs
ROOTFS_FEATURES += "${@ '' if d.getVar('INITRD_IMAGE') == '' else 'no-generate-initrd'}"
ROOTFS_PACKAGES += "${IMAGE_PREINSTALL} ${@isar_multiarch_packages('IMAGE_INSTALL', d)}"
--
2.39.5
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251030113332.1809425-2-alexander.heinisch%40siemens.com.
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v4 2/2] classes/image-postproc: Enable systemd units based on systemd presets
2025-10-30 11:33 [PATCH v4 0/2] Enable systemd units based on systemd presets alexander.heinisch via isar-users
2025-10-30 11:33 ` [PATCH v4 1/2] Minor cleanup: Refactor ROOTFS_FEATURES assignment for image to make upcoming changes more easily trackable alexander.heinisch via isar-users
@ 2025-10-30 11:33 ` alexander.heinisch via isar-users
2025-11-04 14:15 ` [PATCH v4 0/2] " Zhihang Wei
2 siblings, 0 replies; 4+ messages in thread
From: alexander.heinisch via isar-users @ 2025-10-30 11:33 UTC (permalink / raw)
To: isar-users
Cc: jan.kiszka, felix.moessbauer, cedric.hombourger, wzh, Alexander Heinisch
From: Alexander Heinisch <alexander.heinisch@siemens.com>
By default population of the presets is automatically done by systemd
on first-boot.
There were several issues with that:
1. The rootfs we get as a build artifact does not reflect the actual
system running in the field.
2. For setups without writeable /etc this fails. With that addition
it happens already at build time.
Note: Additional services are enabled only. Services already enabled
during the package installation won't be changed.
Opt-out: `ROOTFS_FEATURES:remove = "populate-systemd-preset"`
Signed-off-by: Alexander Heinisch <alexander.heinisch@siemens.com>
---
RECIPE-API-CHANGELOG.md | 20 +++++++++++++++++++-
meta/classes/image.bbclass | 1 +
meta/classes/rootfs.bbclass | 12 ++++++++++++
3 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
index cf04fa5c..e173ee53 100644
--- a/RECIPE-API-CHANGELOG.md
+++ b/RECIPE-API-CHANGELOG.md
@@ -790,4 +790,22 @@ unset (the default), `Rules-Requires-Root` will not be added. Otherwise,
Set `Rules-Requires-Root: no` in `debian/control` files to prevent unnecessary
invocation of fakeroot during package builds. This follows Debian guidelines
recommending not to use fakeroot when no privileged operations (e.g., `chown`,
-root file modifications) are required.
+root file modifications) are required.
+
+### Populate systemd units based on presets during image postprocessing
+
+By default population of the presets is automatically done by systemd
+on first-boot.
+
+There were several issues with that:
+
+1. The rootfs we get as a build artifact does not reflect the actual
+system running in the field.
+
+2. For setups without writeable /etc this fails. With that addition
+it happens already at build time.
+
+**Note**: Additional services are enabled only. Services already enabled
+during the package installation won't be changed.
+
+Opt-out: `ROOTFS_FEATURES:remove = "populate-systemd-preset"`
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 08715647..f4b9989c 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -73,6 +73,7 @@ ROOTFS_FEATURES += "\
export-dpkg-status \
clean-log-files \
clean-debconf-cache \
+ populate-systemd-preset \
"
# when using a custom initrd, do not generate one as part of the image rootfs
ROOTFS_FEATURES += "${@ '' if d.getVar('INITRD_IMAGE') == '' else 'no-generate-initrd'}"
diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
index 2fef3120..e9e8cde0 100644
--- a/meta/classes/rootfs.bbclass
+++ b/meta/classes/rootfs.bbclass
@@ -15,6 +15,7 @@ ROOTFS_BASE_DISTRO ?= "${BASE_DISTRO}"
# 'export-dpkg-status' - exports /var/lib/dpkg/status file to ${ROOTFS_DPKGSTATUS_DEPLOY_DIR}
# 'clean-log-files' - delete log files that are not owned by packages
# 'no-generate-initrd' - do not generate debian default initrd
+# 'populate-systemd-preset' - enable systemd units according to systemd presets
ROOTFS_FEATURES ?= ""
ROOTFS_APT_ARGS="install --yes -o Debug::pkgProblemResolver=yes"
@@ -520,6 +521,17 @@ rootfs_cleanup_base_apt() {
EOSUDO
}
+ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'populate-systemd-preset', 'image_postprocess_populate_systemd_preset', '', d)}"
+image_postprocess_populate_systemd_preset() {
+ SYSTEMD_INSTALLED=$(sudo chroot '${ROOTFSDIR}' dpkg-query \
+ --showformat='${db:Status-Status}' \
+ --show systemd || echo "" )
+
+ if (test "$SYSTEMD_INSTALLED" = "installed"); then
+ sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only"
+ fi
+}
+
do_rootfs_postprocess[vardeps] = "${ROOTFS_POSTPROCESS_COMMAND}"
do_rootfs_postprocess[network] = "${TASK_USE_SUDO}"
python do_rootfs_postprocess() {
--
2.39.5
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251030113332.1809425-3-alexander.heinisch%40siemens.com.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v4 0/2] Enable systemd units based on systemd presets
2025-10-30 11:33 [PATCH v4 0/2] Enable systemd units based on systemd presets alexander.heinisch via isar-users
2025-10-30 11:33 ` [PATCH v4 1/2] Minor cleanup: Refactor ROOTFS_FEATURES assignment for image to make upcoming changes more easily trackable alexander.heinisch via isar-users
2025-10-30 11:33 ` [PATCH v4 2/2] classes/image-postproc: Enable systemd units based on systemd presets alexander.heinisch via isar-users
@ 2025-11-04 14:15 ` Zhihang Wei
2 siblings, 0 replies; 4+ messages in thread
From: Zhihang Wei @ 2025-11-04 14:15 UTC (permalink / raw)
To: alexander.heinisch, isar-users
Cc: jan.kiszka, felix.moessbauer, cedric.hombourger
Applied to next, thanks.
Bets regards,
Zhihang
On 10/30/25 12:33, alexander.heinisch@siemens.com wrote:
> From: Alexander Heinisch <alexander.heinisch@siemens.com>
>
> By default population of the presets is automatically done by systemd
> on first-boot.
>
> There were several issues with that:
>
> 1. The rootfs we get as a build artifact does not reflect the actual
> system running in the field.
>
> 2. For setups without writeable /etc this fails. With that addition
> it happens already at build time.
>
> Note: Additional services are enabled only. Services already enabled
> during the package installation won't be changed.
>
> Opt-out: `ROOTFS_FEATURES:remove = "populate-systemd-preset"`
>
> Changes since v1:
> - Documented changes in RECIPE-API-CHANGELOG.md
>
> Changes since v2:
> - Enable postprocessing to populate systemd presets via ROOTFS_FEATURES
>
> Changes since v3:
> - Check if systemctl is installed on the target rootfs before invoking it.
>
> => Tests fixed:
> ```
> $ avocado run citest.py:DevTest.test_dev --max-parallel-tasks=1
> JOB ID : 131df887f543d582a4e23d18759ef4d908a13485
> JOB LOG : /tmp/tmpaj335w6s/avocado/job-results/job-2025-10-30T10.32-131df88/job.log
> (1/6) citest.py:DevTest.test_dev: STARTED
> (1/6) citest.py:DevTest.test_dev: PASS (611.18 s)
> (2/6) citest.py:DevTest.test_dev_apps: STARTED
> (2/6) citest.py:DevTest.test_dev_apps: PASS (625.95 s)
> (3/6) citest.py:DevTest.test_dev_rebuild: STARTED
> (3/6) citest.py:DevTest.test_dev_rebuild: PASS (243.81 s)
> (4/6) citest.py:DevTest.test_dev_run_amd64_bookworm: STARTED
> (4/6) citest.py:DevTest.test_dev_run_amd64_bookworm: PASS (72.85 s)
> (5/6) citest.py:DevTest.test_dev_run_arm64_bookworm: STARTED
> (5/6) citest.py:DevTest.test_dev_run_arm64_bookworm: PASS (35.98 s)
> (6/6) citest.py:DevTest.test_dev_run_arm_bookworm: STARTED
> (6/6) citest.py:DevTest.test_dev_run_arm_bookworm: PASS (40.02 s)
> RESULTS : PASS 6 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
> JOB TIME : 1634.63 s
> ```
>
> Alexander Heinisch (2):
> Minor cleanup: Refactor ROOTFS_FEATURES assignment for image to make
> upcoming changes more easily trackable.
> classes/image-postproc: Enable systemd units based on systemd presets
>
> RECIPE-API-CHANGELOG.md | 20 +++++++++++++++++++-
> meta/classes/image.bbclass | 10 +++++++++-
> meta/classes/rootfs.bbclass | 12 ++++++++++++
> 3 files changed, 40 insertions(+), 2 deletions(-)
>
> --
> 2.39.5
>
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/a1327d27-1f89-4588-8744-508e083be6c3%40ilbers.de.
^ permalink raw reply [flat|nested] 4+ messages in thread