Re: [PATCH v2 3/7] Add recipe for optee-client

[Jan Kiszka <jan.kiszka@siemens.com>]

On 22.06.23 20:43, Henning Schild wrote:
> Am Thu, 22 Jun 2023 20:36:17 +0200
> schrieb Jan Kiszka <jan.kiszka@siemens.com>:
> 
>> On 22.06.23 20:00, Henning Schild wrote:
>>> Am Thu, 22 Jun 2023 03:22:13 +0800
>>> schrieb baocheng_su@163.com:
>>>   
>>>> From: Baocheng Su <baocheng.su@siemens.com>
>>>>
>>>> optee-client provides the userland library for communicating with
>>>> the trusted applications running in OP-TEE.
>>>>
>>>> It also provides a optee-client-dev package for developing host
>>>> application that talks to the TA counterpart.
>>>>
>>>> Also a user land deamon tee-supplicant is provided to serve the
>>>> trusted applications for user-land resources such as RPMB
>>>> accessing.
>>>>
>>>> This brings the .inc for customization, and also a demo recipe for
>>>> stm32mp15x.
>>>>
>>>> The debianization is learnt from the debian offical package. The
>>>> tee-supplicant.service is refined by Jan to fix some timing issues.
>>>>
>>>> Signed-off-by: Baocheng Su <baocheng.su@siemens.com>
>>>> ---
>>>>  meta-isar/conf/machine/stm32mp15x.conf        |  2 +-
>>>>  .../optee-client-stm32mp15x_3.21.0.bb         | 18 +++++++
>>>>  .../optee-client/files/debian/compat          |  1 +
>>>>  .../optee-client/files/debian/control.tmpl    | 51
>>>> +++++++++++++++++++ .../optee-client/files/debian/rules.tmpl      |
>>>> 27 ++++++++++ .../files/debian/tee-supplicant.service       | 21
>>>> ++++++++ .../optee-client/optee-client-custom.inc      | 41
>>>> +++++++++++++++ 7 files changed, 160 insertions(+), 1 deletion(-)
>>>>  create mode 100644
>>>> meta-isar/recipes-bsp/optee-client/optee-client-stm32mp15x_3.21.0.bb
>>>> create mode 100644
>>>> meta/recipes-bsp/optee-client/files/debian/compat create mode
>>>> 100644 meta/recipes-bsp/optee-client/files/debian/control.tmpl
>>>> create mode 100755
>>>> meta/recipes-bsp/optee-client/files/debian/rules.tmpl create mode
>>>> 100644
>>>> meta/recipes-bsp/optee-client/files/debian/tee-supplicant.service
>>>> create mode 100644
>>>> meta/recipes-bsp/optee-client/optee-client-custom.inc
>>>>
>>>> diff --git a/meta-isar/conf/machine/stm32mp15x.conf
>>>> b/meta-isar/conf/machine/stm32mp15x.conf index 4fa4051..0b200d2
>>>> 100644 --- a/meta-isar/conf/machine/stm32mp15x.conf
>>>> +++ b/meta-isar/conf/machine/stm32mp15x.conf
>>>> @@ -16,4 +16,4 @@ WKS_FILE ?= "stm32mp15x.wks.in"
>>>>  IMAGER_INSTALL += "trusted-firmware-a-stm32mp15x
>>>> optee-os-stm32mp15x u-boot-stm32mp15x" IMAGER_BUILD_DEPS +=
>>>> "trusted-firmware-a-stm32mp15x optee-os-stm32mp15x
>>>> u-boot-stm32mp15x" -IMAGE_INSTALL += "u-boot-script"
>>>> +IMAGE_INSTALL += "u-boot-script tee-supplicant"
>>>> diff --git
>>>> a/meta-isar/recipes-bsp/optee-client/optee-client-stm32mp15x_3.21.0.bb
>>>> b/meta-isar/recipes-bsp/optee-client/optee-client-stm32mp15x_3.21.0.bb
>>>> new file mode 100644 index 0000000..18525e3 --- /dev/null
>>>> +++
>>>> b/meta-isar/recipes-bsp/optee-client/optee-client-stm32mp15x_3.21.0.bb
>>>> @@ -0,0 +1,18 @@ +#
>>>> +# Copyright (c) Siemens AG, 2023
>>>> +#
>>>> +# Authors:
>>>> +#  Su Bao Cheng <baocheng.su@siemens.com>
>>>> +#
>>>> +# SPDX-License-Identifier: MIT
>>>> +#
>>>> +
>>>> +require recipes-bsp/optee-client/optee-client-custom.inc
>>>> +
>>>> +SRC_URI +=
>>>> "https://github.com/OP-TEE/optee_client/archive/${PV}.tar.gz;downloadfilename=optee_client-${PV}.tar.gz"
>>>> +SRC_URI[sha256sum] =
>>>> "368164a539b85557d2079fa6cd839ec444869109f96de65d6569e58b0615d026"
>>>> + +S = "${WORKDIR}/optee_client-${PV}" +
>>>> +# Use RPMB emulation
>>>> +RPMB_EMU_BUILD_OPT = ""
>>>> diff --git a/meta/recipes-bsp/optee-client/files/debian/compat
>>>> b/meta/recipes-bsp/optee-client/files/debian/compat new file mode
>>>> 100644 index 0000000..f599e28
>>>> --- /dev/null
>>>> +++ b/meta/recipes-bsp/optee-client/files/debian/compat
>>>> @@ -0,0 +1 @@
>>>> +10
>>>> diff --git
>>>> a/meta/recipes-bsp/optee-client/files/debian/control.tmpl
>>>> b/meta/recipes-bsp/optee-client/files/debian/control.tmpl new file
>>>> mode 100644 index 0000000..6c68b1d --- /dev/null
>>>> +++ b/meta/recipes-bsp/optee-client/files/debian/control.tmpl
>>>> @@ -0,0 +1,51 @@  
>>>
>>> Since there is that ".service" file i would expect a "Depends:
>>> systemd" somewhere in here.
>>>
>>> You wrote that the debianization is copied/inspired from somewhere,
>>> maybe that Depends needs to be upstreamed.  
>>
>> It should eventually, and we already tried to reach the package
>> maintainer regarding how to contribute best, given that his package is
>> not yet on salsa. No response yet.
> 
> Ok, but the point likely remains. Something "systemd" should be in one
> or multiple of the "Depends:"

Not unlikely, yes.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux